https://bugzilla.redhat.com/show_bug.cgi?id=916797
Erik van Pienbroek <erik-fedora(a)vanpienbroek.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |
Flags| |fedora-review+
--- Comment #12 from Erik van Pienbroek <erik-fedora(a)vanpienbroek.nl> ---
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5423958
$ rpmlint mingw-glew.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
$ rpmlint mingw-glew-1.9.0-4.fc20.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint mingw32-glew-1.9.0-4.fc19.noarch.rpm
mingw32-glew-static-1.9.0-4.fc19.noarch.rpm
mingw32-glew-tools-1.9.0-4.fc19.noarch.rpm mingw64-glew-1.9.0-4.fc19.noarch.rpm
mingw64-glew-static-1.9.0-4.fc19.noarch.rpm
mingw64-glew-tools-1.9.0-4.fc19.noarch.rpm
mingw32-glew-static.noarch: W: no-documentation
mingw32-glew-tools.noarch: W: no-documentation
mingw64-glew-static.noarch: W: no-documentation
mingw64-glew-tools.noarch: W: no-documentation
6 packages and 0 specfiles checked; 0 errors, 4 warnings.
$ rpm --query --requires mingw32-glew
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
mingw32-crt
mingw32-filesystem >= 83
mingw32(kernel32.dll)
mingw32(libgcc_s_sjlj-1.dll)
mingw32(msvcrt.dll)
mingw32(opengl32.dll)
mingw32-pkg-config
rpmlib(PayloadIsXz) <= 5.2-1
$ rpm --query --requires mingw64-glew
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
mingw64-crt
mingw64-filesystem >= 83
mingw64(kernel32.dll)
mingw64(msvcrt.dll)
mingw64(opengl32.dll)
mingw64-pkg-config
rpmlib(PayloadIsXz) <= 5.2-1
$ rpm --query --requires mingw32-glew-static
mingw32-glew = 1.9.0-4.fc19
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadIsXz) <= 5.2-1
$ rpm --query --requires mingw64-glew-static
mingw64-glew = 1.9.0-4.fc19
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadIsXz) <= 5.2-1
$ rpm --query --requires mingw32-glew-tools
mingw32-glew = 1.9.0-4.fc19
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
mingw32-crt
mingw32-filesystem >= 83
mingw32(gdi32.dll)
mingw32(glew32.dll)
mingw32(kernel32.dll)
mingw32(msvcrt.dll)
mingw32(opengl32.dll)
mingw32(user32.dll)
rpmlib(PayloadIsXz) <= 5.2-1
$ rpm --query --requires mingw64-glew-tools
mingw64-glew = 1.9.0-4.fc19
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
mingw64-crt
mingw64-filesystem >= 83
mingw64(gdi32.dll)
mingw64(glew32.dll)
mingw64(kernel32.dll)
mingw64(msvcrt.dll)
mingw64(opengl32.dll)
mingw64(user32.dll)
rpmlib(PayloadIsXz) <= 5.2-1
$ rpm --query --provides mingw32-glew
mingw32-glew = 1.9.0-4.fc19
mingw32(glew32.dll)
mingw32(glew32mx.dll)
$ rpm --query --provides mingw64-glew
mingw64-glew = 1.9.0-4.fc19
mingw64(glew32.dll)
mingw64(glew32mx.dll)
$ rpm --query --provides mingw32-glew-static
mingw32-glew-static = 1.9.0-4.fc19
$ rpm --query --provides mingw64-glew-static
mingw64-glew-static = 1.9.0-4.fc19
$ rpm --query --provides mingw32-glew-tools
mingw32-glew-tools = 1.9.0-4.fc19
$ rpm --query --provides mingw64-glew-tools
mingw64-glew-tools = 1.9.0-4.fc19
$ wget --quiet http://downloads.sourceforge.net/glew/glew-1.9.0.tgz -O - |
md5sum
69ce911decef6249d24742497e6ad06a -
$ md5sum glew-1.9.0.tgz
69ce911decef6249d24742497e6ad06a glew-1.9.0.tgz
+ OK
! Needs to be looked into
/ Not applicable
[+] Compliant with generic Fedora Packaging Guidelines
[+] Source package name is prefixed with 'mingw-'
[+] Spec file starts with %{?mingw_package_header}
[+] BuildRequires: mingw32-filesystem >= 95 is in the .spec file
[+] BuildRequires: mingw64-filesystem >= 95 is in the .spec file
[+] Spec file contains %package sections for both mingw32 and mingw64 packages
[+] Binary mingw32 and mingw64 packages are noarch
[+] Spec file contains %{?mingw_debug_package} after the %description section
[!] Uses one of the macros %mingw_configure, %mingw_cmake, or %mingw_cmake_kde4
to configure the package
[!] Uses the macro %mingw_make to build the package
[!] Uses the macro %mingw_make to install the package
[+] If package contains translations, the %mingw_find_lang macro must be used
[+] No binary package named mingw-$pkgname is generated
[+] Libtool .la files are not bundled
[+] .def files are not bundled
[+] Man pages which duplicate native package are not bundled
[+] Info files which duplicate native package are not bundled
[+] Provides of the binary mingw32 and mingw64 packages are equal
[!] Requires of the binary mingw32 and mingw64 packages are equal
The mingw32 package seems to depend on libgcc_s_sjlj-1.dll while the mingw64
package doesn't. I've also seen this on various other packages so we can
ignore this for now
This package doesn't use any of the configure and make-related mingw macros.
Normally this is a blocker, but given the fact that upstream of this package
uses hand-written Makefiles (instead of a generic build system like autotools)
I'm okay with the way the package is built in the current .spec file.
================================================
The package mingw-glew is APPROVED by epienbro
================================================
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hEptxxYxhj&a=cc_unsubscribe
https://bugzilla.redhat.com/show_bug.cgi?id=916797
--- Comment #8 from Erik van Pienbroek <erik-fedora(a)vanpienbroek.nl> ---
The FPC has just approved our updated packaging guidelines and have also made
an addition to it:
Executables which are required for proper functionality of the libraries must
be packaged in the matching mingw32/mingw64 subpackage. All other executables
are discouraged, but may be packaged in optional (dependent) subpackages at
a packager's discretion.
This situation applies to this package.
The executables which are part of this package are not required for proper
functionality of the library so therefore the recommended approach is to place
them in subpackages. You've already done this with your -tools subpackages so
this package complies with the mingw packaging guidelines now
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AfP1f2kUts&a=cc_unsubscribe
Hi all,
Over the last couple of months I received some feedback about the
current Fedora MinGW Packaging Guidelines. Some topics were missing and
other weren't verbose enough. Therefore I just created a draft with
updated packaging guidelines in which all the feedback was
incorporated.
Before letting the Fedora Packaging Committee (FPC) make a final
decision about this draft I want to let the Fedora MinGW users review it
first.
The draft packaging guidelines can be found at
https://fedoraproject.org/wiki/PackagingDrafts/MinGWCrossCompiler
The diff against the current MinGW packaging guidelines can be found at
https://fedoraproject.org/w/index.php?title=PackagingDrafts%
2FMinGWCrossCompiler&diff=337954&oldid=302743
The following changes are done in the updated packaging guidelines:
1. Removed all references to %mingw_make_install as it shouldn't be
used any more
2. Removed the Group tag as it isn't needed any more according to
http://fedoraproject.org/wiki/Packaging/Guidelines#Group_tag
3. Added macros for Qt4 and Qt5 (%mingw{,32,64}-qmake-qt{4,5})
4. Added a column to various tables to indicate in which version
of mingw-filesystem the macro in question was added
5. Make it more clear that packages don't need to
BuildRequires: mingw-filesystem (as mentioned in
https://bugzilla.redhat.com/show_bug.cgi?id=895566)
6. Added a section explaining what to do with executables
7. Replaced the section about man/info pages with a more generic
section about files which shouldn't be bundled when they are
already part of native packages
7a. autoconf macro files shouldn't be bundled in mingw packages any more
If you think something is still missing, the text is too difficult to
read (English is not my native language) or you don't agree with any of
the proposed changes please let me know so it can be fixed before
handing everything over to the FPC. Please also let me know if you're +1
to the proposed changes. Feedback can be sent until tomorrow evening.
The next FPC meeting is this Thursday so let's hope we can still get
everything ready in time.
Regards,
Erik van Pienbroek
https://bugzilla.redhat.com/show_bug.cgi?id=961403
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|MODIFIED |ON_QA
--- Comment #9 from Fedora Update System <updates(a)fedoraproject.org> ---
mingw-gtkspell3-3.0.2-3.fc18 has been pushed to the Fedora 18 testing
repository.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2qKX9o4t66&a=cc_unsubscribe