[Bug 1066559] Review Request: mingw-id3lib - Library for manipulating ID3v1 and ID3v2 tags
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1066559
--- Comment #8 from David King <amigadave(a)amigadave.com> ---
(In reply to František Dvořák from comment #7)
> I'm sorry, I swapped the arguments for touch ('-r' is for the reference
> file):
Fixed! My fault for not checking. :-)
> Also the dll library has atypical name: libid3-3-8-3.dll. It is possible to
> change it by removing "-release $(LT_RELEASE)" from libid3_la_LDFLAGS (in
> the mingw patch), then name would be libid3-3.dll. I'm not sure if it is
> important, it is probably mere cosmetics...
It has an odd name on Linux too: libid3-3.8.so.3.0.0
I would tend towards leaving this as is, because there is not likely to be
another id3lib release (although I would be really happy if there was a new
release containing the many fixes that have accumulated over the decade since
3.8.3 was released), so there is some possibility of being compatible with
other binary builds of id3lib with the same library versioning.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iUZSpXam3S&a=cc_unsubscribe
10 years, 2 months
[Bug 1066559] Review Request: mingw-id3lib - Library for manipulating ID3v1 and ID3v2 tags
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1066559
František Dvořák <valtri(a)civ.zcu.cz> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #7 from František Dvořák <valtri(a)civ.zcu.cz> ---
I'm sorry, I swapped the arguments for touch ('-r' is for the reference file):
iconv -f ISO-8859-1 -t UTF8 ChangeLog > tmp && \
touch -r ChangeLog tmp && \
mv tmp ChangeLog
Also the dll library has atypical name: libid3-3-8-3.dll. It is possible to
change it by removing "-release $(LT_RELEASE)" from libid3_la_LDFLAGS (in the
mingw patch), then name would be libid3-3.dll. I'm not sure if it is important,
it is probably mere cosmetics...
Fixing touch (and changing result dll name if to do it) can be done post
review.
Package APPROVED!
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tvd3NNzCzm&a=cc_unsubscribe
10 years, 2 months