[Bug 1096796] Review Request: mingw-SDL2 - MinGW Windows port of SDL2 cross-platform multimedia library
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1096796
Erik van Pienbroek <erik-fedora(a)vanpienbroek.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #5 from Erik van Pienbroek <erik-fedora(a)vanpienbroek.nl> ---
$ rpmlint mingw-SDL2.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
$ rpmlint mingw-SDL2-2.0.3-2.fc21.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint mingw32-SDL2-2.0.3-2.fc21.noarch.rpm
mingw64-SDL2-2.0.3-2.fc21.noarch.rpm
mingw32-SDL2.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/mingw32-SDL2/COPYING.txt
mingw32-SDL2.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/mingw32-SDL2/README.txt
mingw64-SDL2.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/mingw64-SDL2/README.txt
mingw64-SDL2.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/mingw64-SDL2/COPYING.txt
2 packages and 0 specfiles checked; 0 errors, 4 warnings.
$ rpm --query --requires mingw32-SDL2
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
mingw32-crt
mingw32-filesystem >= 95
mingw32(gdi32.dll)
mingw32(iconv.dll)
mingw32(imm32.dll)
mingw32(kernel32.dll)
mingw32(msvcrt.dll)
mingw32(ole32.dll)
mingw32(oleaut32.dll)
mingw32-pkg-config
mingw32(shell32.dll)
mingw32(user32.dll)
mingw32(version.dll)
mingw32(winmm.dll)
rpmlib(PayloadIsXz) <= 5.2-1
$ rpm --query --requires mingw64-SDL2
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
mingw64-crt
mingw64-filesystem >= 95
mingw64(gdi32.dll)
mingw64(iconv.dll)
mingw64(imm32.dll)
mingw64(kernel32.dll)
mingw64(msvcrt.dll)
mingw64(ole32.dll)
mingw64(oleaut32.dll)
mingw64-pkg-config
mingw64(shell32.dll)
mingw64(user32.dll)
mingw64(version.dll)
mingw64(winmm.dll)
rpmlib(PayloadIsXz) <= 5.2-1
$ rpm --query --provides mingw32-SDL2
mingw32-SDL2 = 2.0.3-2.fc21
mingw32(sdl2.dll)
$ rpm --query --provides mingw64-SDL2
mingw64-SDL2 = 2.0.3-2.fc21
mingw64(sdl2.dll)
$ wget --quiet http://www.libsdl.org/release/SDL2-2.0.3.tar.gz -O - | md5sum
fe6c61d2e9df9ef570e7e80c6e822537 -
$ md5sum SDL2-2.0.3.tar.gz
fe6c61d2e9df9ef570e7e80c6e822537 SDL2-2.0.3.tar.gz
+ OK
! Needs to be looked into
/ Not applicable
[!] Compliant with generic Fedora Packaging Guidelines
[+] Source package name is prefixed with 'mingw-'
[+] Spec file starts with %{?mingw_package_header}
[+] BuildRequires: mingw32-filesystem >= 95 is in the .spec file
[+] BuildRequires: mingw64-filesystem >= 95 is in the .spec file
[+] Spec file contains %package sections for both mingw32 and mingw64 packages
[+] Binary mingw32 and mingw64 packages are noarch
[+] Spec file contains %{?mingw_debug_package} after the %description section
[+] Uses one of the macros %mingw_configure, %mingw_cmake, or %mingw_cmake_kde4
to configure the package
[+] Uses the macro %mingw_make to build the package
[+] Uses the macro %mingw_make to install the package
[/] If package contains translations, the %mingw_find_lang macro must be used
[+] No binary package named mingw-$pkgname is generated
[+] Libtool .la files are not bundled
[+] .def files are not bundled
[+] Man pages which duplicate native package are not bundled
[+] Info files which duplicate native package are not bundled
[+] Provides of the binary mingw32 and mingw64 packages are equal
[+] Requires of the binary mingw32 and mingw64 packages are equal
The rpmlint warnings still need to be resolved. This can be done
by adding a 'BuildRequires: dos2unix' and adding the command
'dos2unix COPYING.txt README.txt' after the %setup line
Please fix this before importing the package in Fedora
===================================================
The package mingw-libSDL2 is APPROVED by epienbro
===================================================
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AL2xhWW0cB&a=cc_unsubscribe
9 years, 11 months