mingw June 2014

mingw@lists.fedoraproject.org

3 participants
68 discussions

[Bug 1110027] Review Request: mingw-gsm - Shared libraries for GSM speech compressor
by Red Hat Bugzilla 23 Jun '14

23 Jun '14

https://bugzilla.redhat.com/show_bug.cgi?id=1110027 --- Comment #3 from František Dvořák <valtri(a)civ.zcu.cz> --- (In reply to David King from comment #2) > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > > It would be nice to have a comment (or something similar) about the applied > patches, but they are simple enough (and it's not a requirement). > OK, it may be useful. The first three patches are from the native gsm package, and mingw would deserve some description. > Would you mind doing a review swap with bug 1076456? > Absolutely. Thanks for the review! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8hJ8c7BsZn&a=cc_unsubscribe

1 0

[Bug 1076456] Review Request: mingw-libid3tag - ID3 tag manipulation library
by Red Hat Bugzilla 23 Jun '14

23 Jun '14

https://bugzilla.redhat.com/show_bug.cgi?id=1076456 František Dvořák <valtri(a)civ.zcu.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |valtri(a)civ.zcu.cz Flags| |fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rFs2LSzk5A&a=cc_unsubscribe

1 0

[Bug 1110027] Review Request: mingw-gsm - Shared libraries for GSM speech compressor
by Red Hat Bugzilla 23 Jun '14

23 Jun '14

https://bugzilla.redhat.com/show_bug.cgi?id=1110027 David King <amigadave(a)amigadave.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |amigadave(a)amigadave.com Assignee|nobody(a)fedoraproject.org |amigadave(a)amigadave.com Flags| |fedora-review+ --- Comment #2 from David King <amigadave(a)amigadave.com> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated It would be nice to have a comment (or something similar) about the applied patches, but they are simple enough (and it's not a requirement). Would you mind doing a review swap with bug 1076456? Issues: ======= - Header files in -devel subpackage, if present. Note: mingw32-gsm : /usr/i686-w64-mingw32/sys-root/mingw/include/gsm.h mingw32-gsm : /usr/i686-w64-mingw32/sys-root/mingw/include/gsm/gsm.h mingw64-gsm : /usr/x86_64-w64-mingw32/sys-root/mingw/include/gsm.h mingw64-gsm : /usr/x86_64-w64-mingw32/sys-root/mingw/include/gsm/gsm.h See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages Not a problem for mingw packages. - Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: mingw32-gsm, mingw64-gsm. Illegal package name: mingw32-gsm, mingw64-gsm. Does not provide -static: mingw32-gsm, mingw64-gsm. See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries Also not a problem for Fedora mingw packages. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 41 files have unknown license. Detailed output of licensecheck in /home/david/checkout/rpms/1110027-mingw- gsm/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 6 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mingw32-gsm , mingw32-gsm-tools , mingw64-gsm , mingw64-gsm-tools [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: mingw32-gsm-1.0.13-1.fc21.noarch.rpm mingw32-gsm-tools-1.0.13-1.fc21.noarch.rpm mingw64-gsm-1.0.13-1.fc21.noarch.rpm mingw64-gsm-tools-1.0.13-1.fc21.noarch.rpm mingw-gsm-1.0.13-1.fc21.src.rpm mingw32-gsm.noarch: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment mingw32-gsm.noarch: W: spelling-error %description -l en_US libgsm -> liberalism mingw32-gsm.noarch: W: spelling-error %description -l en_US transcoding -> trans coding, trans-coding, transcending mingw32-gsm.noarch: W: spelling-error %description -l en_US prI -> pr I, pr, pro mingw32-gsm.noarch: W: spelling-error %description -l en_US kbit -> knit, kit, bit mingw32-gsm.noarch: W: spelling-error %description -l en_US modelled -> modeled, model led, model-led mingw32-gsm.noarch: W: spelling-error %description -l en_US realtime -> mealtime, real time, real-time mingw32-gsm.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-w64-mingw32/sys-root/mingw/lib/libgsm.dll.a mingw32-gsm.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/lib/libgsm.dll.a mingw32-gsm.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/gsm/gsm.h mingw32-gsm.noarch: W: non-standard-dir-in-usr i686-w64-mingw32 mingw32-gsm-tools.noarch: W: spelling-error %description -l en_US libgsm -> liberalism mingw32-gsm-tools.noarch: W: spelling-error %description -l en_US transcoding -> trans coding, trans-coding, transcending mingw32-gsm-tools.noarch: W: spelling-error %description -l en_US prI -> pr I, pr, pro mingw32-gsm-tools.noarch: W: spelling-error %description -l en_US kbit -> knit, kit, bit mingw32-gsm-tools.noarch: W: no-documentation mingw32-gsm-tools.noarch: W: non-standard-dir-in-usr i686-w64-mingw32 mingw64-gsm.noarch: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment mingw64-gsm.noarch: W: spelling-error %description -l en_US libgsm -> liberalism mingw64-gsm.noarch: W: spelling-error %description -l en_US transcoding -> trans coding, trans-coding, transcending mingw64-gsm.noarch: W: spelling-error %description -l en_US prI -> pr I, pr, pro mingw64-gsm.noarch: W: spelling-error %description -l en_US kbit -> knit, kit, bit mingw64-gsm.noarch: W: spelling-error %description -l en_US modelled -> modeled, model led, model-led mingw64-gsm.noarch: W: spelling-error %description -l en_US realtime -> mealtime, real time, real-time mingw64-gsm.noarch: E: arch-independent-package-contains-binary-or-object /usr/x86_64-w64-mingw32/sys-root/mingw/lib/libgsm.dll.a mingw64-gsm.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/lib/libgsm.dll.a mingw64-gsm.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/gsm/gsm.h mingw64-gsm.noarch: W: non-standard-dir-in-usr x86_64-w64-mingw32 mingw64-gsm-tools.noarch: W: spelling-error %description -l en_US libgsm -> liberalism mingw64-gsm-tools.noarch: W: spelling-error %description -l en_US transcoding -> trans coding, trans-coding, transcending mingw64-gsm-tools.noarch: W: spelling-error %description -l en_US prI -> pr I, pr, pro mingw64-gsm-tools.noarch: W: spelling-error %description -l en_US kbit -> knit, kit, bit mingw64-gsm-tools.noarch: W: no-documentation mingw64-gsm-tools.noarch: W: non-standard-dir-in-usr x86_64-w64-mingw32 mingw-gsm.src: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment mingw-gsm.src: W: spelling-error %description -l en_US libgsm -> liberalism mingw-gsm.src: W: spelling-error %description -l en_US transcoding -> trans coding, trans-coding, transcending mingw-gsm.src: W: spelling-error %description -l en_US prI -> pr I, pr, pro mingw-gsm.src: W: spelling-error %description -l en_US kbit -> knit, kit, bit mingw-gsm.src: W: spelling-error %description -l en_US modelled -> modeled, model led, model-led mingw-gsm.src: W: spelling-error %description -l en_US realtime -> mealtime, real time, real-time 5 packages and 0 specfiles checked; 2 errors, 39 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint mingw32-gsm mingw64-gsm-tools mingw32-gsm-tools min gw64-gsm mingw32-gsm.noarch: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment mingw32-gsm.noarch: W: spelling-error %description -l en_US libgsm -> liberalism mingw32-gsm.noarch: W: spelling-error %description -l en_US transcoding -> trans coding, trans-coding, transcending mingw32-gsm.noarch: W: spelling-error %description -l en_US prI -> pr I, pr, pro mingw32-gsm.noarch: W: spelling-error %description -l en_US kbit -> knit, kit, bit mingw32-gsm.noarch: W: spelling-error %description -l en_US modelled -> modeled, model led, model-led mingw32-gsm.noarch: W: spelling-error %description -l en_US realtime -> mealtime, real time, real-time mingw64-gsm-tools.noarch: W: spelling-error %description -l en_US libgsm -> liberalism mingw64-gsm-tools.noarch: W: spelling-error %description -l en_US transcoding -> trans coding, trans-coding, transcending mingw64-gsm-tools.noarch: W: spelling-error %description -l en_US prI -> pr I, pr, pro mingw64-gsm-tools.noarch: W: spelling-error %description -l en_US kbit -> knit, kit, bit mingw64-gsm-tools.noarch: W: no-documentation mingw32-gsm-tools.noarch: W: spelling-error %description -l en_US libgsm -> liberalism mingw32-gsm-tools.noarch: W: spelling-error %description -l en_US transcoding -> trans coding, trans-coding, transcending mingw32-gsm-tools.noarch: W: spelling-error %description -l en_US prI -> pr I, pr, pro mingw32-gsm-tools.noarch: W: spelling-error %description -l en_US kbit -> knit, kit, bit mingw32-gsm-tools.noarch: W: no-documentation mingw64-gsm.noarch: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment mingw64-gsm.noarch: W: spelling-error %description -l en_US libgsm -> liberalism mingw64-gsm.noarch: W: spelling-error %description -l en_US transcoding -> trans coding, trans-coding, transcending mingw64-gsm.noarch: W: spelling-error %description -l en_US prI -> pr I, pr, pro mingw64-gsm.noarch: W: spelling-error %description -l en_US kbit -> knit, kit, bit mingw64-gsm.noarch: W: spelling-error %description -l en_US modelled -> modeled, model led, model-led mingw64-gsm.noarch: W: spelling-error %description -l en_US realtime -> mealtime, real time, real-time 4 packages and 0 specfiles checked; 0 errors, 24 warnings. # echo 'rpmlint-done:' The warnings do not seem to be problematic, and there are no errors (besides the not-relevant-for-mingw ones), so this seems fine to me. Requires -------- mingw32-gsm (rpmlib, GLIBC filtered): mingw32(kernel32.dll) mingw32(msvcrt.dll) mingw32(user32.dll) mingw32-crt mingw32-filesystem mingw64-gsm-tools (rpmlib, GLIBC filtered): mingw64(kernel32.dll) mingw64(libgsm-1.dll) mingw64(msvcrt.dll) mingw64-crt mingw64-filesystem mingw64-gsm mingw32-gsm-tools (rpmlib, GLIBC filtered): mingw32(kernel32.dll) mingw32(libgsm-1.dll) mingw32(msvcrt.dll) mingw32-crt mingw32-filesystem mingw32-gsm mingw64-gsm (rpmlib, GLIBC filtered): mingw64(kernel32.dll) mingw64(msvcrt.dll) mingw64(user32.dll) mingw64-crt mingw64-filesystem Provides -------- mingw32-gsm: mingw32(libgsm-1.dll) mingw32-gsm mingw64-gsm-tools: mingw64-gsm-tools mingw32-gsm-tools: mingw32-gsm-tools mingw64-gsm: mingw64(libgsm-1.dll) mingw64-gsm Source checksums ---------------- http://www.quut.com/gsm/gsm-1.0.13.tar.gz : CHECKSUM(SHA256) this package : 52c518244d428c2e56c543b98c9135f4a76ff780c32455580b793f60a0a092ad CHECKSUM(SHA256) upstream package : 52c518244d428c2e56c543b98c9135f4a76ff780c32455580b793f60a0a092ad Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b 1110027 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tTuwv76Cdr&a=cc_unsubscribe

1 0

[Bug 849693] CVE-2012-3509 libiberty: integer overflow, leading to heap-buffer overflow by processing certain file headers via bfd binary
by Red Hat Bugzilla 17 Jun '14

17 Jun '14

https://bugzilla.redhat.com/show_bug.cgi?id=849693 Bug 849693 depends on bug 1059390, which changed state. Bug 1059390 Summary: cross-binutils may be affected by libiberty CVE https://bugzilla.redhat.com/show_bug.cgi?id=1059390 What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |CURRENTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nqCtC9TiTZ&a=cc_unsubscribe

1 0

[Bug 1110027] Review Request: mingw-gsm - Shared libraries for GSM speech compressor
by Red Hat Bugzilla 16 Jun '14

16 Jun '14

https://bugzilla.redhat.com/show_bug.cgi?id=1110027 František Dvořák <valtri(a)civ.zcu.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora-mingw(a)lists.fedorapr | |oject.org Blocks|177841 (FE-NEEDSPONSOR), | |201449 (FE-DEADREVIEW) | Alias| |mingw-gsm Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7m20BT1XZ7&a=cc_unsubscribe

1 0

Package Retirement
by Michael Cronenworth 16 Jun '14

16 Jun '14

Hi all, I'm going to be retiring mingw-plibc soon. It was required by mingw-libmicrohttpd, but with the latest libmicrohttpd release the dependency has been dropped. I don't have another use for it, and I don't think anyone else will find it useful or should depend on it. If someone wants to take it speak now or forever hold your peace. Thanks, Michael

1 0

[Bug 1096809] Review Request: mingw-SDL2_mixer - MinGW Windows port of Simple DirectMedia Layer's Sample Mixer Library
by Red Hat Bugzilla 15 Jun '14

15 Jun '14

https://bugzilla.redhat.com/show_bug.cgi?id=1096809 David King <amigadave(a)amigadave.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |amigadave(a)amigadave.com Assignee|nobody(a)fedoraproject.org |amigadave(a)amigadave.com Flags| |fedora-review? --- Comment #3 from David King <amigadave(a)amigadave.com> --- Generally, it looks pretty good, just the homepage location needs fixing. * the homepage (URL and Source0) has a typo, it should be: http://www.libsdl.org/projects/SDL_mixer/ Would you be able to do a review swap with bug 1076456? Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Header files in -devel subpackage, if present. Note: mingw32-SDL2_mixer : /usr/i686-w64-mingw32/sys- root/mingw/include/SDL2/SDL_mixer.h mingw64-SDL2_mixer : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL2/SDL_mixer.h See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages Not a problem for mingw packages. - Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: mingw32-SDL2_mixer, mingw64-SDL2_mixer. Illegal package name: mingw32-SDL2_mixer, mingw64-SDL2_mixer. Does not provide -static: mingw32-SDL2_mixer, mingw64-SDL2_mixer. See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries Also not a problem for mingw packages. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* GPL (v2 or later) (with incorrect FSF address)", "LGPL (v2.1 or later) (with incorrect FSF address)", "GPL (v2 or later)", "Unknown or generated", "LGPL (v2 or later) (with incorrect FSF address)", "ISC", "zlib/libpng", "GPL (v2 or later) (with incorrect FSF address)", "BSD (3 clause)", "LGPL (with incorrect FSF address)", "LGPL (v2.1 or later)", "*No copyright* Public domain". 313 files have unknown license. Detailed output of licensecheck in /home/david/checkout/rpms/1096809-mingw-SDL2_mixer/licensecheck.txt All the licenses other than zlib are in third-party libraries, which are not built, so the license tag is fine. [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/x86_64-w64-mingw32/sys- root/mingw/include/SDL2(mingw64-SDL2), /usr/i686-w64-mingw32/sys- root/mingw/include/SDL2(mingw32-SDL2) As the binary packages generated from this package require SDL2, not owning those directories is fine. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 6 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: http://www.libSDL2.org/projects/SDL_mixer/release/SDL2_mixer-2.0.0.tar.gz See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags Incorrect homepage location, already mentioned above. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mingw32-SDL2_mixer , mingw64-SDL2_mixer [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: The placement of pkgconfig(.pc) files are correct. Note: mingw32-SDL2_mixer : /usr/i686-w64-mingw32/sys- root/mingw/lib/pkgconfig/SDL2_mixer.pc mingw64-SDL2_mixer : /usr/x86_64-w64-mingw32/sys-root/mingw/lib/pkgconfig/SDL2_mixer.pc [-]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: mingw32-SDL2_mixer-2.0.0-2.fc21.noarch.rpm mingw64-SDL2_mixer-2.0.0-2.fc21.noarch.rpm mingw-SDL2_mixer-2.0.0-2.fc21.src.rpm mingw32-SDL2_mixer.noarch: W: spelling-error %description -l en_US multi -> mulch, mufti mingw32-SDL2_mixer.noarch: W: invalid-url URL: http://www.libSDL2.org/projects/SDL_mixer/ <urlopen error [Errno 111] Connection refused> mingw32-SDL2_mixer.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-w64-mingw32/sys-root/mingw/lib/libSDL2_mixer.dll.a mingw32-SDL2_mixer.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mingw32-SDL2_mixer/COPYING.txt mingw32-SDL2_mixer.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mingw32-SDL2_mixer/README.txt mingw32-SDL2_mixer.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/include/SDL2/SDL_mixer.h mingw32-SDL2_mixer.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/lib/libSDL2_mixer.dll.a mingw32-SDL2_mixer.noarch: W: spurious-executable-perm /usr/i686-w64-mingw32/sys-root/mingw/lib/libSDL2_mixer.dll.a mingw32-SDL2_mixer.noarch: W: devel-file-in-non-devel-package /usr/i686-w64-mingw32/sys-root/mingw/lib/pkgconfig/SDL2_mixer.pc mingw32-SDL2_mixer.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mingw32-SDL2_mixer/CHANGES.txt mingw32-SDL2_mixer.noarch: W: non-standard-dir-in-usr i686-w64-mingw32 mingw64-SDL2_mixer.noarch: W: spelling-error %description -l en_US multi -> mulch, mufti mingw64-SDL2_mixer.noarch: W: invalid-url URL: http://www.libSDL2.org/projects/SDL_mixer/ <urlopen error [Errno 111] Connection refused> mingw64-SDL2_mixer.noarch: E: arch-independent-package-contains-binary-or-object /usr/x86_64-w64-mingw32/sys-root/mingw/lib/libSDL2_mixer.dll.a mingw64-SDL2_mixer.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL2/SDL_mixer.h mingw64-SDL2_mixer.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mingw64-SDL2_mixer/CHANGES.txt mingw64-SDL2_mixer.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/lib/libSDL2_mixer.dll.a mingw64-SDL2_mixer.noarch: W: spurious-executable-perm /usr/x86_64-w64-mingw32/sys-root/mingw/lib/libSDL2_mixer.dll.a mingw64-SDL2_mixer.noarch: W: devel-file-in-non-devel-package /usr/x86_64-w64-mingw32/sys-root/mingw/lib/pkgconfig/SDL2_mixer.pc mingw64-SDL2_mixer.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mingw64-SDL2_mixer/COPYING.txt mingw64-SDL2_mixer.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mingw64-SDL2_mixer/README.txt mingw64-SDL2_mixer.noarch: W: non-standard-dir-in-usr x86_64-w64-mingw32 mingw-SDL2_mixer.src: W: spelling-error %description -l en_US multi -> mulch, mufti mingw-SDL2_mixer.src: W: invalid-url URL: http://www.libSDL2.org/projects/SDL_mixer/ <urlopen error [Errno 111] Connection refused> mingw-SDL2_mixer.src: W: invalid-url Source0: http://www.libSDL2.org/projects/SDL_mixer/release/SDL2_mixer-2.0.0.tar.gz <urlopen error [Errno 111] Connection refused> 3 packages and 0 specfiles checked; 2 errors, 23 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint mingw32-SDL2_mixer mingw64-SDL2_mixer mingw32-SDL2_mixer.noarch: W: spelling-error %description -l en_US multi -> mulch, mufti mingw32-SDL2_mixer.noarch: W: invalid-url URL: http://www.libSDL2.org/projects/SDL_mixer/ <urlopen error [Errno 111] Connection refused> mingw32-SDL2_mixer.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mingw32-SDL2_mixer/COPYING.txt mingw32-SDL2_mixer.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mingw32-SDL2_mixer/README.txt mingw32-SDL2_mixer.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mingw32-SDL2_mixer/CHANGES.txt mingw64-SDL2_mixer.noarch: W: spelling-error %description -l en_US multi -> mulch, mufti mingw64-SDL2_mixer.noarch: W: invalid-url URL: http://www.libSDL2.org/projects/SDL_mixer/ <urlopen error [Errno 111] Connection refused> mingw64-SDL2_mixer.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mingw64-SDL2_mixer/CHANGES.txt mingw64-SDL2_mixer.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mingw64-SDL2_mixer/COPYING.txt mingw64-SDL2_mixer.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/mingw64-SDL2_mixer/README.txt 2 packages and 0 specfiles checked; 0 errors, 10 warnings. # echo 'rpmlint-done:' Requires -------- mingw32-SDL2_mixer (rpmlib, GLIBC filtered): mingw32(kernel32.dll) mingw32(libflac-8.dll) mingw32(libvorbisfile-3.dll) mingw32(msvcrt.dll) mingw32(sdl2.dll) mingw32(winmm.dll) mingw32-crt mingw32-filesystem mingw32-pkg-config mingw64-SDL2_mixer (rpmlib, GLIBC filtered): mingw64(kernel32.dll) mingw64(libflac-8.dll) mingw64(libvorbisfile-3.dll) mingw64(msvcrt.dll) mingw64(sdl2.dll) mingw64(winmm.dll) mingw64-crt mingw64-filesystem mingw64-pkg-config Provides -------- mingw32-SDL2_mixer: mingw32(sdl2_mixer.dll) mingw32-SDL2_mixer mingw64-SDL2_mixer: mingw64(sdl2_mixer.dll) mingw64-SDL2_mixer Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b 1096809 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YgbrDZx0zS&a=cc_unsubscribe

1 0

[Bug 1074646] CVE-2014-2240 CVE-2014-2241 freetype: OOB stack-based read/write in cf2_hintmap_build()
by Red Hat Bugzilla 13 Jun '14

13 Jun '14

https://bugzilla.redhat.com/show_bug.cgi?id=1074646 --- Comment #5 from Kevin Kofler <kevin(a)tigcc.ticalc.org> --- And for anybody who might want to know, this is also fixed in: freetype-freeworld-2.5.0.1-4.fc20 in that well-known third-party repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WIB5BxdpyW&a=cc_unsubscribe

1 0

[Bug 1074646] CVE-2014-2240 CVE-2014-2241 freetype: OOB stack-based read/write in cf2_hintmap_build()
by Red Hat Bugzilla 13 Jun '14

13 Jun '14

https://bugzilla.redhat.com/show_bug.cgi?id=1074646 Bug 1074646 depends on bug 1074647, which changed state. Bug 1074647 Summary: CVE-2014-2240 freetype: OOB stack-based read/write in cf2_hintmap_build() [fedora-20] https://bugzilla.redhat.com/show_bug.cgi?id=1074647 What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=0SHqfVICoL&a=cc_unsubscribe

1 0

[Bug 1074646] CVE-2014-2240 CVE-2014-2241 freetype: OOB stack-based read/write in cf2_hintmap_build()
by Red Hat Bugzilla 13 Jun '14

13 Jun '14

https://bugzilla.redhat.com/show_bug.cgi?id=1074646 Vincent Danen <vdanen(a)redhat.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |ERRATA Last Closed| |2014-06-13 14:54:17 --- Comment #4 from Vincent Danen <vdanen(a)redhat.com> --- This is currently fixed in: mingw-freetype-2.5.0.1-2.fc20 mingw-freetype-2.4.12-3.fc19 freetype-2.5.0-5.fc20 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Broj66wbnn&a=cc_unsubscribe

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

mingw June 2014