[Bug 904634] Review Request: mingw-sword - MinGW build of a cross-platform scripture text library
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=904634
Michael Cronenworth <mike(a)cchtml.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|nobody(a)fedoraproject.org |mike(a)cchtml.com
Flags| |fedora-review?
--- Comment #7 from Michael Cronenworth <mike(a)cchtml.com> ---
Taking for review.
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"GPL", "LGPL (v2.1 or later) (with incorrect FSF address)", "GPL (v2 or
later)", "Unknown or generated", "LGPL (v2 or later) (with incorrect FSF
address)", "zlib/libpng", "GPL (unversioned/unknown version) GPL". 78
files have unknown license. Detailed output of licensecheck in
/media/michael/Temp/backup/Projects/fedora/review/904634-mingw-
sword/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/x86_64-w64-mingw32/sys-
root/mingw/share/sword, /usr/i686-w64-mingw32/sys-root/mingw/share/sword
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/i686-w64-mingw32/sys-
root/mingw/share/sword, /usr/x86_64-w64-mingw32/sys-
root/mingw/share/sword
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[-]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 163840 bytes in 8 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[x]: Uses parallel make %{?_smp_mflags} macro.
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
mingw32-sword , mingw64-sword
[x]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: The placement of pkgconfig(.pc) files are correct.
Note: mingw32-sword : /usr/i686-w64-mingw32/sys-
root/mingw/lib/pkgconfig/sword.pc mingw64-sword : /usr/x86_64-w64-mingw32
/sys-root/mingw/lib/pkgconfig/sword.pc
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: No rpmlint messages.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: mingw32-sword-1.7.3-2.fc20.noarch.rpm
mingw64-sword-1.7.3-2.fc20.noarch.rpm
mingw-sword-1.7.3-2.fc20.src.rpm
mingw-sword.src:23: W: mixed-use-of-spaces-and-tabs (spaces: line 23, tab: line
5)
3 packages and 0 specfiles checked; 0 errors, 1 warnings.
Rpmlint (installed packages)
----------------------------
]0;<mock-chroot><mock-chroot>[root@melchior /]# rpmlint mingw32-sword
mingw64-sword
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
]0;<mock-chroot><mock-chroot>[root@melchior /]# echo 'rpmlint-done:'
Requires
--------
mingw32-sword (rpmlib, GLIBC filtered):
mingw32(icui18n50.dll)
mingw32(icuuc50.dll)
mingw32(kernel32.dll)
mingw32(libclucene-core.dll)
mingw32(libcurl-4.dll)
mingw32(libgcc_s_sjlj-1.dll)
mingw32(libglib-2.0-0.dll)
mingw32(libgnurx-0.dll)
mingw32(libstdc++-6.dll)
mingw32(libsword.dll)
mingw32(msvcrt.dll)
mingw32(zlib1.dll)
mingw32-crt
mingw32-filesystem
mingw32-pkg-config
mingw64-sword (rpmlib, GLIBC filtered):
mingw64(icui18n50.dll)
mingw64(icuuc50.dll)
mingw64(kernel32.dll)
mingw64(libclucene-core.dll)
mingw64(libcurl-4.dll)
mingw64(libgcc_s_seh-1.dll)
mingw64(libglib-2.0-0.dll)
mingw64(libgnurx-0.dll)
mingw64(libstdc++-6.dll)
mingw64(libsword.dll)
mingw64(msvcrt.dll)
mingw64(zlib1.dll)
mingw64-crt
mingw64-filesystem
mingw64-pkg-config
Provides
--------
mingw32-sword:
mingw32(libsword.dll)
mingw32-sword
mingw64-sword:
mingw64(libsword.dll)
mingw64-sword
Source checksums
----------------
http://crosswire.org/ftpmirror/pub/sword/source/v1.7/sword-1.7.3.tar.gz :
CHECKSUM(SHA256) this package :
5a3d87ff155d5ecb0cfec052ba333b2b74d9273e2cc66fb1ca75747dfd8ea9ea
CHECKSUM(SHA256) upstream package :
5a3d87ff155d5ecb0cfec052ba333b2b74d9273e2cc66fb1ca75747dfd8ea9ea
Issues
------
- Version 1.7.4 is now out. Could you update to this first?
- Package does not own %{mingw32/64_datadir}/sword/, does anything else? If
not, you can drop "locales.d" off the end.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SLoDhu6J5G&a=cc_unsubscribe
9 years, 2 months
Some broad questions about the project from a semi-newbie....
by jrm
Please forgive me if some of this is a little basic. What I'm
considering is bringing the tool chain into use in a commercial
setting. I need to do everything I can to confirm that it can work for
us before investing much time.
Over ten years ago we worked with mingw to cross compile for windows
from linux. At that time, we concluded we couldn't use it because it
could only link "C" DLLs built by Visual Studio tools (when source
recompilation wasn't an option). We also expected that we would need
to link with "C++" libraries for which we didn't have source.
Since then, we have learned that we have limited need for an ability to
link third party "C++" libraries built from visual studio. It also
appears that the current tool chain can handle "C" linkage to Visual
Studio generated ".obj" and static ".lib" - not just DLL.
I would appreciate confirmation of the following:
* The project provides the full GNU tool chain for C++
* Debugging on windows is possible via windows compiled version of gdb
* The tool chain can link against static "C" libraries or DLLs created
by Visual C++ (.obj, .lib and .lib/DLL)
* The tool chain CAN NOT link against C++ libraries or DLLs created by
Visual C++ (differences in C++ infrastructure, ABI, etc.)
* Well behaved and recent builds of QT 4.x exist and are regularly used.
* Executables and/or DLLs created with this tool chain the same
licensing implications as objects created for linux on linux.
* There are no objects /automatically/ contributed to linked results
that would require a company to open their source code base.
Presuming all of the above to be true, I would appreciate a
recommendation on the best stable point to start, where I can get a
complete tool chain and supporting libraries including QT 4.
My thanks and regards to everyone working on this project.
-jrm
9 years, 2 months
[Bug 1092759] New: gzseek calls can incorrectly position the file.
by Red Hat Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1092759
Bug ID: 1092759
Summary: gzseek calls can incorrectly position the file.
Product: Fedora
Version: 19
Component: mingw-zlib
Assignee: rjones(a)redhat.com
Reporter: tsteven4(a)gmail.com
QA Contact: extras-qa(a)fedoraproject.org
CC: erik-fedora(a)vanpienbroek.nl,
fedora-mingw(a)lists.fedoraproject.org,
lfarkas(a)lfarkas.org, rjones(a)redhat.com,
t.sailer(a)alumni.ethz.ch
Created attachment 890969
--> https://bugzilla.redhat.com/attachment.cgi?id=890969&action=edit
zlib gzseek test case
Description of problem: gzseek can incorrectly hit EOF, causing subsequent
gzread calls to fail.
Version-Release number of selected component (if applicable):
mingw32-zlib-1.2.7-2.fc19.noarch
How reproducible:
100%
Steps to Reproduce:
1. unzip test case zlib_test2.zip provided.
2. run test2 script to compile the test case.
3. execute test case by running testz2.exe under windows. testz2.exe,
zlib1.dll and test.data all need to be in the directory testz2.exe is executed
from.
Actual results:
Got 0
Expected results:
Got 4
Additional info:
A possible patch with zlib 1.2.8 is listed below, although this might be a
configuration problem. offset, which is of type z_off64_t, ends up being 32
bits as configured.
--- gzlib.c 2013-03-24 23:47:59.000000000 -0600
+++ gzlib.patch.c 2014-04-27 15:34:38.496808069 -0600
@@ -393,7 +393,7 @@
/* if within raw area while reading, just go there */
if (state->mode == GZ_READ && state->how == COPY &&
state->x.pos + offset >= 0) {
- ret = LSEEK(state->fd, offset - state->x.have, SEEK_CUR);
+ ret = LSEEK(state->fd, offset - (z_off64_t)state->x.have, SEEK_CUR);
if (ret == -1)
return -1;
state->x.have = 0;
I have reported this to zlib(a)gzip.org but haven't received any response yet.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=t37ShhxD8T&a=cc_unsubscribe
9 years, 2 months