Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=497492
Erik van Pienbroek <erik-fedora(a)vanpienbroek.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |erik-fedora(a)vanpienbroek.nl
--- Comment #7 from Erik van Pienbroek <erik-fedora(a)vanpienbroek.nl> 2009-08-22
11:21:55 EDT ---
Recently a new version of libjpeg was released (
http://www.ijg.org/). Some code
was added by upstream to circumvent the bug described here. However, this
change was incomplete and contains a typo..so basically we're still stuck with
the same problem.
Now there are multiple solutions to 'fix' this bug once and for all:
Solution 1:
-----------
Prevent the conflict by having jmorecfg.h contain 'typedef unsigned char
boolean;'
+ No conflict anymore when using #include <rpcndr.h>
- The API of the libjpeg-7.dll will be different than what it is now
- All dependent packages need to be rebuild (libtiff, libjasper and gtk2)
Solution 2:
-----------
Don't use 'typedef int boolean;' when the file rpcndr.h is already included
+ No rebuild required for dependent packages (libtiff, libjasper and gtk2)
- This introduces side-effects when one source code file #include's rpcndr.h
and another one doesn't
Solution 3:
-----------
Don't use a datatype named 'boolean', but something different like
'jpeg_boolean'
+ No conflicts anymore whether or not the file rpcndr.h is #include'd
+ Lower risk of side effects (the only risk which remains is the situation
where a library or application #include's rpcndr.h and uses the 'boolean'
datatype, but for those situations the compiler should give a warning anyway)
+ The API of the libjpeg-7.dll remains the same (the size of all the data
structures remain the same)
- May require patching of libraries/applications which use libjpeg
My vote goes to the third solution. That solution is also one which 'could' be
proposed upstream (be it for a future major version of libjpeg as it may
require changes in libraries or applications using libjpeg).
Patches are attached
--
Configure bugmail:
https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.