https://bugzilla.redhat.com/show_bug.cgi?id=858085
Bug ID: 858085 QA Contact: extras-qa@fedoraproject.org Severity: unspecified Version: rawhide Priority: unspecified CC: fedora-mingw@lists.fedoraproject.org, notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: mingw-qt5-qtxmlpatterns - Qt5 for Windows - QtXmlPatterns component Regression: --- Story Points: --- Classification: Fedora OS: Unspecified Reporter: erik-fedora@vanpienbroek.nl Type: Bug Documentation: --- Hardware: Unspecified Mount Type: --- Status: NEW Component: Package Review Product: Fedora
Spec URL: http://svn.openftd.org/svn/fedora_cross/mingw-qt5-qtxmlpatterns/mingw-qt5-qt... SRPM URL: http://ftd4linux.nl/contrib/mingw-qt5-qtxmlpatterns-5.0.0-0.1.beta1.fc17.src... Fedora Account System Username: epienbro Description: This package contains the Qt software toolkit for developing cross-platform applications.
This is the Windows version of Qt, for use in conjunction with the Fedora Windows cross-compiler.
https://bugzilla.redhat.com/show_bug.cgi?id=858085
Erik van Pienbroek erik-fedora@vanpienbroek.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |858058
https://bugzilla.redhat.com/show_bug.cgi?id=858085
--- Comment #1 from Erik van Pienbroek erik-fedora@vanpienbroek.nl --- Updated Spec URL: http://svn.openftd.org/svn/fedora_cross/mingw-qt5-qtxmlpatterns/mingw-qt5-qt... Updated SRPM URL: http://build1.openftd.org/fedora-cross/src/mingw-qt5-qtxmlpatterns-5.0.0-0.2...
* Mon Nov 12 2012 Erik van Pienbroek epienbro@fedoraproject.org - 5.0.0-0.2.beta1.git20121112.69b7a0bb - Update to 20121112 snapshot (rev 69b7a0bb) - Rebuild against latest mingw-qt5-qtbase - Dropped pkg-config rename hack as it's unneeded now
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858085
Bug 858085 depends on bug 858058, which changed state.
Bug 858058 Summary: Review Request: mingw-qt5-qtbase - Qt5 for Windows - QtBase component https://bugzilla.redhat.com/show_bug.cgi?id=858058
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858085
--- Comment #2 from Erik van Pienbroek erik-fedora@vanpienbroek.nl --- Updated Spec URL: http://svn.openftd.org/svn/fedora_cross/mingw-qt5-qtxmlpatterns/mingw-qt5-qt... Updated SRPM URL: http://koji.vanpienbroek.nl/kojifiles/packages/mingw-qt5-qtxmlpatterns/5.0.1... Koji scratch build: http://koji.vanpienbroek.nl/koji/buildinfo?buildID=123
* Sat Feb 09 2013 Erik van Pienbroek epienbro@fedoraproject.org - 5.0.1-1 - Update to 5.0.1
* Fri Jan 11 2013 Erik van Pienbroek epienbro@fedoraproject.org - 5.0.0-1 - Update to Qt 5.0.0 Final
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858085
--- Comment #3 from Erik van Pienbroek erik-fedora@vanpienbroek.nl --- Updated Spec URL: http://svn.nntpgrab.nl/svn/fedora_cross/mingw-qt5-qtxmlpatterns/mingw-qt5-qt... Updated SRPM URL: http://koji.vanpienbroek.nl/kojifiles/packages/mingw-qt5-qtxmlpatterns/5.0.2... Koji scratch build: http://koji.vanpienbroek.nl/koji/buildinfo?buildID=145
* Fri May 10 2013 Erik van Pienbroek epienbro@fedoraproject.org - 5.0.2-1 - Update to 5.0.2
https://bugzilla.redhat.com/show_bug.cgi?id=858085
--- Comment #4 from Erik van Pienbroek erik-fedora@vanpienbroek.nl --- Updated Spec URL: http://svn.nntpgrab.nl/svn/fedora_cross/mingw-qt5-qtxmlpatterns/mingw-qt5-qt... Updated SRPM URL: http://koji.vanpienbroek.nl/kojifiles/packages/mingw-qt5-qtxmlpatterns/5.1.0... Koji scratch build: http://koji.vanpienbroek.nl/koji/buildinfo?buildID=156
* Sun Jul 14 2013 Erik van Pienbroek epienbro@fedoraproject.org - 5.1.0-1 - Update to 5.1.0
https://bugzilla.redhat.com/show_bug.cgi?id=858085
--- Comment #5 from Erik van Pienbroek erik-fedora@vanpienbroek.nl --- Updated Spec URL: http://svn.nntpgrab.nl/svn/fedora_cross/mingw-qt5-qtxmlpatterns/mingw-qt5-qt... Updated SRPM URL: http://koji.vanpienbroek.nl/kojifiles/packages/mingw-qt5-qtxmlpatterns/5.2.0... Koji scratch build: http://koji.vanpienbroek.nl/koji/buildinfo?buildID=181
* Fri Nov 29 2013 Erik van Pienbroek epienbro@fedoraproject.org - 5.2.0-0.1.rc1 - Update to 5.2.0 RC1
https://bugzilla.redhat.com/show_bug.cgi?id=858085
--- Comment #6 from Erik van Pienbroek erik-fedora@vanpienbroek.nl --- Updated Spec URL: http://svn.nntpgrab.nl/svn/fedora_cross/mingw-qt5-qtxmlpatterns/mingw-qt5-qt... Updated SRPM URL: http://koji.vanpienbroek.nl/kojifiles/packages/mingw-qt5-qtxmlpatterns/5.2.0... Koji scratch build: http://koji.vanpienbroek.nl/koji/buildinfo?buildID=185
* Sun Jan 05 2014 Erik van Pienbroek epienbro@fedoraproject.org - 5.2.0-1 - Update to 5.2.0 - Dropped manual rename of import libraries - Added license files
https://bugzilla.redhat.com/show_bug.cgi?id=858085
--- Comment #7 from Erik van Pienbroek erik-fedora@vanpienbroek.nl --- Updated Spec URL: http://svn.nntpgrab.nl/svn/fedora_cross/mingw-qt5-qtxmlpatterns/mingw-qt5-qt... Updated SRPM URL: http://koji.vanpienbroek.nl/kojifiles/packages/mingw-qt5-qtxmlpatterns/5.3.0... Koji scratch build: http://koji.vanpienbroek.nl/koji/buildinfo?buildID=214
* Sun May 25 2014 Erik van Pienbroek epienbro@fedoraproject.org - 5.3.0-1 - Update to 5.3.0
https://bugzilla.redhat.com/show_bug.cgi?id=858085
--- Comment #8 from Erik van Pienbroek erik-fedora@vanpienbroek.nl --- Updated Spec URL: http://svn.nntpgrab.nl/svn/fedora_cross/mingw-qt5-qtxmlpatterns/mingw-qt5-qt... Updated SRPM URL: http://koji.vanpienbroek.nl/kojifiles/packages/mingw-qt5-qtxmlpatterns/5.4.1... Koji scratch build: http://koji.vanpienbroek.nl/koji/buildinfo?buildID=259
* Tue Mar 24 2015 Erik van Pienbroek epienbro@fedoraproject.org - 5.4.1-1 - Update to 5.4.1
https://bugzilla.redhat.com/show_bug.cgi?id=858085
Kalev Lember kalevlember@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |kalevlember@gmail.com Assignee|nobody@fedoraproject.org |kalevlember@gmail.com Flags| |fedora-review+
--- Comment #9 from Kalev Lember kalevlember@gmail.com --- Fedora review mingw-qt5-qtxmlpatterns-5.4.1-1.fc23.src.rpm 2015-03-25
$ rpmlint mingw-qt5-qtxmlpatterns-5.4.1-1.fc22.src.rpm \ mingw32-qt5-qtxmlpatterns-5.4.1-1.fc22.noarch.rpm \ mingw64-qt5-qtxmlpatterns-5.4.1-1.fc22.noarch.rpm \ mingw32-qt5-qtxmlpatterns-debuginfo-5.4.1-1.fc22.noarch.rpm \ mingw64-qt5-qtxmlpatterns-debuginfo-5.4.1-1.fc22.noarch.rpm mingw-qt5-qtxmlpatterns.src:29: W: macro-in-comment %{qt_module} mingw-qt5-qtxmlpatterns.src:29: W: macro-in-comment %{snapshot_rev} mingw-qt5-qtxmlpatterns.src:29: W: macro-in-comment %{qt_module} mingw-qt5-qtxmlpatterns.src:29: W: macro-in-comment %{snapshot_rev} mingw32-qt5-qtxmlpatterns-debuginfo.noarch: E: debuginfo-without-sources mingw64-qt5-qtxmlpatterns-debuginfo.noarch: E: debuginfo-without-sources 5 packages and 0 specfiles checked; 2 errors, 4 warnings.
+ OK ! needs attention
+ rpmlint warnings are harmless and can be ignored + The package is named according to Fedora MinGW packaging guidelines + The spec file name matches the base package name. + The package meets the Packaging Guidelines + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The license field in the spec file matches the actual license + The stated license for the mingw package is the same as the one for the corresponding native Fedora package ! The license text is included in %license
Can you use %license instead of %doc for the license files, please?
+ Spec file is written in American English + Spec file is legible + Upstream sources match the sources in the srpm ec2970e9e9c38f88be74f18101937c28 qtxmlpatterns-opensource-src-5.4.1.tar.xz ec2970e9e9c38f88be74f18101937c28 Download/qtxmlpatterns-opensource-src-5.4.1.tar.xz + The package builds in koji n/a ExcludeArch bugs filed + BuildRequires look sane n/a locale handling n/a ldconfig in %post and %postun + Package does not bundle copies of system libraries n/a Package isn't relocatable + Package owns all the directories it creates + No duplicate files in %files + Permissions are properly set + Consistent use of macros + The package must contain code or permissible content n/a Large documentation files should go in -doc subpackage + Files marked %doc should not affect the runtime of application n/a Static libraries should be in -static n/a Development files should be in -devel Not applicable to MinGW packages. n/a -devel must require the fully versioned base + Packages should not contain libtool .la files n/a Proper .desktop file handling + Doesn't own files or directories already owned by other packages + Filenames are valid UTF-8
Looks good to me, just a minor problem with the %license vs %doc macros -- the guidelines were recently updated to require the %license macro for license files. Please fix this before importing.
APPROVED
https://bugzilla.redhat.com/show_bug.cgi?id=858085
Erik van Pienbroek erik-fedora@vanpienbroek.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #10 from Erik van Pienbroek erik-fedora@vanpienbroek.nl --- Thanks for the review!
New Package SCM Request ======================= Package Name: mingw-qt5-qtxmlpatterns Short Description: Qt5 for Windows - QtXmlPatterns component Upstream URL: http://www.qt.io/ Owners: epienbro Branches: f20 f21 f22 epel7 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=858085
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=858085
--- Comment #11 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=858085
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=858085
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- mingw-qt5-qtwebsockets-5.4.1-1.fc22,mingw-qt5-qtxmlpatterns-5.4.1-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/mingw-qt5-qtwebsockets-5.4.1-1.fc22,...
https://bugzilla.redhat.com/show_bug.cgi?id=858085
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- mingw-qt5-qtwebsockets-5.4.1-1.fc21,mingw-qt5-qtxmlpatterns-5.4.1-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/mingw-qt5-qtwebsockets-5.4.1-1.fc21,...
https://bugzilla.redhat.com/show_bug.cgi?id=858085
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- mingw-qt5-qtwebsockets-5.4.1-1.fc20,mingw-qt5-qtxmlpatterns-5.4.1-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/mingw-qt5-qtwebsockets-5.4.1-1.fc20,...
https://bugzilla.redhat.com/show_bug.cgi?id=858085
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- mingw-qt5-qtwebsockets-5.4.1-1.el7,mingw-qt5-qtxmlpatterns-5.4.1-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/mingw-qt5-qtwebsockets-5.4.1-1.el7,m...
https://bugzilla.redhat.com/show_bug.cgi?id=858085
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- mingw-qt5-qtwebsockets-5.4.1-1.el7, mingw-qt5-qtxmlpatterns-5.4.1-1.el7 has been pushed to the Fedora EPEL 7 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=858085
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |mingw-qt5-qtwebsockets-5.4. | |1-1.fc22 Resolution|--- |ERRATA Last Closed| |2015-03-31 17:48:47
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- mingw-qt5-qtwebsockets-5.4.1-1.fc22, mingw-qt5-qtxmlpatterns-5.4.1-1.fc22 has been pushed to the Fedora 22 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=858085
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|mingw-qt5-qtwebsockets-5.4. |mingw-qt5-qtwebsockets-5.4. |1-1.fc22 |1-1.fc21
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- mingw-qt5-qtwebsockets-5.4.1-1.fc21, mingw-qt5-qtxmlpatterns-5.4.1-1.fc21 has been pushed to the Fedora 21 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=858085
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|mingw-qt5-qtwebsockets-5.4. |mingw-qt5-qtwebsockets-5.4. |1-1.fc21 |1-1.fc20
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- mingw-qt5-qtwebsockets-5.4.1-1.fc20, mingw-qt5-qtxmlpatterns-5.4.1-1.fc20 has been pushed to the Fedora 20 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=858085
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|mingw-qt5-qtwebsockets-5.4. |mingw-qt5-qtwebsockets-5.4. |1-1.fc20 |1-1.el7
--- Comment #20 from Fedora Update System updates@fedoraproject.org --- mingw-qt5-qtwebsockets-5.4.1-1.el7, mingw-qt5-qtxmlpatterns-5.4.1-1.el7 has been pushed to the Fedora EPEL 7 stable repository.