8:09 a.m.
hi,
as i previously send it (i just update it and resend) i agree with dan's
comment so i remove params from mingw32_make.
devel branch is enough for this.
--
Levente "Si vis pacem para bellum!"
Index: mingw32-filesystem.spec
===================================================================
RCS file: /cvs/pkgs/rpms/mingw32-filesystem/devel/mingw32-filesystem.spec,v
retrieving revision 1.12
diff -u -r1.12 mingw32-filesystem.spec
--- mingw32-filesystem.spec 26 Jan 2009 17:21:27 -0000 1.12
+++ mingw32-filesystem.spec 28 Jan 2009 14:02:09 -0000
@@ -1,7 +1,7 @@
%define debug_package %{nil}
Name: mingw32-filesystem
-Version: 44
+Version: 45
Release: 1%{?dist}
Summary: MinGW base filesystem and environment
@@ -153,6 +153,9 @@
%changelog
+* Wed Dec 29 2008 Levente Farkas <lfarkas(a)lfarkas.org> - 45-1
+- Remove parameters from mingw32-make
+
* Mon Jan 26 2009 Richard W.M. Jones <rjones(a)redhat.com> - 44-1
- Install rpmlint overrides file to suppress some rpmlint warnings.
Index: mingw32-macros.mingw32
===================================================================
RCS file: /cvs/pkgs/rpms/mingw32-filesystem/devel/mingw32-macros.mingw32,v
retrieving revision 1.7
diff -u -r1.7 mingw32-macros.mingw32
--- mingw32-macros.mingw32 24 Jan 2009 18:11:43 -0000 1.7
+++ mingw32-macros.mingw32 28 Jan 2009 14:02:09 -0000
@@ -97,22 +97,6 @@
--mandir=%{_mingw32_mandir} \\\
--infodir=%{_mingw32_infodir}
-%_mingw32_make %{_mingw32_env} ; \
- make \\\
- prefix=%{_mingw32_prefix} \\\
- exec_prefix=%{_mingw32_exec_prefix} \\\
- bindir=%{_mingw32_bindir} \\\
- sbindir=%{_mingw32_sbindir} \\\
- sysconfdir=%{_mingw32_sysconfdir} \\\
- datadir=%{_mingw32_datadir} \\\
- includedir=%{_mingw32_includedir} \\\
- libdir=%{_mingw32_libdir} \\\
- libexecdir=%{_mingw32_libexecdir} \\\
- localstatedir=%{_mingw32_localstatedir} \\\
- sharedstatedir=%{_mingw32_sharedstatedir} \\\
- mandir=%{_mingw32_mandir} \\\
- infodir=%{_mingw32_infodir}
-
%_mingw32_makeinstall %{_mingw32_env} ; \
make \\\
prefix=%{?buildroot:%{buildroot}}%{_mingw32_prefix} \\\
@@ -130,3 +114,4 @@
infodir=%{?buildroot:%{buildroot}}%{_mingw32_infodir} \\\
install
+%_mingw32_make %{_mingw32_env} ; make
10:53 a.m.
On Wed, Jan 28, 2009 at 03:09:22PM +0100, Farkas Levente wrote:
hi,
as i previously send it (i just update it and resend) i agree with dan's
comment so i remove params from mingw32_make.
devel branch is enough for this.
ACK.
Rich.
--
Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine. Supports Linux and Windows.
http://et.redhat.com/~rjones/virt-df/
10:54 a.m.
On Wed, Jan 28, 2009 at 04:53:40PM +0000, Richard W.M. Jones wrote:
On Wed, Jan 28, 2009 at 03:09:22PM +0100, Farkas Levente wrote:
> hi,
> as i previously send it (i just update it and resend) i agree with dan's
> comment so i remove params from mingw32_make.
> devel branch is enough for this.
ACK.
Although I'm still questioning why we need _mingw32_make at all ...
Rich.
--
Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones
virt-top is 'top' for virtual machines. Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://et.redhat.com/~rjones/virt-top
2:09 p.m.
Richard W.M. Jones wrote:
On Wed, Jan 28, 2009 at 04:53:40PM +0000, Richard W.M. Jones wrote:
> On Wed, Jan 28, 2009 at 03:09:22PM +0100, Farkas Levente wrote:
>> hi,
>> as i previously send it (i just update it and resend) i agree with dan's
>> comment so i remove params from mingw32_make.
>> devel branch is enough for this.
> ACK.
Although I'm still questioning why we need _mingw32_make at all ...
to be able to use the same source (ie. mingw32-macros.mingw32) and have
to edit it one place, for all helper scripts (ie. mingw32-configure
mingw32-make).
--
Levente "Si vis pacem para bellum!"
4:53 p.m.
On Wed, Jan 28, 2009 at 09:09:16PM +0100, Farkas Levente wrote:
Richard W.M. Jones wrote:
> On Wed, Jan 28, 2009 at 04:53:40PM +0000, Richard W.M. Jones wrote:
>> On Wed, Jan 28, 2009 at 03:09:22PM +0100, Farkas Levente wrote:
>>> hi,
>>> as i previously send it (i just update it and resend) i agree with
dan's
>>> comment so i remove params from mingw32_make.
>>> devel branch is enough for this.
>> ACK.
>
> Although I'm still questioning why we need _mingw32_make at all ...
to be able to use the same source (ie. mingw32-macros.mingw32) and have
to edit it one place, for all helper scripts (ie. mingw32-configure
mingw32-make).
No, no, I mean why do we need a make macro or script at all?
The GNU coding standards define that this will work in all circumstances:
./configure --lots-of-options
make
where options on the ./configure command line are turned into defaults
for make.
Rich.
--
Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones
virt-p2v converts physical machines to virtual machines. Boot with a
live CD or over the network (PXE) and turn machines into Xen guests.
http://et.redhat.com/~rjones/virt-p2v
5:04 p.m.
Richard W.M. Jones wrote:
On Wed, Jan 28, 2009 at 09:09:16PM +0100, Farkas Levente wrote:
> Richard W.M. Jones wrote:
>> On Wed, Jan 28, 2009 at 04:53:40PM +0000, Richard W.M. Jones wrote:
>>> On Wed, Jan 28, 2009 at 03:09:22PM +0100, Farkas Levente wrote:
>>>> hi,
>>>> as i previously send it (i just update it and resend) i agree with
dan's
>>>> comment so i remove params from mingw32_make.
>>>> devel branch is enough for this.
>>> ACK.
>> Although I'm still questioning why we need _mingw32_make at all ...
> to be able to use the same source (ie. mingw32-macros.mingw32) and have
> to edit it one place, for all helper scripts (ie. mingw32-configure
> mingw32-make).
No, no, I mean why do we need a make macro or script at all?
The GNU coding standards define that this will work in all circumstances:
./configure --lots-of-options
make
where options on the ./configure command line are turned into defaults
for make.
suppose you make some cross compilation development. everywhere you put
%{_mingw32_make} into the spec file but wouldn't like to always run it
through rpmbuild you can use mingw32-make in the working directory.
--
Levente "Si vis pacem para bellum!"
5:19 p.m.
On Thu, Jan 29, 2009 at 12:04:53AM +0100, Farkas Levente wrote:
Richard W.M. Jones wrote:
> On Wed, Jan 28, 2009 at 09:09:16PM +0100, Farkas Levente wrote:
>> Richard W.M. Jones wrote:
>>> On Wed, Jan 28, 2009 at 04:53:40PM +0000, Richard W.M. Jones wrote:
>>>> On Wed, Jan 28, 2009 at 03:09:22PM +0100, Farkas Levente wrote:
>>>>> hi,
>>>>> as i previously send it (i just update it and resend) i agree with
dan's
>>>>> comment so i remove params from mingw32_make.
>>>>> devel branch is enough for this.
>>>> ACK.
>>> Although I'm still questioning why we need _mingw32_make at all ...
>> to be able to use the same source (ie. mingw32-macros.mingw32) and have
>> to edit it one place, for all helper scripts (ie. mingw32-configure
>> mingw32-make).
>
> No, no, I mean why do we need a make macro or script at all?
>
> The GNU coding standards define that this will work in all circumstances:
>
> ./configure --lots-of-options
> make
>
> where options on the ./configure command line are turned into defaults
> for make.
suppose you make some cross compilation development. everywhere you put
%{_mingw32_make} into the spec file but wouldn't like to always run it
through rpmbuild you can use mingw32-make in the working directory.
No, I don't mean this. Why don't we remove both the _mingw32_make
macro and the mingw32-make script? Any usage of this macro/script
would be replaced by a simple 'make' command.
Rich.
--
Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones
virt-p2v converts physical machines to virtual machines. Boot with a
live CD or over the network (PXE) and turn machines into Xen guests.
http://et.redhat.com/~rjones/virt-p2v
5:47 p.m.
Richard W.M. Jones wrote:
On Thu, Jan 29, 2009 at 12:04:53AM +0100, Farkas Levente wrote:
> Richard W.M. Jones wrote:
>> On Wed, Jan 28, 2009 at 09:09:16PM +0100, Farkas Levente wrote:
>>> Richard W.M. Jones wrote:
>>>> On Wed, Jan 28, 2009 at 04:53:40PM +0000, Richard W.M. Jones wrote:
>>>>> On Wed, Jan 28, 2009 at 03:09:22PM +0100, Farkas Levente wrote:
>>>>>> hi,
>>>>>> as i previously send it (i just update it and resend) i agree
with dan's
>>>>>> comment so i remove params from mingw32_make.
>>>>>> devel branch is enough for this.
>>>>> ACK.
>>>> Although I'm still questioning why we need _mingw32_make at all ...
>>> to be able to use the same source (ie. mingw32-macros.mingw32) and have
>>> to edit it one place, for all helper scripts (ie. mingw32-configure
>>> mingw32-make).
>> No, no, I mean why do we need a make macro or script at all?
>>
>> The GNU coding standards define that this will work in all circumstances:
>>
>> ./configure --lots-of-options
>> make
>>
>> where options on the ./configure command line are turned into defaults
>> for make.
> suppose you make some cross compilation development. everywhere you put
> %{_mingw32_make} into the spec file but wouldn't like to always run it
> through rpmbuild you can use mingw32-make in the working directory.
No, I don't mean this. Why don't we remove both the _mingw32_make
macro and the mingw32-make script? Any usage of this macro/script
would be replaced by a simple 'make' command.
not all projects use gnu toolchain:-(
--
Levente "Si vis pacem para bellum!"
5:52 p.m.
On Thu, Jan 29, 2009 at 12:47:00AM +0100, Farkas Levente wrote:
not all projects use gnu toolchain:-(
But this is what I'm getting at -- what project needs this? Nothing
of any significance out of the packages we've built so far. I mean, a
handful need specific make parameters, but those are handled ad hoc.
Rich.
--
Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones
virt-top is 'top' for virtual machines. Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://et.redhat.com/~rjones/virt-top
5566
days inactive
5566
days old
8 comments
2 participants
participants (2)
-
Farkas Levente -
Richard W.M. Jones