https://bugzilla.redhat.com/show_bug.cgi?id=858074
Bug ID: 858074 QA Contact: extras-qa@fedoraproject.org Severity: unspecified Version: rawhide Priority: unspecified CC: fedora-mingw@lists.fedoraproject.org, notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: mingw-qt5-qtquick1 - Qt5 for Windows - QtQuick1 component Regression: --- Story Points: --- Classification: Fedora OS: Unspecified Reporter: erik-fedora@vanpienbroek.nl Type: Bug Documentation: --- Hardware: Unspecified Mount Type: --- Status: NEW Component: Package Review Product: Fedora
Spec URL: http://svn.openftd.org/svn/fedora_cross/mingw-qt5-qtquick1/mingw-qt5-qtquick... SRPM URL: http://ftd4linux.nl/contrib/mingw-qt5-qtquick1-5.0.0-0.1.beta1.fc17.src.rpm Fedora Account System Username: epienbro Description: This package contains the Qt software toolkit for developing cross-platform applications.
This is the Windows version of Qt, for use in conjunction with the Fedora Windows cross-compiler.
https://bugzilla.redhat.com/show_bug.cgi?id=858074
Erik van Pienbroek erik-fedora@vanpienbroek.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |858061
https://bugzilla.redhat.com/show_bug.cgi?id=858074
Erik van Pienbroek erik-fedora@vanpienbroek.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |858063
https://bugzilla.redhat.com/show_bug.cgi?id=858074
Erik van Pienbroek erik-fedora@vanpienbroek.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |858058, 858076
https://bugzilla.redhat.com/show_bug.cgi?id=858074
--- Comment #1 from Erik van Pienbroek erik-fedora@vanpienbroek.nl --- Updated Spec URL: http://svn.openftd.org/svn/fedora_cross/mingw-qt5-qtquick1/mingw-qt5-qtquick... Updated SRPM URL: http://build1.openftd.org/fedora-cross/src/mingw-qt5-qtquick1-5.0.0-0.2.beta...
* Sun Nov 11 2012 Erik van Pienbroek epienbro@fedoraproject.org - 5.0.0-0.2.beta1.git20121111.a14ab84c - Update to 20121111 snapshot (rev a14ab84c) - Rebuild against latest mingw-qt5-qtbase - Dropped pkg-config rename hack as it's unneeded now
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858074
Bug 858074 depends on bug 858058, which changed state.
Bug 858058 Summary: Review Request: mingw-qt5-qtbase - Qt5 for Windows - QtBase component https://bugzilla.redhat.com/show_bug.cgi?id=858058
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858074
--- Comment #2 from Erik van Pienbroek erik-fedora@vanpienbroek.nl --- Updated Spec URL: http://svn.openftd.org/svn/fedora_cross/mingw-qt5-qtquick1/mingw-qt5-qtquick... Updated SRPM URL: http://koji.vanpienbroek.nl/kojifiles/packages/mingw-qt5-qtquick1/5.0.1/1.fc... Koji scratch build: http://koji.vanpienbroek.nl/koji/buildinfo?buildID=124
* Sat Feb 09 2013 Erik van Pienbroek epienbro@fedoraproject.org - 5.0.1-1 - Update to 5.0.1
* Fri Jan 11 2013 Erik van Pienbroek epienbro@fedoraproject.org - 5.0.0-1 - Update to Qt 5.0.0 Final
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858074
Bug 858074 depends on bug 858076, which changed state.
Bug 858076 Summary: Review Request: mingw-qt5-qtscript - Qt5 for Windows - QtScript component https://bugzilla.redhat.com/show_bug.cgi?id=858076
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858074
greg.hellings@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |greg.hellings@gmail.com Assignee|nobody@fedoraproject.org |greg.hellings@gmail.com Flags| |fedora-review?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858074
greg.hellings@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+
--- Comment #3 from greg.hellings@gmail.com --- Your Spec file URL above doesn't work for me, so I just went off the one in the .src.rpm file
$ rpmlint mingw-qt5-qtquick1.spec mingw-qt5-qtquick1.spec:26: W: macro-in-comment %{qt_module} mingw-qt5-qtquick1.spec:26: W: macro-in-comment %{snapshot_rev} mingw-qt5-qtquick1.spec:26: W: macro-in-comment %{qt_module} mingw-qt5-qtquick1.spec:26: W: macro-in-comment %{snapshot_rev} 0 packages and 1 specfiles checked; 0 errors, 4 warnings.
$ rpmlint mingw-qt5-qtquick1-5.0.1-1.fc19.src.rpm mingw-qt5-qtquick1.src: E: unknown-key GPG#9b393ae8 mingw-qt5-qtquick1.src:26: W: macro-in-comment %{qt_module} mingw-qt5-qtquick1.src:26: W: macro-in-comment %{snapshot_rev} mingw-qt5-qtquick1.src:26: W: macro-in-comment %{qt_module} mingw-qt5-qtquick1.src:26: W: macro-in-comment %{snapshot_rev} 1 packages and 0 specfiles checked; 1 errors, 4 warnings.
$ rpmlint results_mingw-qt5-qtquick1/5.0.1/1.fc18/mingw{32,64}* mingw32-qt5-qtquick1.noarch: W: no-documentation mingw32-qt5-qtquick1-debuginfo.noarch: E: debuginfo-without-sources mingw64-qt5-qtquick1.noarch: W: no-documentation mingw64-qt5-qtquick1-debuginfo.noarch: E: debuginfo-without-sources 4 packages and 0 specfiles checked; 2 errors, 2 warnings.
$ rpm -q --requires mingw32-qt5-qtquick1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 mingw32-crt mingw32-filesystem >= 83 mingw32(kernel32.dll) mingw32(libgcc_s_sjlj-1.dll) mingw32(libglesv2.dll) mingw32(libstdc++-6.dll) mingw32(msvcrt.dll) mingw32(qt5core.dll) mingw32(qt5declarative.dll) mingw32(qt5gui.dll) mingw32(qt5network.dll) mingw32(qt5opengl.dll) mingw32(qt5script.dll) mingw32(qt5sql.dll) mingw32(qt5widgets.dll) rpmlib(PayloadIsXz) <= 5.2-1
$ rpm -q --requires mingw64-qt5-qtquick1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 mingw64-crt mingw64-filesystem >= 83 mingw64(kernel32.dll) mingw64(libglesv2.dll) mingw64(libstdc++-6.dll) mingw64(msvcrt.dll) mingw64(qt5core.dll) mingw64(qt5declarative.dll) mingw64(qt5gui.dll) mingw64(qt5network.dll) mingw64(qt5opengl.dll) mingw64(qt5script.dll) mingw64(qt5sql.dll) mingw64(qt5widgets.dll) rpmlib(PayloadIsXz) <= 5.2-1
$ rpm -q --provides mingw32-qt5-qtquick1 mingw32-qt5-qtquick1 = 5.0.1-1.fc18 mingw32(qt5declarative.dll) mingw32(qmldbg_inspector.dll) mingw32(qmldbg_tcp_qtdeclarative.dll) mingw32(qmlfolderlistmodelplugin.dll) mingw32(qmlgesturesplugin.dll) mingw32(qmlparticlesplugin.dll) mingw32(qmlshadersplugin.dll)
$ rpm -q --provides mingw64-qt5-qtquick1 mingw64-qt5-qtquick1 = 5.0.1-1.fc18 mingw64(qt5declarative.dll) mingw64(qmldbg_inspector.dll) mingw64(qmldbg_tcp_qtdeclarative.dll) mingw64(qmlfolderlistmodelplugin.dll) mingw64(qmlgesturesplugin.dll) mingw64(qmlparticlesplugin.dll) mingw64(qmlshadersplugin.dll)
+ OK ! Needs to be looked into / Not applicable
[+] Compliant with generic Fedora Packaging Guidelines [+] Source package name is prefixed with 'mingw-' [+] Spec file starts with %{?mingw_package_header} [+] BuildRequires: mingw32-filesystem >= 95 is in the .spec file [+] BuildRequires: mingw64-filesystem >= 95 is in the .spec file [+] Spec file contains %package sections for both mingw32 and mingw64 packages [+] Binary mingw32 and mingw64 packages are noarch [+] Spec file contains %{?mingw_debug_package} after the %description section [+] Uses one of the macros %mingw_configure, %mingw_cmake, %mingw_cmake_kde4 or %mingw_qmake_qt5 to configure the package [+] Uses the macro %mingw_make to build the package [+] Uses the macro %mingw_make to install the package [+] If package contains translations, the %mingw_find_lang macro must be used [+] No binary package named mingw-$pkgname is generated [+] Libtool .la files are not bundled [+] .def files are not bundled [+] Man pages which duplicate native package are not bundled [+] Info files which duplicate native package are not bundled [+] Provides of the binary mingw32 and mingw64 packages are equal [+] Requires of the binary mingw32 and mingw64 packages are equal
All of the warnings and the dependency difference have been addressed in other qt5 reviews.
Approved.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858074
Erik van Pienbroek erik-fedora@vanpienbroek.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-cvs?
--- Comment #4 from Erik van Pienbroek erik-fedora@vanpienbroek.nl --- New Package SCM Request ======================= Package Name: mingw-qt5-qtquick1 Short Description: Qt5 for Windows - QtQuick1 component Owners: epienbro Branches: f17 f18 f19 InitialCC:
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858074
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? | Flags| |fedora-cvs+
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858074
--- Comment #5 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858074
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858074
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- mingw-qt5-qtquick1-5.0.1-1.fc19,mingw-qt5-qtdeclarative-5.0.1-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/mingw-qt5-qtquick1-5.0.1-1.fc19,ming...
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858074
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- mingw-qt5-qtdeclarative-5.0.1-1.fc18,mingw-qt5-qtquick1-5.0.1-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/mingw-qt5-qtdeclarative-5.0.1-1.fc18...
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858074
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858074
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- mingw-qt5-qtquick1-5.0.1-1.fc19, mingw-qt5-qtdeclarative-5.0.1-1.fc19 has been pushed to the Fedora 19 testing repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858074
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2013-04-20 16:12:31
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858074
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- mingw-qt5-qtquick1-5.0.1-1.fc19, mingw-qt5-qtdeclarative-5.0.1-1.fc19 has been pushed to the Fedora 19 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858074
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- mingw-qt5-qtdeclarative-5.0.1-1.fc18, mingw-qt5-qtquick1-5.0.1-1.fc18 has been pushed to the Fedora 18 stable repository.