[Bug 657478] New: Invalid declare statement in macros.mingw32 with some packages

List overview All Threads
Download

newer

older

[Bug 756776] Review Request:...

[Bug 754437] Review Request:...

Red Hat Bugzilla

26 Nov 2010 26 Nov '10

9:52 a.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

Summary: Invalid declare statement in macros.mingw32 with some packages

https://bugzilla.redhat.com/show_bug.cgi?id=657478

Summary: Invalid declare statement in macros.mingw32 with some packages Product: Fedora Version: 14 Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: mingw32-filesystem AssignedTo: rjones@redhat.com ReportedBy: waananen@nbi.dk QAContact: extras-qa@fedoraproject.org CC: rjones@redhat.com, kalev@smartlink.ee, erik-fedora@vanpienbroek.nl, fedora-mingw@lists.fedoraproject.org, drizt@land.ru Classification: Fedora

Description of problem:

I'm using a custom build of mingw32-python in order to build Python bindings for a software package. For this packages the code in macros.mingw32 breaks:

... for i in `ls %{_mingw32_bindir}/*|grep -- "-config$"` ; do \ x=`basename $i|tr "a-z+-" "A-ZX_"`; \ declare -x $x="$i" ; export $x; \ done; \ ...

The variable name $x contains a ('.') when it finds the python2.x-config script in %{_mingw32_bindir}. One could imagine that this problem could be triggered on other *-config scripts.

The fix is easy: filter away dots ('.') from the filename when generating the variable name (eg. |cut -d '.').

Version-Release number of selected component (if applicable):

I found this in Fedora 12, but it seems applicable to Fedora 14.

How reproducible:

Build a package which requires mingw32-python. The mingw32-python does not yet exist in Fedora (unfortunately).

Steps to Reproduce: 1. 2. 3.

Actual results:

Package build fails

Expected results:

Package should build

Additional info:

Cheers

Anders

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Show replies by date

Red Hat Bugzilla

26 Nov 26 Nov

10:12 a.m.

New subject: [Bug 657478] Invalid declare statement in macros.mingw32 with some packages

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=657478

--- Comment #1 from Ivan Romanov drizt@land.ru 2010-11-26 04:12:59 EST --- hello Anders.

May I see your mingw32-python package?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

10:18 a.m.

New subject: [Bug 657478] Invalid declare statement in macros.mingw32 with some packages

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=657478

--- Comment #2 from Anders Wäänänen waananen@nbi.dk 2010-11-26 04:18:55 EST --- Yes, this was based on an OpenSuSE package:

http://download.nordugrid.org/software/mingw32-python/testing/2.6.2-14.4.1ng...

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

10:43 a.m.

New subject: [Bug 657478] Invalid declare statement in macros.mingw32 with some packages

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=657478

--- Comment #3 from Richard W.M. Jones rjones@redhat.com 2010-11-26 04:43:34 EST --- Agreed this is a bug, and your suggestion looks good. Want to post a patch to the mingw32-filesystem package?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

11:25 a.m.

New subject: [Bug 657478] Invalid declare statement in macros.mingw32 with some packages

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=657478

--- Comment #4 from Anders Wäänänen waananen@nbi.dk 2010-11-26 05:25:14 EST --- Created attachment 463052 --> https://bugzilla.redhat.com/attachment.cgi?id=463052 Remove dots in generated shell variable names

Here is a simple patch which should solve the bug.

Cheers

Anders

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

11:47 a.m.

New subject: [Bug 657478] Invalid declare statement in macros.mingw32 with some packages

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=657478

--- Comment #5 from Richard W.M. Jones rjones@redhat.com 2010-11-26 05:47:41 EST --- (In reply to comment #4)

...

Created attachment 463052 [details] Remove dots in generated shell variable names

Here is a simple patch which should solve the bug.

Cheers

Anders

Looks fine to me. You also need to increase the version number (*not* the release, which should go back to 1).

If you want to apply for commit access via https://admin.fedoraproject.org/pkgdb/acls/name/mingw32-filesystem then you can update the package yourself.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

2:07 p.m.

New subject: [Bug 657478] Invalid declare statement in macros.mingw32 with some packages

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=657478

--- Comment #6 from Anders Wäänänen waananen@nbi.dk 2010-11-26 08:07:02 EST --- (In reply to comment #5)

...

If you want to apply for commit access via https://admin.fedoraproject.org/pkgdb/acls/name/mingw32-filesystem then you can update the package yourself.

I'm not sure how to apply from that page since I'm not a packager (yet).

Anders

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

2:19 p.m.

New subject: [Bug 657478] Invalid declare statement in macros.mingw32 with some packages

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=657478

--- Comment #7 from Erik van Pienbroek erik-fedora@vanpienbroek.nl 2010-11-26 08:19:31 EST --- Do you already have a package submitted to Fedora which can be reviewed? Or don't you wish to become a package maintainer?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

2:23 p.m.

New subject: [Bug 657478] Invalid declare statement in macros.mingw32 with some packages

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=657478

--- Comment #8 from Anders Wäänänen waananen@nbi.dk 2010-11-26 08:23:45 EST --- No, I don't have a package ready yet, but I do plan to submit one at some point.

Anders

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

2:36 p.m.

New subject: [Bug 657478] Invalid declare statement in macros.mingw32 with some packages

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=657478

Erik van Pienbroek erik-fedora@vanpienbroek.nl changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED

--- Comment #9 from Erik van Pienbroek erik-fedora@vanpienbroek.nl 2010-11-26 08:36:09 EST --- Are you okay with me applying the change for now?

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

2:39 p.m.

New subject: [Bug 657478] Invalid declare statement in macros.mingw32 with some packages

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=657478

--- Comment #10 from Anders Wäänänen waananen@nbi.dk 2010-11-26 08:39:51 EST --- (In reply to comment #9)

...

Are you okay with me applying the change for now?

Yes, by all means please do!

Cheers

Anders

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

17 Mar 17 Mar

4:56 p.m.

New subject: [Bug 657478] Invalid declare statement in macros.mingw32 with some packages

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=657478

Kalev Lember kalev@smartlink.ee changed:

What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|rjones@redhat.com |kalev@smartlink.ee

--- Comment #11 from Kalev Lember kalev@smartlink.ee 2011-03-17 11:56:30 EDT --- The issue came up again with mingw32-binutils 2.21 that includes a new binary with dot in its name: ld.bfd. I've fixed it with a similar patch in both F15 and rawhide.

Sorry for not using your patch Anders, I wasn't aware of this ticket.

http://pkgs.fedoraproject.org/gitweb/?p=mingw32-filesystem.git;a=commitdiff;...

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

4:57 p.m.

New subject: [Bug 657478] Invalid declare statement in macros.mingw32 with some packages

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=657478

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

4:57 p.m.

New subject: [Bug 657478] Invalid declare statement in macros.mingw32 with some packages

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=657478

--- Comment #12 from Fedora Update System updates@fedoraproject.org 2011-03-17 11:57:44 EDT --- mingw32-filesystem-65-1.fc15, mingw32-binutils-2.21-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/mingw32-filesystem-65-1.fc15,mingw32...

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

22 Mar 22 Mar

4:44 a.m.

New subject: [Bug 657478] Invalid declare statement in macros.mingw32 with some packages

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=657478

--- Comment #13 from Fedora Update System updates@fedoraproject.org 2011-03-21 23:44:32 EDT --- mingw32-filesystem-65-1.fc15, mingw32-binutils-2.21-1.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

4:44 a.m.

New subject: [Bug 657478] Invalid declare statement in macros.mingw32 with some packages

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=657478

Fedora Update System updates@fedoraproject.org changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

6 Jun 6 Jun

4:49 p.m.

New subject: [Bug 657478] Invalid declare statement in macros.mingw32 with some packages

https://bugzilla.redhat.com/show_bug.cgi?id=657478

--- Comment #14 from Anders Wäänänen waananen@nbi.dk --- (In reply to comment #13)

...

mingw32-filesystem-65-1.fc15, mingw32-binutils-2.21-1.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report.

I've noted that the patch in comment #11 does not cover both issues fixed in attachment mentioned in comment #4 thus this is still an issue (also in Fedora 17).

Currently it borks on files in bin which ends in -config which is a problem with eg. python2.7-config. Sorry that I did not notice that the fix in comment #11 was not sufficient.

Can we reopen this issue?

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

7:39 p.m.

New subject: [Bug 657478] Invalid declare statement in macros.mingw32 with some packages

https://bugzilla.redhat.com/show_bug.cgi?id=657478

--- Comment #15 from Erik van Pienbroek erik-fedora@vanpienbroek.nl --- Is the package which triggers this behaviour still available? The link mentioned in comment #2 isn't available any more. And what is the exact output/error message you're seeing?

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

7:53 p.m.

New subject: [Bug 657478] Invalid declare statement in macros.mingw32 with some packages

https://bugzilla.redhat.com/show_bug.cgi?id=657478

--- Comment #16 from Erik van Pienbroek erik-fedora@vanpienbroek.nl --- I just prepped an updated package for Fedora 17: http://koji.fedoraproject.org/koji/taskinfo?taskID=4133139 Could you test if this resolve this issue? (Note: don't use this package on fedora 15/16 as it isn't compatible)

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

9 p.m.

New subject: [Bug 657478] Invalid declare statement in macros.mingw32 with some packages

https://bugzilla.redhat.com/show_bug.cgi?id=657478

--- Comment #17 from Anders Wäänänen waananen@nbi.dk --- (In reply to comment #16)

...

I just prepped an updated package for Fedora 17: http://koji.fedoraproject.org/koji/taskinfo?taskID=4133139 Could you test if this resolve this issue? (Note: don't use this package on fedora 15/16 as it isn't compatible)

Yes this update solves the problem in my mock Fedora 17 environment.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

15 Jun 15 Jun

1:20 p.m.

New subject: [Bug 657478] Invalid declare statement in macros.mingw32 with some packages

https://bugzilla.redhat.com/show_bug.cgi?id=657478

--- Comment #18 from Fedora Update System updates@fedoraproject.org --- mingw-filesystem-95-11.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/FEDORA-2012-9379/mingw-filesystem-95...

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

20 Jun 20 Jun

9:31 p.m.

New subject: [Bug 657478] Invalid declare statement in macros.mingw32 with some packages

https://bugzilla.redhat.com/show_bug.cgi?id=657478

--- Comment #19 from Fedora Update System updates@fedoraproject.org --- mingw-filesystem-95-11.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report.

-- You are receiving this mail because: You are on the CC list for the bug.

4474

Age (days ago)

5046

Last active (days ago)

mingw@lists.fedoraproject.org

21 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla