[Bug 866032] New: configure --disable-static prevents building of freetype static library
https://bugzilla.redhat.com/show_bug.cgi?id=866032
Bug ID: 866032 QA Contact: extras-qa@fedoraproject.org Severity: unspecified Version: rawhide Priority: unspecified CC: erik-fedora@vanpienbroek.nl, fedora-mingw@lists.fedoraproject.org, lfarkas@lfarkas.org, rjones@redhat.com Assignee: rjones@redhat.com Summary: configure --disable-static prevents building of freetype static library Regression: --- Story Points: --- Classification: Fedora OS: Unspecified Reporter: ntd@entidi.it Type: Bug Documentation: --- Hardware: Unspecified Mount Type: --- Status: NEW Component: mingw-freetype Product: Fedora
Back in 2008 static libraries were stripped from the final package. The relevant commit does not explain why: http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/rev/1d89b5e7...
Actually they are disabled at configure level with --disable-static. I'd like to know the rationale behind this.
If that reason still stands a comment should be added to the spec (or I can provide a git patch myself... I don't know if this is common practice here) otherwise adding --enable-static can be considered. I didn't find anything in favor or against it in the wild.
https://bugzilla.redhat.com/show_bug.cgi?id=866032
Erik van Pienbroek erik-fedora@vanpienbroek.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|rjones@redhat.com |erik-fedora@vanpienbroek.nl
--- Comment #1 from Erik van Pienbroek erik-fedora@vanpienbroek.nl --- The commit your referring to dates back from the time when the Fedora MinGW toolchain was in its initial development phase where there was still quite of lot of experimenting going on and packaging guidelines were yet to be written. Back then the packages weren't added to Fedora yet.
As far as I know there hasn't been any real rationale for disabling the static libraries in this case so I don't see any problems with re-adding the static libraries for freetype in a separate subpackage (as is also done with various other mingw packages)
https://bugzilla.redhat.com/show_bug.cgi?id=866032
--- Comment #2 from Nicola Fontana ntd@entidi.it --- Created attachment 632911 --> https://bugzilla.redhat.com/attachment.cgi?id=632911&action=edit Added static subpackage
Hi Erik, I used mingw-glib2 and mingw-fontconfig as templates to add the static subpackage.
Keep in mind I'm *not* using Fedora (I rather ported some of its MinGW packages to Arch linux) so the patch is not tested. Anyway I can confirm the static library does not need any special treatment to be built.
https://bugzilla.redhat.com/show_bug.cgi?id=866032
--- Comment #3 from Erik van Pienbroek erik-fedora@vanpienbroek.nl --- Thank you very much for the patch! I just applied it to the package and the builds are currently being performed
https://bugzilla.redhat.com/show_bug.cgi?id=866032
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=866032
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- mingw-freetype-2.4.10-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/mingw-freetype-2.4.10-2.fc18
https://bugzilla.redhat.com/show_bug.cgi?id=866032
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
https://bugzilla.redhat.com/show_bug.cgi?id=866032
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- Package mingw-freetype-2.4.10-2.fc18: * should fix your issue, * was pushed to the Fedora 18 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing mingw-freetype-2.4.10-2.fc18' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-16910/mingw-freetype-2.4... then log in and leave karma (feedback).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866032
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2012-12-20 11:19:48
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=866032
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- mingw-freetype-2.4.10-2.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report.
-
Red Hat Bugzilla