https://bugzilla.redhat.com/show_bug.cgi?id=1205459 Kalev Lember <kalevlember(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |kalevlember(a)gmail.com Assignee|nobody(a)fedoraproject.org |kalevlember(a)gmail.com Flags| |fedora-review+ --- Comment #1 from Kalev Lember <kalevlember(a)gmail.com&gt; --- Fedora review mingw-qt5-qtwebsockets-5.4.1-1.fc23.src.rpm 2015-03-25 $ rpmlint mingw-qt5-qtwebsockets-5.4.1-1.fc22.src.rpm \ mingw32-qt5-qtwebsockets-5.4.1-1.fc22.noarch.rpm \ mingw64-qt5-qtwebsockets-5.4.1-1.fc22.noarch.rpm \ mingw32-qt5-qtwebsockets-debuginfo-5.4.1-1.fc22.noarch.rpm \ mingw64-qt5-qtwebsockets-debuginfo-5.4.1-1.fc22.noarch.rpm mingw-qt5-qtwebsockets.src:29: W: macro-in-comment %{qt_module} mingw-qt5-qtwebsockets.src:29: W: macro-in-comment %{snapshot_rev} mingw-qt5-qtwebsockets.src:29: W: macro-in-comment %{qt_module} mingw-qt5-qtwebsockets.src:29: W: macro-in-comment %{snapshot_rev} mingw32-qt5-qtwebsockets-debuginfo.noarch: E: debuginfo-without-sources mingw64-qt5-qtwebsockets-debuginfo.noarch: E: debuginfo-without-sources 5 packages and 0 specfiles checked; 2 errors, 4 warnings. + OK ! needs attention + rpmlint warnings are harmless and can be ignored + The package is named according to Fedora MinGW packaging guidelines + The spec file name matches the base package name. + The package meets the Packaging Guidelines + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The license field in the spec file matches the actual license + The stated license for the mingw package is the same as the one for the corresponding native Fedora package ! The license text is included in %license Can you use %license instead of %doc for the license files, please? + Spec file is written in American English + Spec file is legible + Upstream sources match the sources in the srpm 308e1e9126e6fab8b06616db9810973e qtwebsockets-opensource-src-5.4.1.tar.xz 308e1e9126e6fab8b06616db9810973e Download/qtwebsockets-opensource-src-5.4.1.tar.xz + The package builds in koji n/a ExcludeArch bugs filed + BuildRequires look sane n/a locale handling n/a ldconfig in %post and %postun + Package does not bundle copies of system libraries n/a Package isn't relocatable + Package owns all the directories it creates + No duplicate files in %files + Permissions are properly set + Consistent use of macros + The package must contain code or permissible content n/a Large documentation files should go in -doc subpackage + Files marked %doc should not affect the runtime of application n/a Static libraries should be in -static n/a Development files should be in -devel Not applicable to MinGW packages. n/a -devel must require the fully versioned base + Packages should not contain libtool .la files n/a Proper .desktop file handling + Doesn't own files or directories already owned by other packages + Filenames are valid UTF-8 Looks good to me, just a minor problem with the %license vs %doc macros -- the guidelines were recently updated to require the %license macro for license files. Please fix this before importing. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zJvkYMkJjb&a=cc_unsubscribe

https://bugzilla.redhat.com/show_bug.cgi?id=1205459 Jon Ciesla <limburgher(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jGvEKnpqMP&a=cc_unsubscribe

https://bugzilla.redhat.com/show_bug.cgi?id=1205459 Fedora Update System <updates(a)fedoraproject.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mbzWBaNy57&a=cc_unsubscribe

https://bugzilla.redhat.com/show_bug.cgi?id=1205459 --- Comment #5 from Fedora Update System <updates(a)fedoraproject.org&gt; --- mingw-qt5-qtwebsockets-5.4.1-1.fc21,mingw-qt5-qtxmlpatterns-5.4.1-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/mingw-qt5-qtwebsockets-5.4.1-1.fc... -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ncSSrNI0GB&a=cc_unsubscribe

https://bugzilla.redhat.com/show_bug.cgi?id=1205459 --- Comment #7 from Fedora Update System <updates(a)fedoraproject.org&gt; --- mingw-qt5-qtwebsockets-5.4.1-1.el7,mingw-qt5-qtxmlpatterns-5.4.1-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/mingw-qt5-qtwebsockets-5.4.1-1.el... -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kjcYAP3sD5&a=cc_unsubscribe

https://bugzilla.redhat.com/show_bug.cgi?id=1205459 Fedora Update System <updates(a)fedoraproject.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |mingw-qt5-qtwebsockets-5.4. | |1-1.fc22 Resolution|--- |ERRATA Last Closed| |2015-03-31 17:48:49 --- Comment #9 from Fedora Update System <updates(a)fedoraproject.org&gt; --- mingw-qt5-qtwebsockets-5.4.1-1.fc22, mingw-qt5-qtxmlpatterns-5.4.1-1.fc22 has been pushed to the Fedora 22 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DGcPWWRRYu&a=cc_unsubscribe

https://bugzilla.redhat.com/show_bug.cgi?id=1205459 Fedora Update System <updates(a)fedoraproject.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|mingw-qt5-qtwebsockets-5.4. |mingw-qt5-qtwebsockets-5.4. |1-1.fc21 |1-1.fc20 --- Comment #11 from Fedora Update System <updates(a)fedoraproject.org&gt; --- mingw-qt5-qtwebsockets-5.4.1-1.fc20, mingw-qt5-qtxmlpatterns-5.4.1-1.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sRBM7uahnv&a=cc_unsubscribe