hi, did you review my past filesystem patch?
in the next week i'm plan to review these packages in that order (it's the dependency order): mingw32-iconv mingw32-termcap mingw32-zlib mingw32-libpng mingw32-libjpeg mingw32-gettext mingw32-glib2 mingw32-freetype mingw32-atk mingw32-pixman mingw32-libxml2 mingw32-fontconfig mingw32-cairo mingw32-pango mingw32-openssl mingw32-pthreads and may be a few other smaller ones. but my next week will be very busy so i don't now when.
On Sun, Nov 30, 2008 at 12:27:15AM +0100, Farkas Levente wrote:
hi, did you review my past filesystem patch?
OK, I'll have a look at it tomorrow^Wtoday .. Can you repost what you think is the latest version so we are on the same page?
Thanks for taking a look at those other reviews.
Rich.
Richard W.M. Jones wrote:
On Sun, Nov 30, 2008 at 12:27:15AM +0100, Farkas Levente wrote:
hi, did you review my past filesystem patch?
OK, I'll have a look at it tomorrow^Wtoday .. Can you repost what you think is the latest version so we are on the same page?
here it's again.
Thanks for taking a look at those other reviews.
the other patch in the libxml2 what we already discuss in the review: --- mingw32-libxml2.spec.lfarkas 2008-11-10 18:03:16.000000000 +0100 +++ mingw32-libxml2.spec 2008-11-10 18:35:10.000000000 +0100 @@ -40,6 +40,10 @@
%build +%if 0%{?fedora} < 9 +aclocal +autoreconf +%endif LDFLAGS="-no-undefined" %{_mingw32_configure} --without-python --with-modules make
On Sun, Nov 30, 2008 at 06:18:36PM +0100, Farkas Levente wrote:
Richard W.M. Jones wrote:
On Sun, Nov 30, 2008 at 12:27:15AM +0100, Farkas Levente wrote:
hi, did you review my past filesystem patch?
OK, I'll have a look at it tomorrow^Wtoday .. Can you repost what you think is the latest version so we are on the same page?
here it's again.
Thanks for taking a look at those other reviews.
the other patch in the libxml2 what we already discuss in the review: --- mingw32-libxml2.spec.lfarkas 2008-11-10 18:03:16.000000000 +0100 +++ mingw32-libxml2.spec 2008-11-10 18:35:10.000000000 +0100 @@ -40,6 +40,10 @@
%build +%if 0%{?fedora} < 9 +aclocal +autoreconf +%endif
Am I right in thinking that this code only applies for Fedora <= 8 (or does that include EPEL?) Anyway, yes the patch is fine, because it won't affect us, but it will break things in mock/F-8 because you also need to add a BuildRequires: autoconf, automake, libtool (or something like that).
Index: mingw32-filesystem.spec
RCS file: /cvs/pkgs/rpms/mingw32-filesystem/devel/mingw32-filesystem.spec,v retrieving revision 1.6 diff -u -u -r1.6 mingw32-filesystem.spec --- mingw32-filesystem.spec 24 Nov 2008 16:08:07 -0000 1.6 +++ mingw32-filesystem.spec 27 Nov 2008 20:54:54 -0000
I have some time to look at this tomorrow. If it works I'll just apply it.
Rich.
Richard W.M. Jones wrote:
On Sun, Nov 30, 2008 at 06:18:36PM +0100, Farkas Levente wrote:
Richard W.M. Jones wrote:
On Sun, Nov 30, 2008 at 12:27:15AM +0100, Farkas Levente wrote:
hi, did you review my past filesystem patch?
OK, I'll have a look at it tomorrow^Wtoday .. Can you repost what you think is the latest version so we are on the same page?
here it's again.
Thanks for taking a look at those other reviews.
the other patch in the libxml2 what we already discuss in the review: --- mingw32-libxml2.spec.lfarkas 2008-11-10 18:03:16.000000000 +0100 +++ mingw32-libxml2.spec 2008-11-10 18:35:10.000000000 +0100 @@ -40,6 +40,10 @@
%build +%if 0%{?fedora} < 9 +aclocal +autoreconf +%endif
Am I right in thinking that this code only applies for Fedora <= 8 (or does that include EPEL?) Anyway, yes the patch is fine, because it won't affect us, but it will break things in mock/F-8 because you also need to add a BuildRequires: autoconf, automake, libtool (or something like that).
actually it's effect epel too, what's more that's the reason why i use it. rhel-5's rpm sp old it doesn't have any define to recognize the distro, so this is the easiest way to do so. and as libxm2's tarbal was generated with newer autoconf the epel versuin can't use it so we've to regenerate them. and you've got right BR should have to be also added into the same %if block.
Index: mingw32-filesystem.spec
RCS file: /cvs/pkgs/rpms/mingw32-filesystem/devel/mingw32-filesystem.spec,v retrieving revision 1.6 diff -u -u -r1.6 mingw32-filesystem.spec --- mingw32-filesystem.spec 24 Nov 2008 16:08:07 -0000 1.6 +++ mingw32-filesystem.spec 27 Nov 2008 20:54:54 -0000
I have some time to look at this tomorrow. If it works I'll just apply it.
thanks.
I added this patch, except that I removed mingw32-make. This command didn't expand %{name}, %{version} etc. in the make parameters. In fact, this command can never work because correct values for these parameters cannot be known by an independently running mingw32-make command.
Rich.
$ cat > configure #!/bin/sh -
echo args = "$@" printenv | sort
$ chmod 0755 configure
$ mingw32-configure a b c args = --cache-file=mingw32-config.cache --host=i686-pc-mingw32 --build=x86_64-unknown-linux-gnu --target=i686-pc-mingw32 --prefix=/usr/i686-pc-mingw32/sys-root/mingw --exec-prefix=/usr/i686-pc-mingw32/sys-root/mingw --bindir=/usr/i686-pc-mingw32/sys-root/mingw/bin --sbindir=/usr/i686-pc-mingw32/sys-root/mingw/sbin --sysconfdir=/usr/i686-pc-mingw32/sys-root/mingw/etc --datadir=/usr/i686-pc-mingw32/sys-root/mingw/share --includedir=/usr/i686-pc-mingw32/sys-root/mingw/include --libdir=/usr/i686-pc-mingw32/sys-root/mingw/lib --libexecdir=/usr/i686-pc-mingw32/sys-root/mingw/libexec --localstatedir=/usr/i686-pc-mingw32/sys-root/mingw/var --sharedstatedir=/usr/i686-pc-mingw32/sys-root/mingw/com --mandir=/usr/i686-pc-mingw32/sys-root/mingw/share/man --infodir=/usr/i686-pc-mingw32/sys-root/mingw/share/info a b c ADDR2LINE=/usr/bin/i686-pc-mingw32-addr2line AR=/usr/bin/i686-pc-mingw32-ar AS=/usr/bin/i686-pc-mingw32-as CC=i686-pc-mingw32-gcc CFLAGS=-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions --param=ssp-buffer-size=4 -mms-bitfields CPP=/usr/bin/i686-pc-mingw32-cpp CURL_CONFIG=/usr/i686-pc-mingw32/sys-root/mingw/bin/curl-config CXXFILT=/usr/bin/i686-pc-mingw32-c++filt CXXFLAGS=-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions --param=ssp-buffer-size=4 -mms-bitfields CXX=/usr/bin/i686-pc-mingw32-c++ DISPLAY=localhost:10.0 DLLTOOL=/usr/bin/i686-pc-mingw32-dlltool DLLWRAP=/usr/bin/i686-pc-mingw32-dllwrap FREETYPE_CONFIG=/usr/i686-pc-mingw32/sys-root/mingw/bin/freetype-config G_BROKEN_FILENAMES=1 GCCBUG=/usr/bin/i686-pc-mingw32-gccbug GCC=/usr/bin/i686-pc-mingw32-gcc GCOV=/usr/bin/i686-pc-mingw32-gcov GPG_ERROR_CONFIG=/usr/i686-pc-mingw32/sys-root/mingw/bin/gpg-error-config GPROF=/usr/bin/i686-pc-mingw32-gprof GSL_CONFIG=/usr/i686-pc-mingw32/sys-root/mingw/bin/gsl-config GXX=/usr/bin/i686-pc-mingw32-g++ HISTSIZE=1000 HOST_CC=gcc HOSTNAME=intel-mb INPUTRC=/etc/inputrc LANG=en_US.UTF-8 LD=/usr/bin/i686-pc-mingw32-ld LESSOPEN=|/usr/bin/lesspipe.sh %s LIBGCRYPT_CONFIG=/usr/i686-pc-mingw32/sys-root/mingw/bin/libgcrypt-config LIBGNUTLS_CONFIG=/usr/i686-pc-mingw32/sys-root/mingw/bin/libgnutls-config LIBGNUTLS_EXTRA_CONFIG=/usr/i686-pc-mingw32/sys-root/mingw/bin/libgnutls-extra-config LIBPNG12_CONFIG=/usr/i686-pc-mingw32/sys-root/mingw/bin/libpng12-config LIBPNG_CONFIG=/usr/i686-pc-mingw32/sys-root/mingw/bin/libpng-config NM=/usr/bin/i686-pc-mingw32-nm OBJCOPY=/usr/bin/i686-pc-mingw32-objcopy OBJDUMP=/usr/bin/i686-pc-mingw32-objdump PKG_CONFIG_PATH=/usr/i686-pc-mingw32/sys-root/mingw/lib/pkgconfig PWD=/tmp/t QTDIR=/usr/lib64/qt-3.3 QTINC=/usr/lib64/qt-3.3/include QTLIB=/usr/lib64/qt-3.3/lib RANLIB=/usr/bin/i686-pc-mingw32-ranlib READELF=/usr/bin/i686-pc-mingw32-readelf SDL_CONFIG=/usr/i686-pc-mingw32/sys-root/mingw/bin/sdl-config SELINUX_LEVEL_REQUESTED= SELINUX_ROLE_REQUESTED= SELINUX_USE_CURRENT_RANGE= SHELL=/bin/bash SHLVL=3 SIZE=/usr/bin/i686-pc-mingw32-size
Richard W.M. Jones wrote:
I added this patch, except that I removed mingw32-make. This command didn't expand %{name}, %{version} etc. in the make parameters. In fact, this command can never work because correct values for these parameters cannot be known by an independently running mingw32-make command.
i don't really understand this. i don't use name and version in the make macro and the script call the macro and the script do not intended to use in spec file rather then in a standalone environment. eg. we have projects which have to compile and don't use autotools, but have makefiles. in this case i like to use a command line command to actually build the projects. that was the main reason why i rewrite the whole filesystem macros. that's why i need such a scripts.
On Mon, Dec 15, 2008 at 11:23:36PM +0100, Farkas Levente wrote:
Richard W.M. Jones wrote:
I added this patch, except that I removed mingw32-make. This command didn't expand %{name}, %{version} etc. in the make parameters. In fact, this command can never work because correct values for these parameters cannot be known by an independently running mingw32-make command.
i don't really understand this. i don't use name and version in the make macro [...]
%{name} and %{version} are used indirectly in various circumstances. A common case is where you're using a buildroot under your home directory. In my case %{_mingw32_make} expands to:
$ rpm --eval '%{_mingw32_make}' HOST_CC=gcc; export HOST_CC; [...] make \ prefix=/home/rjones/rpmbuild/BUILDROOT/%{name}-%{version}-%{release}.x86_64/usr/i686-pc-mingw32/sys-root/mingw \ exec_prefix=/home/rjones/rpmbuild/BUILDROOT/%{name}-%{version}-%{release}.x86_64/usr/i686-pc-mingw32/sys-root/mingw \ [...]
(This overriding of buildroots with stuff based on %_topdir was only added to rpm or Fedora's configuration of rpm relatively recently).
Rich.
Richard W.M. Jones wrote:
On Mon, Dec 15, 2008 at 11:23:36PM +0100, Farkas Levente wrote:
Richard W.M. Jones wrote:
I added this patch, except that I removed mingw32-make. This command didn't expand %{name}, %{version} etc. in the make parameters. In fact, this command can never work because correct values for these parameters cannot be known by an independently running mingw32-make command.
i don't really understand this. i don't use name and version in the make macro [...]
%{name} and %{version} are used indirectly in various circumstances. A common case is where you're using a buildroot under your home directory. In my case %{_mingw32_make} expands to:
$ rpm --eval '%{_mingw32_make}' HOST_CC=gcc; export HOST_CC; [...] make \ prefix=/home/rjones/rpmbuild/BUILDROOT/%{name}-%{version}-%{release}.x86_64/usr/i686-pc-mingw32/sys-root/mingw \ exec_prefix=/home/rjones/rpmbuild/BUILDROOT/%{name}-%{version}-%{release}.x86_64/usr/i686-pc-mingw32/sys-root/mingw \ [...]
(This overriding of buildroots with stuff based on %_topdir was only added to rpm or Fedora's configuration of rpm relatively recently).
that's sucks:-( on centos-5 it expand to working thing. i will rewrite it to something working version.
# rpm --eval '%{_mingw32_make}' HOST_CC=gcc; export HOST_CC; PKG_CONFIG_PATH="/usr/i686-pc-mingw32/sys-root/mingw/lib/pkgconfig"; export PKG_CONFIG_PATH; CC="${MINGW32_CC:-i686-pc-mingw32-gcc}"; export CC; CXX="${MINGW32_CXX:-i686-pc-mingw32-g++}"; export CXX; CFLAGS="${MINGW32_CFLAGS:--O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions --param=ssp-buffer-size=4 -mms-bitfields}"; export CFLAGS; CXXFLAGS="${MINGW32_CXXFLAGS:--O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions --param=ssp-buffer-size=4 -mms-bitfields}"; export CXXFLAGS; _PREFIX="/usr/bin/i686-pc-mingw32-"; for i in `ls ${_PREFIX}*|egrep -v "gcc-"`; do x=`echo $i|sed "s,${_PREFIX},,"|tr "a-z+-" "A-ZX_"`; declare -x $x="$i" ; export $x; done; unset _PREFIX; for i in `ls /usr/i686-pc-mingw32/sys-root/mingw/bin/*|grep -- "-config$"` ; do x=`basename $i|tr "a-z+-" "A-ZX_"`; declare -x $x="$i" ; export $x; done; unset x i ; make \ prefix=/usr/i686-pc-mingw32/sys-root/mingw \ exec_prefix=/usr/i686-pc-mingw32/sys-root/mingw \ bindir=/usr/i686-pc-mingw32/sys-root/mingw/bin \ sbindir=/usr/i686-pc-mingw32/sys-root/mingw/sbin \ sysconfdir=/usr/i686-pc-mingw32/sys-root/mingw/etc \ datadir=/usr/i686-pc-mingw32/sys-root/mingw/share \ includedir=/usr/i686-pc-mingw32/sys-root/mingw/include \ libdir=/usr/i686-pc-mingw32/sys-root/mingw/lib \ libexecdir=/usr/i686-pc-mingw32/sys-root/mingw/libexec \ localstatedir=/usr/i686-pc-mingw32/sys-root/mingw/var \ sharedstatedir=/usr/i686-pc-mingw32/sys-root/mingw/com \ mandir=/usr/i686-pc-mingw32/sys-root/mingw/share/man \ infodir=/usr/i686-pc-mingw32/sys-root/mingw/share/info
-
Farkas Levente -
Richard W.M. Jones