Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=499987

Kalev Lember kalev@smartlink.ee changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |kalev@smartlink.ee AssignedTo|nobody@fedoraproject.org |kalev@smartlink.ee Flag| |fedora-review?

Bug 499987 depends on bug 499986, which changed state.

Bug 499986 Summary: Review Request: mingw32-libidn - MinGW Windows Internationalized Domain Name support library https://bugzilla.redhat.com/show_bug.cgi?id=499986

What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Resolution| |NEXTRELEASE Status|ASSIGNED |CLOSED

Bug 499987 depends on bug 499979, which changed state.

Bug 499979 Summary: Review Request: mingw32-libssh2 - MinGW Windows library implementation of the SSH2 protocol https://bugzilla.redhat.com/show_bug.cgi?id=499979

What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |NEXTRELEASE Status|ASSIGNED |CLOSED

--- Comment #1 from Kalev Lember kalev@smartlink.ee 2009-11-18 13:25:48 EDT --- Taking for review.

Eric, can you update it to the version of native Fedora curl package before I go on?

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=499987

--- Comment #3 from Kalev Lember kalev@smartlink.ee 2009-12-11 16:22:08 EDT --- Fedora review mingw32-curl-7.19.7-1.fc12.src.rpm 2009-12-11

+ OK ! needs attention

rpmlint says: mingw32-curl.noarch: W: spelling-error-in-summary en_US libcurl mingw32-curl.src: W: spelling-error-in-summary en_US libcurl mingw32-curl-debuginfo.noarch: W: spelling-error-in-summary en_US mingw mingw32-curl-debuginfo.noarch: W: spelling-error-in-description en_US mingw mingw32-curl-debuginfo.noarch: E: debuginfo-without-sources mingw32-curl-static.noarch: E: arch-independent-package-contains-binary-or-object /usr/i686-pc-mingw32/sys-root/mingw/lib/libcurl.a mingw32-curl-static.noarch: W: no-documentation 4 packages and 0 specfiles checked; 2 errors, 5 warnings.

+ rpmlint errors / warnings above are harmless and can be ignored. + Package is named according to the Fedora MinGW naming guidelines + Package follows the Fedora MinGW packaging guideliens + The stated license (MIT) is a Fedora approved license + The stated license is the same as the one for the corresponding native Fedora package + The package contains the license file (COPYING) + Spec file is written in American English + Spec file is legible + Upstream sources match sources in the srpm. md5sum: 26124caef7359de6338172abafa98dc0 curl-7.19.7.tar.lzma 26124caef7359de6338172abafa98dc0 Download/curl-7.19.7.tar.lzma + Package builds in koji n/a ExcludeArch bugs filed ! BuildRequires look sane, except that BR pkgconfig is probably not needed. n/a The spec file MUST handle locales properly + Packages does not bundle copies of system libraries + Does not use Prefix: /usr + Package owns all directories it creates + No duplicate files in %files + Permissions are properly set and %files has %defattr + %clean contains rm -rf $RPM_BUILD_ROOT + Consistent use of macros + Package contains code or permissible content n/a Large documentation files should go in -doc subpackage + Files marked %doc should not affect package n/a Header files should be in -devel Fedora MinGW guidelines allow headers in main package + Static libraries are in mingw32-curl-static + Packages containing pkgconfig (.pc) files need 'Requires: pkgconfig' n/a Library files that end in .so must go in a -devel package n/a -devel must require the fully versioned base n/a Packages should not contain libtool .la files Fedora MinGW guidelines allow .la files n/a Packages containing GUI apps must include %{name}.desktop file + Packages must not own files or directories owned by other packages + %install begins with rm -rf $RPM_BUILD_ROOT + Filenames must be valid UTF-8

! This package includes curl.exe, which I believe is out of scope for Fedora MinGW, as only development libraries are allowed. Curl.exe is a full-blown command-line standalone cross-compiled application that is not allowed under the Fedora MinGW rules.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=499987

--- Comment #5 from Kalev Lember kalev@smartlink.ee 2010-03-29 01:41:54 EDT --- Erik, any update on this? I'd be happy to approve the package if you remove curl.exe. I don't really believe in packages improving out of tree; libcurl can always be switched to use NSS at a later date. IMHO it's better to have an openssl-linked libcurl in official Fedora repos than no libcurl at all.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=499987

--- Comment #8 from Erik van Pienbroek erik-fedora@vanpienbroek.nl 2010-05-13 07:43:50 EDT --- Spec URL: http://www.ftd4linux.nl/contrib/mingw32-curl.spec SRPM URL: http://www.ftd4linux.nl/contrib/mingw32-curl-7.20.1-1.fc13.src.rpm

* Thu May 13 2010 Erik van Pienbroek epienbro@fedoraproject.org - 7.20.1-1 - Update to 7.20.1 - Merged the patches of the native .spec file (7.20.1-5) - Dropped the curl.exe - Use the Win32 threads API instead of mingw32-pthreads - Dropped BR: pkgconfig

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=499987

Kalev Lember kalev@smartlink.ee changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+

--- Comment #10 from Kalev Lember kalev@smartlink.ee 2010-05-13 08:45:18 EDT --- Looks good.

APPROVED

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=499987

Dennis Gilmore dennis@ausil.us changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

--- Comment #12 from Dennis Gilmore dennis@ausil.us 2010-05-13 18:35:47 EDT --- CVS Done

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=499987

--- Comment #14 from Fedora Update System updates@fedoraproject.org 2010-05-16 10:34:43 EDT --- mingw32-curl-7.20.1-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/mingw32-curl-7.20.1-1.fc12

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=499987

--- Comment #16 from Fedora Update System updates@fedoraproject.org 2010-05-17 14:54:03 EDT --- mingw32-curl-7.20.1-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=499987

--- Comment #17 from Fedora Update System updates@fedoraproject.org 2010-05-17 15:08:46 EDT --- mingw32-curl-7.20.1-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=499987

--- Comment #18 from Fedora Update System updates@fedoraproject.org 2010-06-09 11:48:56 EDT --- mingw32-curl-7.20.1-2.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report.