https://bugzilla.redhat.com/show_bug.cgi?id=961402

Erik van Pienbroek erik-fedora@vanpienbroek.nl changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+

--- Comment #4 from Erik van Pienbroek erik-fedora@vanpienbroek.nl --- Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5582835

$ rpmlint mingw-giflib.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings.

$ rpmlint mingw-giflib-4.1.6-2.fc19.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint mingw32-giflib-4.1.6-2.fc19.noarch.rpm mingw32-giflib-static-4.1.6-2.fc19.noarch.rpm mingw32-giflib-tools-4.1.6-2.fc19.noarch.rpm mingw64-giflib-4.1.6-2.fc19.noarch.rpm mingw64-giflib-static-4.1.6-2.fc19.noarch.rpm mingw64-giflib-tools-4.1.6-2.fc19.noarch.rpm mingw32-giflib-static.noarch: W: no-documentation mingw32-giflib-tools.noarch: W: no-documentation mingw64-giflib-static.noarch: W: no-documentation mingw64-giflib-tools.noarch: W: no-documentation 6 packages and 0 specfiles checked; 0 errors, 4 warnings.

$ rpm --query --requires mingw32-giflib rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 mingw32-crt mingw32-filesystem >= 95 mingw32(kernel32.dll) mingw32(libgcc_s_sjlj-1.dll) mingw32(msvcrt.dll) rpmlib(PayloadIsXz) <= 5.2-1

$ rpm --query --requires mingw64-giflib rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 mingw64-crt mingw64-filesystem >= 95 mingw64(kernel32.dll) mingw64(msvcrt.dll) rpmlib(PayloadIsXz) <= 5.2-1

$ rpm --query --requires mingw32-giflib-static mingw32-giflib = 4.1.6-2.fc19 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadIsXz) <= 5.2-1

$ rpm --query --requires mingw64-giflib-static mingw64-giflib = 4.1.6-2.fc19 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadIsXz) <= 5.2-1

$ rpm --query --requires mingw32-giflib-tools mingw32-giflib = 4.1.6-2.fc19 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 mingw32-crt mingw32-filesystem >= 95 mingw32(kernel32.dll) mingw32(libgif-4.dll) mingw32(msvcrt.dll) rpmlib(PayloadIsXz) <= 5.2-1

$ rpm --query --requires mingw64-giflib-tools mingw64-giflib = 4.1.6-2.fc19 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 mingw64-crt mingw64-filesystem >= 95 mingw64(kernel32.dll) mingw64(libgif-4.dll) mingw64(msvcrt.dll) rpmlib(PayloadIsXz) <= 5.2-1

$ rpm --query --provides mingw32-giflib mingw32-giflib = 4.1.6-2.fc19 mingw32(libgif-4.dll)

$ rpm --query --provides mingw64-giflib mingw64-giflib = 4.1.6-2.fc19 mingw64(libgif-4.dll)

$ rpm --query --provides mingw32-giflib-static mingw32-giflib-static = 4.1.6-2.fc19

$ rpm --query --provides mingw64-giflib-static mingw64-giflib-static = 4.1.6-2.fc19

$ rpm --query --provides mingw32-giflib-tools mingw32-giflib-tools = 4.1.6-2.fc19

$ rpm --query --provides mingw64-giflib-tools mingw64-giflib-tools = 4.1.6-2.fc19

$ wget --quiet http://downloads.sourceforge.net/giflib/giflib-4.1.6.tar.bz2 -O - | md5sum 7125644155ae6ad33dbc9fc15a14735f - $ md5sum giflib-4.1.6.tar.bz2 7125644155ae6ad33dbc9fc15a14735f giflib-4.1.6.tar.bz2

+ OK ! Needs to be looked into / Not applicable

[+] Compliant with generic Fedora Packaging Guidelines [+] Source package name is prefixed with 'mingw-' [+] Spec file starts with %{?mingw_package_header} [+] BuildRequires: mingw32-filesystem >= 95 is in the .spec file [+] BuildRequires: mingw64-filesystem >= 95 is in the .spec file [+] Spec file contains %package sections for both mingw32 and mingw64 packages [+] Binary mingw32 and mingw64 packages are noarch [+] Spec file contains %{?mingw_debug_package} after the %description section [+] Uses one of the macros %mingw_configure, %mingw_cmake, or %mingw_cmake_kde4 to configure the package [+] Uses the macro %mingw_make to build the package [+] Uses the macro %mingw_make to install the package [+] If package contains translations, the %mingw_find_lang macro must be used [+] No binary package named mingw-$pkgname is generated [+] Libtool .la files are not bundled [+] .def files are not bundled [+] Man pages which duplicate native package are not bundled [+] Info files which duplicate native package are not bundled [+] Provides of the binary mingw32 and mingw64 packages are equal [!] Requires of the binary mingw32 and mingw64 packages are equal

The mingw32 package seems to depend on libgcc_s_sjlj-1.dll while the mingw64 package doesn't. I've also seen this on various other packages so we can ignore this for now

================================================ The package mingw-giflib is APPROVED by epienbro ================================================