https://bugzilla.redhat.com/show_bug.cgi?id=858082

Erik van Pienbroek erik-fedora@vanpienbroek.nl changed:

What |Removed |Added ---------------------------------------------------------------------------- Depends On| |858058

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858082

Bug 858082 depends on bug 858058, which changed state.

Bug 858058 Summary: Review Request: mingw-qt5-qtbase - Qt5 for Windows - QtBase component https://bugzilla.redhat.com/show_bug.cgi?id=858058

What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858082

Bug 858082 depends on bug 858080, which changed state.

Bug 858080 Summary: Review Request: mingw-qt5-qttools - Qt5 for Windows - QtTools component https://bugzilla.redhat.com/show_bug.cgi?id=858080

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858082

--- Comment #4 from greg.hellings@gmail.com --- $ rpmlint mingw-qt5-qttranslations.spec mingw-qt5-qttranslations.spec:26: W: macro-in-comment %{qt_module} mingw-qt5-qttranslations.spec:26: W: macro-in-comment %{snapshot_rev} mingw-qt5-qttranslations.spec:26: W: macro-in-comment %{qt_module} mingw-qt5-qttranslations.spec:26: W: macro-in-comment %{snapshot_rev} 0 packages and 1 specfiles checked; 0 errors, 4 warnings.

$ rpmlint mingw-qt5-qttranslations-5.0.1-1.fc19.src.rpm mingw-qt5-qttranslations.src:26: W: macro-in-comment %{qt_module} mingw-qt5-qttranslations.src:26: W: macro-in-comment %{snapshot_rev} mingw-qt5-qttranslations.src:26: W: macro-in-comment %{qt_module} mingw-qt5-qttranslations.src:26: W: macro-in-comment %{snapshot_rev} 1 packages and 0 specfiles checked; 0 errors, 4 warnings.

$ rpmlint results_mingw-qt5-qttranslations/5.0.1/1.fc18/mingw{32,64}* mingw32-qt5-qttranslations.noarch: W: no-documentation mingw32-qt5-qttranslations-debuginfo.noarch: E: empty-debuginfo-package mingw64-qt5-qttranslations.noarch: W: no-documentation mingw64-qt5-qttranslations-debuginfo.noarch: E: empty-debuginfo-package 4 packages and 0 specfiles checked; 2 errors, 2 warnings.

Since there is no binary portion to this package, it appears you should disable building of the debuginfo packages.

$ rpm -q --requires mingw32-qt5-qttranslations rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadIsXz) <= 5.2-1

$ rpm -q --requires mingw64-qt5-qttranslations rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadIsXz) <= 5.2-1

$ rpm -q --provides mingw32-qt5-qttranslations mingw32-qt5-qttranslations = 5.0.1-1.fc18

$ rpm -q --provides mingw64-qt5-qttranslations mingw64-qt5-qttranslations = 5.0.1-1.fc18

$ wget --quiet http://releases.qt-project.org/qt5/5.0.1/submodules_tar/qttranslations-opens... -O - | md5sum de27f8384296e366e454754b69197634 - $ md5sum qttranslations-opensource-src-5.0.1.tar.xz de27f8384296e366e454754b69197634 qttranslations-opensource-src-5.0.1.tar.xz

+ OK ! Needs to be looked into / Not applicable

[+] Compliant with generic Fedora Packaging Guidelines [+] Source package name is prefixed with 'mingw-' [+] Spec file starts with %{?mingw_package_header} [+] BuildRequires: mingw32-filesystem >= 95 is in the .spec file [+] BuildRequires: mingw64-filesystem >= 95 is in the .spec file [+] Spec file contains %package sections for both mingw32 and mingw64 packages [+] Binary mingw32 and mingw64 packages are noarch [+] Spec file contains %{?mingw_debug_package} after the %description section [+] Uses one of the macros %mingw_configure, %mingw_cmake, %mingw_cmake_kde4 or %mingw_qmake_qt5 to configure the package [+] Uses the macro %mingw_make to build the package [+] Uses the macro %mingw_make to install the package [!] If package contains translations, the %mingw_find_lang macro must be used [+] No binary package named mingw-$pkgname is generated [+] Libtool .la files are not bundled [+] .def files are not bundled [+] Man pages which duplicate native package are not bundled [+] Info files which duplicate native package are not bundled [+] Provides of the binary mingw32 and mingw64 packages are equal [+] Requires of the binary mingw32 and mingw64 packages are equal

I believe the debug package can be suppressed as there is no binary code which includes debug symbols here.

Additionally, this package is, by its very nature, a translations package. Yet you're not using the find_lang macro. Does it not support .qm files? Does it need to be updated to include these files as well, or are qm files considered too app specific for that?

You note that the BR for mingw32-qt-qmake and mingw64-qt-qmake are "Temporary until lrelease-qt5 is built." I don't see a native package for those yet, but I see mingw{32,64}-qt5-qttools-lrelease. Is the native package built and ready yet? If not, you might note what issue # will see it completed in the spec file for sanity's sake.

The rest of the issues have been addressed elsewhere in mingw-qt5 reviews.

https://bugzilla.redhat.com/show_bug.cgi?id=858082

--- Comment #6 from greg.hellings@gmail.com --- The spec file looks fine upon inspection but I can't get the SRPM from the koji link. I'm guessing koji doesn't keep those files around forever and I was too slow in getting back to this.

https://bugzilla.redhat.com/show_bug.cgi?id=858082

greg.hellings@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+

--- Comment #8 from greg.hellings@gmail.com --- I'm getting "mingw-qt5-qttranslations.src: W: invalid-url URL: http://www.qtsoftware.com/ timed out". We just spoke on IRC about updating that to qt-project.org. Everything else appears to be addressed.

https://bugzilla.redhat.com/show_bug.cgi?id=858082

Jon Ciesla limburgher@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? | Flags| |fedora-cvs+

https://bugzilla.redhat.com/show_bug.cgi?id=858082

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED

https://bugzilla.redhat.com/show_bug.cgi?id=858082

--- Comment #12 from Fedora Update System updates@fedoraproject.org --- mingw-qt5-qtimageformats-5.0.2-2.fc18,mingw-qt5-qtgraphicaleffects-5.0.2-4.fc18,mingw-qt5-qttranslations-5.0.2-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/mingw-qt5-qtimageformats-5.0.2-2.fc1...

https://bugzilla.redhat.com/show_bug.cgi?id=858082

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |mingw-qt5-qtimageformats-5. | |0.2-2.fc19 Resolution|--- |ERRATA Last Closed| |2013-06-13 02:38:18

--- Comment #14 from Fedora Update System updates@fedoraproject.org --- mingw-qt5-qtimageformats-5.0.2-2.fc19, mingw-qt5-qtgraphicaleffects-5.0.2-4.fc19, mingw-qt5-qttranslations-5.0.2-2.fc19 has been pushed to the Fedora 19 stable repository.