https://bugzilla.redhat.com/show_bug.cgi?id=979564

Sandro Mani manisandro@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?

--- Comment #1 from Sandro Mani manisandro@gmail.com --- Must fix: - mingw{32,64}-pthreads BR are missing - ftp://ftp.sane-project.org seems down (temporary?), so Source0 does not work. - License breakdown must be documented [1] - Requires of -static subpackages are incorrect. (The way I do it is to define %pkgname with the native package name, and then prefix it with mingw32 and mingw64 as necessary, i.e. %global pkgname sane-backends [...] Requires: mingw32-%{pkgname} = %{version}-%{release} [...] Requires: mingw64-%{pkgname} = %{version}-%{release} ) - Unowned directories: * %{mingw32/64_includedir}/sane * %{mingw32_sysconfdir}/sane.d

Should fix: - BuildRoot is not required anymore since F10 [2] - %defattr is not needed anymore - Add a comment explaining the patch - Rpmlint warnings/errors: * mingw32-sane-backends.noarch: E: incorrect-fsf-address /usr/i686-w64-mingw32/sys-root/mingw/include/sane/saneopts.h * mingw32-sane-backends.noarch: E: incorrect-fsf-address /usr/share/doc/mingw32-sane-backends-1.0.23/COPYING * mingw32-sane-backends-static.noarch: W: summary-ended-with-dot C Static version of the Scanner Access Now Easy (SANE) universal scanner interface. * mingw32-sane-backends-static.noarch: E: summary-too-long C Static version of the Scanner Access Now Easy (SANE) universal scanner interface. * mingw32-sane-backends-static.noarch: E: description-line-too-long C Static version of the Scanner Access Now Easy (SANE) universal scanner interface. * mingw32-sane-backends-static.noarch: W: no-documentation * mingw64-sane-backends.noarch: W: summary-ended-with-dot C Static version of the Scanner Access Now Easy (SANE) universal scanner interface. * mingw64-sane-backends.noarch: E: summary-too-long C Static version of the Scanner Access Now Easy (SANE) universal scanner interface. * mingw64-sane-backends.noarch: E: incorrect-fsf-address /usr/share/doc/mingw64-sane-backends-1.0.23/COPYING * mingw64-sane-backends.noarch: E: incorrect-fsf-address /usr/x86_64-w64-mingw32/sys-root/mingw/include/sane/saneopts.h * mingw64-sane-backends-static.noarch: W: summary-ended-with-dot C Static version of the Scanner Access Now Easy (SANE) universal scanner interface. * mingw64-sane-backends-static.noarch: E: summary-too-long C Static version of the Scanner Access Now Easy (SANE) universal scanner interface. * mingw64-sane-backends-static.noarch: E: description-line-too-long C Static version of the Scanner Access Now Easy (SANE) universal scanner interface. * mingw64-sane-backends-static.noarch: W: no-documentation

[1] https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/Li... [2] http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag