https://bugzilla.redhat.com/show_bug.cgi?id=858069
Bug ID: 858069 QA Contact: extras-qa@fedoraproject.org Severity: unspecified Version: rawhide Priority: unspecified CC: fedora-mingw@lists.fedoraproject.org, notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: mingw-qt5-qtlocation - Qt5 for Windows - QtLocation component Regression: --- Story Points: --- Classification: Fedora OS: Unspecified Reporter: erik-fedora@vanpienbroek.nl Type: Bug Documentation: --- Hardware: Unspecified Mount Type: --- Status: NEW Component: Package Review Product: Fedora
Spec URL: http://svn.openftd.org/svn/fedora_cross/mingw-qt5-qtlocation/mingw-qt5-qtloc... SRPM URL: http://ftd4linux.nl/contrib/mingw-qt5-qtlocation-5.0.0-0.1.beta1.fc17.src.rp... Fedora Account System Username: epienbro Description: This package contains the Qt software toolkit for developing cross-platform applications.
This is the Windows version of Qt, for use in conjunction with the Fedora Windows cross-compiler.
https://bugzilla.redhat.com/show_bug.cgi?id=858069
Erik van Pienbroek erik-fedora@vanpienbroek.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |858058, 858061
https://bugzilla.redhat.com/show_bug.cgi?id=858069
Erik van Pienbroek erik-fedora@vanpienbroek.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |858084
https://bugzilla.redhat.com/show_bug.cgi?id=858069
--- Comment #1 from Erik van Pienbroek erik-fedora@vanpienbroek.nl --- Updated Spec URL: http://svn.openftd.org/svn/fedora_cross/mingw-qt5-qtlocation/mingw-qt5-qtloc... Updated SRPM URL: http://build1.openftd.org/fedora-cross/src/mingw-qt5-qtlocation-5.0.0-0.2.be...
* Mon Nov 12 2012 Erik van Pienbroek epienbro@fedoraproject.org - 5.0.0-0.2.beta1.git20121112.8e6b5b08 - Update to 20121112 snapshot (rev 8e6b5b08) - Rebuild against latest mingw-qt5-qtbase - Dropped pkg-config rename hack as it's unneeded now
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858069
Bug 858069 depends on bug 858058, which changed state.
Bug 858058 Summary: Review Request: mingw-qt5-qtbase - Qt5 for Windows - QtBase component https://bugzilla.redhat.com/show_bug.cgi?id=858058
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858069
--- Comment #2 from Erik van Pienbroek erik-fedora@vanpienbroek.nl --- Updated Spec URL: http://svn.nntpgrab.nl/svn/fedora_cross/mingw-qt5-qtlocation/mingw-qt5-qtloc... Updated SRPM URL: http://koji.vanpienbroek.nl/kojifiles/packages/mingw-qt5-qtlocation/5.0.0/0.... Koji scratch build: https://koji.vanpienbroek.nl/koji/buildinfo?buildID=135
* Fri May 10 2013 Erik van Pienbroek epienbro@fedoraproject.org - 5.0.0-0.4.git20130510.f2840834 - Update to 20130510 snapshot (rev f2840834)
* Fri Jan 11 2013 Erik van Pienbroek epienbro@fedoraproject.org - 5.0.0-0.3.git20121112.ac83b242 - Update to ac83b242 snapshot (fixes compatibility with Qt 5.0.0 Final)
https://bugzilla.redhat.com/show_bug.cgi?id=858069
Bug 858069 depends on bug 858061, which changed state.
Bug 858061 Summary: Review Request: mingw-qt5-qt3d - Qt5 for Windows - Qt3d component https://bugzilla.redhat.com/show_bug.cgi?id=858061
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=858069
--- Comment #3 from Erik van Pienbroek erik-fedora@vanpienbroek.nl --- Updated Spec URL: http://svn.nntpgrab.nl/svn/fedora_cross/mingw-qt5-qtlocation/mingw-qt5-qtloc... Updated SRPM URL: http://koji.vanpienbroek.nl/kojifiles/packages/mingw-qt5-qtlocation/5.0.0/0.... Koji scratch build: https://koji.vanpienbroek.nl/koji/buildinfo?buildID=165
* Thu Jul 18 2013 Erik van Pienbroek epienbro@fedoraproject.org - 5.0.0-0.5.git20130510.f2840834 - Make sure the syncqt tool is run because we're using a git snapshot
https://bugzilla.redhat.com/show_bug.cgi?id=858069
Michael Cronenworth mike@cchtml.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |mike@cchtml.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=858069
--- Comment #4 from Michael Cronenworth mike@cchtml.com --- Erik, you list a Patch0, but do not apply it. Is it still necessary?
Also, the tarballs do not checksum, but I'm guessing this is an artifact of the web site used to grab it, which is auto-generating it.
https://bugzilla.redhat.com/show_bug.cgi?id=858069
--- Comment #5 from Michael Cronenworth mike@cchtml.com --- Ignore my comment about the tarball. I haven't used Qt's system before and noticed it told me to "try later". Redownloading the tarball gave me a valid file.
https://bugzilla.redhat.com/show_bug.cgi?id=858069
--- Comment #6 from Erik van Pienbroek erik-fedora@vanpienbroek.nl --- You're correct about the patch. It's something which needs to be removed.
Updated Spec URL: http://svn.nntpgrab.nl/svn/fedora_cross/mingw-qt5-qtlocation/mingw-qt5-qtloc... Updated SRPM URL: http://koji.vanpienbroek.nl/kojifiles/packages/mingw-qt5-qtlocation/5.0.0/0.... Koji scratch build: https://koji.vanpienbroek.nl/koji/buildinfo?buildID=168
* Fri Aug 02 2013 Erik van Pienbroek epienbro@fedoraproject.org - 5.0.0-0.6.git20130510.f2840834 - Dropped reference to unused patch - Don't bundle .dll.debug files in the main packages
https://bugzilla.redhat.com/show_bug.cgi?id=858069
Michael Cronenworth mike@cchtml.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #7 from Michael Cronenworth mike@cchtml.com --- $ rpmlint Downloads/mingw-qt5-qtlocation-5.0.0-0.6.git20130510.f2840834.fc20.src.rpm mingw-qt5-qtlocation.src: E: unknown-key GPG#9b393ae8 mingw-qt5-qtlocation.src:26: W: macro-in-comment %{qt_module} mingw-qt5-qtlocation.src:26: W: macro-in-comment %{snapshot_rev} mingw-qt5-qtlocation.src:26: W: macro-in-comment %{qt_module} mingw-qt5-qtlocation.src:26: W: macro-in-comment %{snapshot_rev} mingw-qt5-qtlocation.src: W: invalid-url Source0: qt5-qtlocation-f2840834.tar.gz 1 packages and 0 specfiles checked; 1 errors, 6 warnings.
$ rpmlint Downloads/mingw-qt5-qtlocation.spec Downloads/mingw-qt5-qtlocation.spec:26: W: macro-in-comment %{qt_module} Downloads/mingw-qt5-qtlocation.spec:26: W: macro-in-comment %{snapshot_rev} Downloads/mingw-qt5-qtlocation.spec:26: W: macro-in-comment %{qt_module} Downloads/mingw-qt5-qtlocation.spec:26: W: macro-in-comment %{snapshot_rev} Downloads/mingw-qt5-qtlocation.spec: W: invalid-url Source0: qt5-qtlocation-f2840834.tar.gz 0 packages and 1 specfiles checked; 0 errors, 5 warnings.
+ OK ! needs attention
+ The package is named according to Fedora MinGW packaging guidelines + The spec file name matches the base package name. + The package meets the Packaging Guidelines + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The license field in the spec file matches the actual license n/a The stated license is the same as the one for the corresponding native Fedora package + The package contains the license file (COPYING.lib) + Spec file is written in American English + Spec file is legible + Upstream sources match sources in the srpm. md5sum: 2bef598a14cbff37021305dda6f0c550 Downloads/qt5-qtlocation-f2840834.tar.gz 2bef598a14cbff37021305dda6f0c550 SOURCES/qt5-qtlocation-f2840834.tar.gz + The package builds in koji n/a ExcludeArch bugs filed + BuildRequires look sane n/a locale handling n/a ldconfig in %post and %postun + Package does not bundle copies of system libraries n/a Package isn't relocatable + Package owns all directories it creates + No duplicate files in %files + Permissions are properly set + Consistent use of macros + The package must contain code or permissible content n/a Large documentation files should go in -doc subpackage + Files marked %doc should not affect package n/a Header files should be in -devel Not applicable to MinGW packages. n/a Static libraries should be in -static n/a Library files that end in .so must go in a -devel package n/a -devel must require the fully versioned base + Packages must not contain libtool .la files n/a Packages containing GUI apps must include %{name}.desktop file + Directory ownership sane + Filenames are valid UTF-8
----- Summary: - Looks good!
APPROVED
https://bugzilla.redhat.com/show_bug.cgi?id=858069
Erik van Pienbroek erik-fedora@vanpienbroek.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #8 from Erik van Pienbroek erik-fedora@vanpienbroek.nl --- Thanks for the review!
New Package SCM Request ======================= Package Name: mingw-qt5-qtlocation Short Description: Qt5 for Windows - QtLocation component Owners: epienbro Branches: f18 f19 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=858069
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=858069
--- Comment #9 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=858069
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=858069
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- mingw-qt5-qtlocation-5.0.0-0.6.git20130510.f2840834.fc18,mingw-qt5-qtsensors-5.1.0-1.fc18,mingw-qt5-qt3d-5.0.0-0.5.git20130510.0158ce78.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/mingw-qt5-qtlocation-5.0.0-0.6.git20...
https://bugzilla.redhat.com/show_bug.cgi?id=858069
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- mingw-qt5-qtlocation-5.0.0-0.6.git20130510.f2840834.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/mingw-qt5-qtlocation-5.0.0-0.6.git20...
https://bugzilla.redhat.com/show_bug.cgi?id=858069
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- mingw-qt5-qtlocation-5.0.0-0.6.git20130510.f2840834.fc19 has been pushed to the Fedora 19 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=858069
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |mingw-qt5-qtlocation-5.0.0- | |0.6.git20130510.f2840834.fc | |19 Resolution|--- |ERRATA Last Closed| |2013-08-12 13:59:31
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- mingw-qt5-qtlocation-5.0.0-0.6.git20130510.f2840834.fc19 has been pushed to the Fedora 19 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=858069
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|mingw-qt5-qtlocation-5.0.0- |mingw-qt5-qtlocation-5.0.0- |0.6.git20130510.f2840834.fc |0.6.git20130510.f2840834.fc |19 |18
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- mingw-qt5-qtlocation-5.0.0-0.6.git20130510.f2840834.fc18, mingw-qt5-qtsensors-5.1.0-1.fc18, mingw-qt5-qt3d-5.0.0-0.5.git20130510.0158ce78.fc18 has been pushed to the Fedora 18 stable repository.