https://bugzilla.redhat.com/show_bug.cgi?id=858061

Erik van Pienbroek erik-fedora@vanpienbroek.nl changed:

What |Removed |Added ---------------------------------------------------------------------------- Depends On| |858058, 858064, 858074

https://bugzilla.redhat.com/show_bug.cgi?id=858061

--- Comment #1 from Erik van Pienbroek erik-fedora@vanpienbroek.nl --- Updated Spec URL: http://svn.openftd.org/svn/fedora_cross/mingw-qt5-qt3d/mingw-qt5-qt3d.spec Updated SRPM URL: http://build1.openftd.org/fedora-cross/src/mingw-qt5-qt3d-5.0.0-0.2.beta1.gi...

* Sun Nov 11 2012 Erik van Pienbroek epienbro@fedoraproject.org - 5.0.0-0.2.beta1.git20121111.e4d3ccac - Update to 20121111 snapshot (rev e4d3ccac) - Rebuild against latest mingw-qt5-qtbase - Dropped pkg-config rename hack as it's unneeded now

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858061

Bug 858061 depends on bug 858074, which changed state.

Bug 858074 Summary: Review Request: mingw-qt5-qtquick1 - Qt5 for Windows - QtQuick1 component https://bugzilla.redhat.com/show_bug.cgi?id=858074

What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858061

--- Comment #2 from Erik van Pienbroek erik-fedora@vanpienbroek.nl --- Updated Spec URL: http://svn.nntpgrab.nl/svn/fedora_cross/mingw-qt5-qt3d/mingw-qt5-qt3d.spec Updated SRPM URL: http://koji.vanpienbroek.nl/kojifiles/packages/mingw-qt5-qt3d/5.0.0/0.4.git2... Koji scratch build: https://koji.vanpienbroek.nl/koji/buildinfo?buildID=138

* Fri May 10 2013 Erik van Pienbroek epienbro@fedoraproject.org - 5.0.0-0.4.git20130510.0158ce78 - Update to 20130510 snapshot (rev 0158ce78)

* Sat Jan 12 2013 Erik van Pienbroek epienbro@fedoraproject.org - 5.0.0-0.3.git20121111.e4d3ccac - Fix filelist

https://bugzilla.redhat.com/show_bug.cgi?id=858061

greg.hellings@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+

--- Comment #4 from greg.hellings@gmail.com --- (In reply to greg.hellings from comment #3) Whoops, submitted the review template instead of the review! Let me try that again...

$ rpmlint *.spec mingw-qt5-qt3d.spec:26: W: macro-in-comment %{qt_module} mingw-qt5-qt3d.spec:26: W: macro-in-comment %{snapshot_rev} mingw-qt5-qt3d.spec:26: W: macro-in-comment %{qt_module} mingw-qt5-qt3d.spec:26: W: macro-in-comment %{snapshot_rev} mingw-qt5-qt3d.spec: W: invalid-url Source0: qt5-qt3d-0158ce78.tar.gz 0 packages and 1 specfiles checked; 0 errors, 5 warnings.

$ rpmlint mingw-qt5-qt3d-5.0.0-0.4.git20130510.0158ce78.fc20.src.rpm mingw-qt5-qt3d.src: E: unknown-key GPG#9b393ae8 mingw-qt5-qt3d.src:26: W: macro-in-comment %{qt_module} mingw-qt5-qt3d.src:26: W: macro-in-comment %{snapshot_rev} mingw-qt5-qt3d.src:26: W: macro-in-comment %{qt_module} mingw-qt5-qt3d.src:26: W: macro-in-comment %{snapshot_rev} mingw-qt5-qt3d.src: W: invalid-url Source0: qt5-qt3d-0158ce78.tar.gz 1 packages and 0 specfiles checked; 1 errors, 5 warnings.

$ rpmlint results_mingw-qt5-qt3d/5.0.0/0.4.git20130510.0158ce78.fc18/mingw{32,64}* mingw32-qt5-qt3d-debuginfo.noarch: E: debuginfo-without-sources mingw64-qt5-qt3d-debuginfo.noarch: E: debuginfo-without-sources 4 packages and 0 specfiles checked; 2 errors, 0 warnings.

$ rpm -q --requires mingw32-qt5-qt3d rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 mingw32-crt mingw32-filesystem >= 83 mingw32(kernel32.dll) mingw32(libgcc_s_sjlj-1.dll) mingw32(libglesv2.dll) mingw32(libstdc++-6.dll) mingw32(msvcrt.dll) mingw32(qt53d.dll) mingw32(qt53dquick.dll) mingw32(qt5core.dll) mingw32(qt5gui.dll) mingw32(qt5network.dll) mingw32(qt5opengl.dll) mingw32(qt5qml.dll) mingw32(qt5quick.dll) mingw32(qt5widgets.dll) mingw32(user32.dll) rpmlib(PayloadIsXz) <= 5.2-1

$ rpm -q --requires mingw64-qt5-qt3d rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(CompressedFileNames) <= 3.0.4-1 mingw64-crt mingw64-filesystem >= 83 mingw64(kernel32.dll) mingw64(libgcc_s_sjlj-1.dll) mingw64(libglesv2.dll) mingw64(libstdc++-6.dll) mingw64(msvcrt.dll) mingw64(qt53d.dll) mingw64(qt53dquick.dll) mingw64(qt5core.dll) mingw64(qt5gui.dll) mingw64(qt5network.dll) mingw64(qt5opengl.dll) mingw64(qt5qml.dll) mingw64(qt5quick.dll) mingw64(qt5widgets.dll) mingw64(user32.dll) rpmlib(PayloadIsXz) <= 5.2-1

$ rpm -q --provides mingw32-qt5-qt3d mingw32-qt5-qt3d = 5.0.0-0.4.git20130510.0158ce78.fc18 mingw32(qt53d.dll) mingw32(qt53dquick.dll) mingw32(qthreedqmlplugin.dll)

$ rpm -q --provides mingw64-qt5-qt3d mingw64-qt5-qt3d = 5.0.0-0.4.git20130510.0158ce78.fc18 mingw64(qt53d.dll) mingw64(qt53dquick.dll) mingw64(qthreedqmlplugin.dll)

+ OK ! Needs to be looked into / Not applicable

[+] Compliant with generic Fedora Packaging Guidelines [+] Source package name is prefixed with 'mingw-' [+] Spec file starts with %{?mingw_package_header} [+] BuildRequires: mingw32-filesystem >= 95 is in the .spec file [+] BuildRequires: mingw64-filesystem >= 95 is in the .spec file [+] Spec file contains %package sections for both mingw32 and mingw64 packages [+] Binary mingw32 and mingw64 packages are noarch [+] Spec file contains %{?mingw_debug_package} after the %description section [+] Uses one of the macros %mingw_configure, %mingw_cmake, %mingw_cmake_kde4 or %mingw_qmake_qt5 to configure the package [+] Uses the macro %mingw_make to build the package [+] Uses the macro %mingw_make to install the package [+] If package contains translations, the %mingw_find_lang macro must be used [+] No binary package named mingw-$pkgname is generated [+] Libtool .la files are not bundled [+] .def files are not bundled [+] Man pages which duplicate native package are not bundled [+] Info files which duplicate native package are not bundled [+] Provides of the binary mingw32 and mingw64 packages are equal [+] Requires of the binary mingw32 and mingw64 packages are equal

Passes muster with the same types of scenarios as other Qt5 packages.

https://bugzilla.redhat.com/show_bug.cgi?id=858061

Jon Ciesla limburgher@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? | Flags| |fedora-cvs+

https://bugzilla.redhat.com/show_bug.cgi?id=858061

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED

https://bugzilla.redhat.com/show_bug.cgi?id=858061

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA

--- Comment #8 from Fedora Update System updates@fedoraproject.org --- mingw-qt5-qtsensors-5.0.0-0.5.git20130510.ceec1eda.fc19, mingw-qt5-qt3d-5.0.0-0.4.git20130510.0158ce78.fc19 has been pushed to the Fedora 19 testing repository.