2:44 p.m.
Hi,
Using the defined DATADIR from datadir.h mingw will croak on compile. My suggestion would
be to at least rename DATADIR within datadir.h to something else not referenced:
src/Makefile.am
datadir.h: $(top_builddir)/config.status
-------echo '#define DATADIR "$(datadir)"' >
datadir.h
objidl.h
typedef enum tagDATADIR>{
-------DATADIR_GET=1,
-------DATADIR_SET
} DATADIR;
Any suggestions on how we want to approach this?
Thanks!
--
__ __
.-----.| |_.-----.| |--.-----.-----.
|__ --|| _| _ || <| -__|__ --|
|_____||____|_____||__|__|_____|_____|
.----------------------------------.
( ajs(a)redhat.com || 919.754.4187 )
`----------------------------------'
3:16 p.m.
On Mon, 2010-07-19 at 15:44 -0400, Adam Stokes wrote:
Using the defined DATADIR from datadir.h mingw will croak on
compile.
My suggestion would be to at least rename DATADIR within datadir.h to
something else not referenced:
src/Makefile.am
datadir.h: $(top_builddir)/config.status
>-------echo '#define DATADIR "$(datadir)"' > datadir.h
objidl.h
typedef enum tagDATADIR>{
>-------DATADIR_GET=1,
>-------DATADIR_SET
} DATADIR;
Any suggestions on how we want to approach this?
We should just replace DATADIR with NETCF_DATADIR everywhere to avoid
the clash.
David
3:24 p.m.
We should just replace DATADIR with NETCF_DATADIR everywhere to
avoid
the clash.
David
Ok. One other thing I noticed was there is a 'try' shell script that actually does
the export
of NETCF_DATADIR. I can only guess this is not how we want to accomplish this.. should I
alter
the makefile.am to update the DATADIR entry to NETCF_DATADIR and call that define wherever
I see
DATADIR?
Thanks
--
__ __
.-----.| |_.-----.| |--.-----.-----.
|__ --|| _| _ || <| -__|__ --|
|_____||____|_____||__|__|_____|_____|
.----------------------------------.
( ajs(a)redhat.com || 919.754.4187 )
`----------------------------------'
1:49 p.m.
On Mon, 2010-07-19 at 16:24 -0400, Adam Stokes wrote:
> We should just replace DATADIR with NETCF_DATADIR everywhere to avoid
> the clash.
>
> David
>
Ok. One other thing I noticed was there is a 'try' shell script that actually
does the export
of NETCF_DATADIR. I can only guess this is not how we want to accomplish this.. should I
alter
the makefile.am to update the DATADIR entry to NETCF_DATADIR and call that define
wherever I see
DATADIR?
Yes, these are two slightly different things:
1. DATADIR (which we'll rename to NETCF_DATADIR) captures the data
dir configured at build time, hence is a #define and gets
hardcoded in the binary
2. the environment variable NETCF_DATADIR can be used to override
the hardcoded data dir at runtime (e.g., for testing)
David
5036
days inactive
5037
days old
netcf-devel@lists.fedorahosted.org
3 comments
2 participants
participants (2)
-
Adam Stokes -
David Lutterkort