The the Node.js guidelines say about Source0 [1]:
"The canonical method for shipping most node modules is tarballs from
the npm registry"
and
"This method [PP: tarbals from npm] should be preferred to using
checkouts from git or automatically generated tarballs from GitHub."
But I think that in following cases it would be better to use sources
from the upstream project:
1) When the license is not included in NPM but is in upstream project.
o Because we are not supposed to ship the license separate from the
sources.
2) When the tests are not included.
o In this case we need to download the sources from NPM and from
upstream project, which seems redundant and a waste of work.
3) When NPM content is generated and source files are not in NPM.
o This would mean to download sources from NPM and upstream project,
delete the NPM sources in prep and generate the files again.
Are there good reason to enforce the use of NPM sources which I am
missing? What is your opinion?
I would like to suggest to ad those three exceptions to the guidelines.
Piotr
[1]:
https://fedoraproject.org/wiki/Packaging:Node.js?rd=Node.js/Packagers#Using…
On 10/21/2016 08:46 AM, Peter Robinson wrote:
> On Fri, Oct 21, 2016 at 1:38 PM, Dan Horák <dan(a)danny.cz> wrote:
>> Hi all,
>>
>> seems we weren't paying enough attention to the nodejs NEWS, but recent
>> version(s) support also s390x. A proof is in
>> http://s390.koji.fedoraproject.org/koji/taskinfo?taskID=2380695
>> with just the ExclusiveArch tag removed in the spec.
>>
>> What should be the next steps?
>
> So we not support it across all Fedora non experimental arches and all
> RHEL arches. It would be useful to drop Exclusive (or maybe move to
> Exclude for the experimental arches) options as least for EPEL as that
> means we can build it across all those arches without abusing the
> macro stuff.
>
> Thoughts?
CCing the nodejs list.
Sorry, I'm not sure exactly what you're suggesting.
Right now, we have the %nodejs_arches macro that's used by every nodejs package
in Fedora. E.g.:
ExclusiveArch: %{nodejs_arches} noarch
Dropping the ExclusiveArch from every nodejs-* package would be a pretty
complicated change to make. Easier would be to just fix %{nodejs_arches} in
redhat-rpm-config and kick off a mass-rebuild.
That said, you're right that we don't control that package in EPEL, so if we
want to carry it on additional architectures there, changing the ExclusiveArch
could be useful, if painful.
Hi,
I am using Haraka https://github.com/haraka/Haraka. After the upgrade to nodejs 6.7.0 TLS stopped working. Everytime a client started using TLS, haraka crashed with a segmentation fault. I am using a certificate from Let's Encrypt.
I don't know if it is an error in nodejs or in the way haraka is using it. In the former case, the following information from the core dump may be helpful:
Core was generated by `node /usr/bin/haraka -c /root/haraka-test'.
Program terminated with signal 11, Segmentation fault.
#0 0x00007f39c2e8dce0 in asn1_enc_restore (len=len@entry=0x7fff46fb1d74, out=out@entry=0x0, pval=pval@entry=0x1eec3f0, it=it@entry=0x7f39c3150480 )
at tasn_utl.c:190
190 if (!enc || enc->modified)
(gdb) bt
#0 0x00007f39c2e8dce0 in asn1_enc_restore (len=len@entry=0x7fff46fb1d74, out=out@entry=0x0, pval=pval@entry=0x1eec3f0, it=it@entry=0x7f39c3150480 )
at tasn_utl.c:190
#1 0x00007f39c2e8af3b in ASN1_item_ex_i2d (pval=pval@entry=0x1eec3f0, out=out@entry=0x0, it=0x7f39c3150480 , tag=tag@entry=-1, aclass=aclass@entry=0)
at tasn_enc.c:202
#2 0x00007f39c2e8b3e1 in asn1_template_ex_i2d (pval=0x1eec3f0, out=out@entry=0x0, tt=tt@entry=0x7f39c3156760 , tag=tag@entry=-1, iclass=iclass@entry=0)
at tasn_enc.c:413
#3 0x00007f39c2e8b1bb in ASN1_item_ex_i2d (pval=pval@entry=0x7fff46fb1ed8, out=out@entry=0x0, it=it@entry=0x7f39c3150400 , tag=16, tag@entry=-1,
aclass=aclass@entry=0) at tasn_enc.c:231
#4 0x00007f39c2e8b2bf in asn1_item_flags_i2d (val=val@entry=0x1eec3f0, out=out@entry=0x0, it=it@entry=0x7f39c3150400 , flags=flags@entry=0) at tasn_enc.c:122
#5 0x00007f39c2e8b367 in ASN1_item_i2d (val=val@entry=0x1eec3f0, out=out@entry=0x0, it=it@entry=0x7f39c3150400 ) at tasn_enc.c:91
#6 0x00007f39c2e868cc in i2d_X509 (a=a@entry=0x1eec3f0, out=out@entry=0x0) at x_x509.c:141
#7 0x00007f39c319a7bd in ssl3_add_cert_to_buf (buf=0x1e41510, l=0x7fff46fb1f78, x=0x1eec3f0) at s3_both.c:335
#8 0x00007f39c319ae93 in ssl3_output_cert_chain (s=s@entry=0x1eedd40, x=) at s3_both.c:405
#9 0x00007f39c318e645 in ssl3_send_server_certificate (s=s@entry=0x1eedd40) at s3_srvr.c:3398
#10 0x00007f39c318fabd in ssl3_accept (s=0x1eedd40) at s3_srvr.c:417
#11 0x00007f39c319d368 in ssl23_accept (s=0x1eedd40) at s23_srvr.c:210
#12 0x0000000000e55e95 in node::crypto::Connection::ClearOut (args=...) at ../src/node_crypto.cc:3113
#13 0x0000000000729644 in v8::internal::FunctionCallbackArguments::Call (this=this@entry=0x7fff46fb22c0,
f=f@entry=0xe55c80 node::crypto::Connection::ClearOut(v8::FunctionCallbackInfo<v8::Value const&)>) at ../deps/v8/src/api-arguments.cc:16
#14 0x00000000007831e4 in v8::internal::(anonymous namespace)::HandleApiCallHelper (isolate=isolate@entry=0x1d2f7a0, args=...) at ../deps/v8/src/builtins.cc:4322
#15 0x00000000007839ce in v8::internal::Builtin_Impl_HandleApiCall (args=..., isolate=isolate@entry=0x1d2f7a0) at ../deps/v8/src/builtins.cc:4340
#16 0x0000000000783b7e in v8::internal::Builtin_HandleApiCall (args_length=, args_object=0x7fff46fb24c0, isolate=0x1d2f7a0) at ../deps/v8/src/builtins.cc:4337
#17 0x00001498485092a7 in ?? ()
#18 0x0000000000000000 in ?? ()
Regards
Werner
On 13/10/16 10:23, notifications(a)fedoraproject.org wrote:
> Package: nodejs-6.8.0-108.fc26
> Status: failed
> Built by: zvetlik
> ID: 809331
> Started: Thu, 13 Oct 2016 09:11:38 UTC
> Finished: Thu, 13 Oct 2016 09:23:09 UTC
>
> Closed tasks:
> -------------
> Task 16073443 on buildvm-aarch64-18.arm.fedoraproject.org
> Task Type: build (noarch)
> Link: https://koji.fedoraproject.org/koji/taskinfo?taskID=16073443
>
> error building package (arch i686), mock exited with status 1; see build.log for more information
This is fallout from OpenSSL 1.1 being in rawhide now.
Upstream PR at https://github.com/nodejs/node/pull/8491 but looks like
it isn't merged yet...
Tom
--
Tom Hughes (tom(a)compton.nu)
http://compton.nu/