This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1284/

Autoscan finished OK

Scanned reviews: 1284

- scanbot


On November 25th, 2013, 12:19 p.m. UTC, Radek Novacek wrote:

Review request for OpenLMI Developers.
By Radek Novacek.

Updated Nov. 25, 2013, 12:19 p.m.

Repository: openlmi-networking

Description

Allow to use SlaveSettingData for activation of slave settings

Bridge and bond slaves now can be activated either referencing
MasterSettingData or SlaveSettingData. SlaveSettingData is preferred
(and documented) way to do it.

Tests has been added to check both ways.

Diffs

  • doc/admin/usage.rst (7975bea8b995809e93810c6575996a03618ea15c)
  • src/LMI_IPConfigurationServiceProvider.c (64f39f60d01d20c1857d10709ee74295a0b7a17a)
  • src/connection.c (64529ef5fdae75896a39115043f5fea527c115bd)
  • src/port_nm.c (31002bf23b3f2b2d260e040c4efc9ac922ea82f7)
  • test/test_bonding.py (725abeadb4fd95a11d4b5c91caaf1df429e7722d)
  • test/test_bridging.py (d91b9d3d1fff9617b4cd910d1c840591deff9bff)

View Diff