https://bugzilla.redhat.com/show_bug.cgi?id=1267340
Vít Ondruch vondruch@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #4 from Vít Ondruch vondruch@redhat.com --- (In reply to Ilya Gradina from comment #3)
- updated to version 0.4.0
Thx
- removed from BuildRequires rubygem-cucumber(with cucumber not pass the
tests).
Actually you can run the cucumber test suite. This is the diff I tested:
``` --- rubygem-minitest-around.spec 2016-11-07 14:50:38.050724282 +0100 +++ rubygem-minitest-around.spec.back 2016-11-07 14:49:26.946770370 +0100 @@ -11,6 +11,7 @@ BuildRequires: ruby(release) BuildRequires: rubygems-devel BuildRequires: rubygem(minitest) +BuildRequires: rubygem(cucumber) BuildArch: noarch
%description @@ -54,6 +55,8 @@ pushd .%{gem_instdir} sed -i "/require 'bundler/ s/^/#/" test/helper.rb ruby -Ilib -e 'Dir.glob "./test/*_test.rb", &method(:require)' + + RUBYOPT=-Ilib cucumber --tag ~@todo --tag ~@rspec popd
%files ```
There are excluded some parts, but these corresponds to the Rakefile [1].
And actually, there are also test/*_spec.rb files which could be executed, so the final patch according to my testing should be:
``` --- rubygem-minitest-around.spec.orig 2016-11-07 15:05:01.312144585 +0100 +++ rubygem-minitest-around.spec 2016-11-07 15:04:43.281157338 +0100 @@ -11,6 +11,7 @@ BuildRequires: ruby(release) BuildRequires: rubygems-devel BuildRequires: rubygem(minitest) +BuildRequires: rubygem(cucumber) BuildArch: noarch
%description @@ -53,7 +54,9 @@ %check pushd .%{gem_instdir} sed -i "/require 'bundler/ s/^/#/" test/helper.rb - ruby -Ilib -e 'Dir.glob "./test/*_test.rb", &method(:require)' + RUBYOPT=-Ilib ruby -e 'Dir.glob "./test/*_{test,spec}.rb", &method(:require)' + + RUBYOPT=-Ilib cucumber --tag ~@todo --tag ~@rspec popd
%files ```
The RUBYOPT export is required, -Ilib is not enough, since there are spawned some testing sub processes. In upstream, Bundler takes care about it, but without Bundler, we have to workaround it.
Otherwise the package looks sane => APPROVED but please make sure to enable as much tests as possible.
[1] https://github.com/splattael/minitest-around/blob/master/Rakefile#L37