https://bugzilla.redhat.com/show_bug.cgi?id=1919347
Vladisalv Kazakov vpackager@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |vpackager@gmail.com
--- Comment #2 from Vladisalv Kazakov vpackager@gmail.com --- Hello. Thanks for bringing your package to Fedora! I will make a couple of comments on your spec while you wait for a actual reviewer.
It's better to start versioning your libraries. As the upstream maintainer you can do that. Please, see: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_downstream_so_na...
Release: 0%{?dist}
Release: tag starting with 1 (never 0).
ExclusiveArch: x86_64 aarch64
What about other arches? Crash supports other arches too. As stated in Packaging Guidlines, "Fedora packagers should make every effort to support all primary architectures".
BuildRequires: crash-devel >= 5.1.5
All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines. You need at least gcc.
make -C src -f gcore.mk
Whenever possible, invocations of make should be done as %make_build.
%defattr(-,root,root)
The %defattr directive in the %files list SHOULD ONLY be used when setting a non-default value, or to reset to the default value after having set a non-default value.
%doc COPYING
It's more license than doc, so you can use %license here. You can set REAMDE as %doc for example.