Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: jday - A simple command to convert calendar dates to julian dates
https://bugzilla.redhat.com/show_bug.cgi?id=427342
------- Additional Comments From panemade@gmail.com 2008-01-03 04:47 EST ------- You need some SPEC cleanups and follow packaging guidelines as per given at http://fedoraproject.org/wiki/Packaging/Guidelines
1) change source URL from http://jaist.dl.sourceforge.net/sourceforge/jday/jday-2.4.tar.gz to http://downloads.sourceforge.net/%%7Bname%7D/%%7Bname%7D-%%7Bversion%7D.tar.... check more on it http://fedoraproject.org/wiki/Packaging/SourceURL
2) SHOULD follow macros. READ more on it http://fedoraproject.org/wiki/Packaging/Guidelines#head-e205651a2c97a6857ab7...
3) ldconfig usage should be as per given http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-d0dbcb7eec276...
4) you need to add -devel subpackage which includes header files and .so files
provide updated package links, updating release tag and adding correct changelog of what change you did in SPEC.