https://bugzilla.redhat.com/show_bug.cgi?id=1919347
d.hatayama@fujitsu.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(d.hatayama@fujits | |u.com) |
--- Comment #11 from d.hatayama@fujitsu.com --- Nathan,
Thanks for your reviewing.
(In reply to Nathan Scott from comment #10)
Hi Hatayama,
I've completed the first round of 'formal' review now. In addition to the docs topic discussed earlier (mentioned below in the review re %doc files,
As I mentioned before, I don't think I add README in the rpm package for the time being.
up to you whether you want to include that README) there's one other small issue worth fixing, i.e.
No package seems to own the crash/extensions directory?
$ rpm -qf /usr/lib64/crash file /usr/lib64/crash is not owned by any package
You can add ownership of these to your new package (it is OK if multiple packages own these directories too BTW - although ideally 'crash' itself would have provided them I guess) - by adding the following to %files ..
%dir %{_libdir}/crash %dir %{_libdir}/crash/extensions
I've added these lines just as indicated.
Here's the update:
Spec URL: http://raw.githubusercontent.com/d-hatayama/crash-modules-fedora-package-rev... SRPM URL: https://github.com/d-hatayama/crash-modules-fedora-package-review/raw/master...
Thanks. HATAYAMA, Daisuke