Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221349
Summary: Review Request: doodle - tool to quickly search the documents on a computer Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: karlikt@gmail.com QAContact: fedora-package-review@redhat.com
Spec URL: http://karlik.nonlogic.org/doodle/doodle.spec SRPM URL: http://karlik.nonlogic.org/doodle/doodle-0.6.6-1.src.rpm Description: Doodle is a tool to quickly search the documents on a computer. Doodle builds an index using meta-data contained in the documents and allows fast searches on the resulting database. Doodle uses libextractor to support obtaining meta-data from various file-formats. The database used by doodle is a suffix tree, resulting in fast lookups. Doodle supports approximate searches.
Two things to reviewers: 1. I had to comment _smp_mflags, because when this flag is ON, the rpm does not build. I sent mail to author of this program. 2. To build doodle need libextractor-devel. This is not in fedora-extras, but the Review request is bug #214087
I am not sponsored.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: doodle - tool to quickly search the documents on a computer
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221349
karlikt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn| |214087 OtherBugsDependingO| |177841 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: doodle - tool to quickly search the documents on a computer
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221349
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@ioa.s.u-tokyo.ac.jp
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-01-04 13:02 EST ------- Well, actually I requested doodle. Then:
Your package does not provide doodled (i.e. rebuilding your srpm does not create /usr/bin/doodled). The homepage (1) says that doodled requires fam, which is replaced by gamin. The spec file provided by dag.wieers.com (2) seems that doodled can be used with the help of gamin, so please modify your spec file to use gamin so that doodled can be used.
Also, accroding to "Hints for system administrators" on the homepage doodled can be run as a daemon. In this case, providing initscript service scripts (usually under /etc/rc.d/init.d ) is recommended. Would you provide it?
1. http://gnunet.org/doodle/ 2. http://dag.wieers.com/packages/doodle/doodle.spec
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: doodle - tool to quickly search the documents on a computer
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221349
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-01-04 13:18 EST ------- Created an attachment (id=144826) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=144826&action=vie...) Mock build log of doodle-0.6.6-1
Mockbuild log of doodle-0.6.6-1 on FC-devel i386. You can see that /usr/bin/doodled is not installed.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: doodle - tool to quickly search the documents on a computer
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221349
------- Additional Comments From karlikt@gmail.com 2007-01-04 17:29 EST ------- (In reply to comment #1)
Well, actually I requested doodle. Then:
Your package does not provide doodled (i.e. rebuilding your srpm does not create /usr/bin/doodled). The homepage (1) says that doodled requires fam, which is replaced by gamin. The spec file provided by dag.wieers.com (2) seems that doodled can be used with the help of gamin, so please modify your spec file to use gamin so that doodled can be used.
Fixed
Also, accroding to "Hints for system administrators" on the homepage doodled can be run as a daemon. In this case, providing initscript service scripts (usually under /etc/rc.d/init.d ) is recommended. Would you provide it?
The initscript is a problem. The doodled need argument which directory it monitors and the doodled can be run more then once in the same time. The doodled in initscript can be run with argument i.e. "/home", but the progam is limited to monitoring less than 1024 directories for changes, so the "/home" sometimes can be too big. I think it must be discussed.
New files: Spec URL: http://karlik.nonlogic.org/doodle/doodle.spec SRPM URL: http://karlik.nonlogic.org/doodle/doodle-0.6.6-2.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: doodle - tool to quickly search the documents on a computer
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221349
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |mtasaka@ioa.s.u-tokyo.ac.jp OtherBugsDependingO|163776 |163778 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: doodle - tool to quickly search the documents on a computer
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221349
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-01-05 13:08 EST ------- I will review this later.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: doodle - tool to quickly search the documents on a computer
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221349
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-01-06 02:28 EST ------- Well, = now mockbuild for conditional dependency is okay = License is "actually" GPL = Other things are all okay. = Your other review requests seems good from a very quick check.
---------------------------------------------------------- This package (doodle) is APPROVED by me. ----------------------------------------------------------
Please step forward according to http://fedoraproject.org/wiki/Extras/Contributors . At a stage, I should receive a main which notices that you need a sponsor. Then I will SPONSOR YOU.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: doodle - tool to quickly search the documents on a computer
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221349
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-01-06 07:59 EST ------- Oh.. I just noticed that you already requested for sponsorship.
Now I am sponsoring you and you should receive a mail.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: doodle - tool to quickly search the documents on a computer
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221349
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|177841 | nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: doodle - tool to quickly search the documents on a computer
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221349
karlikt@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From karlikt@gmail.com 2007-01-07 08:08 EST ------- (In reply to comment #6)
Oh.. I just noticed that you already requested for sponsorship.
Now I am sponsoring you and you should receive a mail.
Thank You for sponsorship. The package was built correctly on buildsys (all arch, devel), so I can close this request.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: doodle - tool to quickly search the documents on a computer
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221349
Bug 221349 depends on bug 214087, which changed state.
Bug 214087 Summary: Review Request: libextractor -- Simple library for keyword extraction https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214087
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |NEXTRELEASE Status|ASSIGNED |CLOSED
package-review@lists.fedoraproject.org