[Bug 1805697] New: Review Request: gfs-didot-display-fonts - A 20th century Greek decorative font family
https://bugzilla.redhat.com/show_bug.cgi?id=1805697
Bug ID: 1805697 Summary: Review Request: gfs-didot-display-fonts - A 20th century Greek decorative font family Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: nicolas.mailhot@laposte.net QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedo...
SRPM URL: https://download.copr.fedorainfracloud.org/results/nim/fonts-rpm-macros/fedo...
Description: GFS Didot Display is a fat version of the Greek Didot. Found in several publications, mainly as a headline font since the 1840s. At certain occassions it was used in text columns for newspaper typesetting. The typeface was digitized by George Triantafyllakos based on samples found in Greek newspapers from the ’50s and from the Specimens Catalogue of Linotype Co.
Fedora Account System Username: nim
Another GFS font family, to bring the GFS catalog in Fedora to 100%
The packaging conforms to https://pagure.io/packaging-committee/issue/935 as approved by FPC on 2020-02-13.
It is one of the test packages that were used to refine the new packaging guidelines https://copr.fedorainfracloud.org/coprs/nim/fonts-rpm-macros/
The new fonts packaging build chain is now live in koji. For example: https://koji.fedoraproject.org/koji/buildinfo?buildID=1468243
If the review is fast enough the package may make the FC32 100% Code Complete Deadline (2020-02-25) https://fedorapeople.org/groups/schedule/f-32/f-32-key-tasks.html
https://bugzilla.redhat.com/show_bug.cgi?id=1805697
Nicolas Mailhot nicolas.mailhot@laposte.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fonts-bugs@lists.fedoraproj | |ect.org Doc Type|--- |If docs needed, set a value
https://bugzilla.redhat.com/show_bug.cgi?id=1805697
--- Comment #1 from Nicolas Mailhot nicolas.mailhot@laposte.net --- *** Bug 1805688 has been marked as a duplicate of this bug. ***
https://bugzilla.redhat.com/show_bug.cgi?id=1805697
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@gmail.com Assignee|nobody@fedoraproject.org |panemade@gmail.com Flags| |fedora-review+
--- Comment #2 from Parag AN(पराग) panemade@gmail.com --- Review:
This package follows new fonts packaging guidelines.
Rpmlint ------- Checking: gfs-didot-display-fonts-20160225-1.fc33.noarch.rpm gfs-didot-display-fonts-doc-20160225-1.fc33.noarch.rpm gfs-didot-display-fonts-20160225-1.fc33.src.rpm gfs-didot-display-fonts.noarch: W: spelling-error %description -l en_US occassions -> occasions, occasion, accessions gfs-didot-display-fonts-doc.noarch: W: summary-not-capitalized C gfs-didot-display-fonts optional documentation files gfs-didot-display-fonts-doc.noarch: E: description-line-too-long C This package provides optional documentation files shipped with gfs-didot-display-fonts. gfs-didot-display-fonts-doc.noarch: W: spurious-executable-perm /usr/share/doc/gfs-didot-display-fonts-doc/GFS_Didot_Display_Specimen.pdf gfs-didot-display-fonts.src: W: spelling-error %description -l en_US occassions -> occasions, occasion, accessions 3 packages and 0 specfiles checked; 1 errors, 4 warnings.
Source checksums ---------------- http://www.greekfontsociety-gfs.gr/_assets/fonts/GFS_Didot_Display.zip : CHECKSUM(SHA256) this package : 7dfe83c5a0155f9c7764dce7493b45ba2f1358ce251f9c621387a3a252cd08a6 CHECKSUM(SHA256) upstream package : 7dfe83c5a0155f9c7764dce7493b45ba2f1358ce251f9c621387a3a252cd08a6
Requires -------- gfs-didot-display-fonts (rpmlib, GLIBC filtered): config(gfs-didot-display-fonts) font(gfsdidot) fontpackages-filesystem
gfs-didot-display-fonts-doc (rpmlib, GLIBC filtered):
Provides -------- gfs-didot-display-fonts: config(gfs-didot-display-fonts) font(gfsdidotdisplay) gfs-didot-display-fonts metainfo() metainfo(org.fedoraproject.gfs-didot-display-fonts.metainfo.xml)
gfs-didot-display-fonts-doc: gfs-didot-display-fonts-doc
All other things like license, config, metainfo files looks good.
Issues: 1) Fix the rpmlint warnings/errors before this package import
APPROVED
https://bugzilla.redhat.com/show_bug.cgi?id=1805697
--- Comment #3 from Nicolas Mailhot nicolas.mailhot@laposte.net --- Fixed the warnings, thanks for the review!
https://pagure.io/releng/fedora-scm-requests/issue/22485
https://bugzilla.redhat.com/show_bug.cgi?id=1805697
--- Comment #4 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gfs-didot-display-fonts
https://bugzilla.redhat.com/show_bug.cgi?id=1805697
Nicolas Mailhot nicolas.mailhot@laposte.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2020-02-24 23:02:22
--- Comment #5 from Nicolas Mailhot nicolas.mailhot@laposte.net --- And this one is done for F32 & F33. Thanks Parag and Gwyn.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com