Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229929
Summary: Review Request: mecab-jumandic - JUMAN dictorionary for MeCab Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: mtasaka@ioa.s.u-tokyo.ac.jp QAContact: fedora-package-review@redhat.com
Spec URL: http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SPECS/mecab-... SRPM URL: http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SRPMS/mecab-... Mockbuild log on FC-devel i386: http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/LOGS/MOCK-me... Description: MeCab JUMAN is a dictionary for MeCab using CRF estimation based on Kyoto corpus.
rpmlint on binary rpm: --------------------------------------------- E: mecab-jumandic no-binary E: mecab-jumandic only-non-binary-in-usr-lib --------------------------------------------- Well, no executable binaries are installed, but the installed data is compiled by arch-dependent binaries (in mecab: bug 229927) and the created data are arch-dependent.
This package depends on mecab (bug 229927)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mecab-jumandic - JUMAN dictorionary for MeCab
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229929
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn| |229927
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mecab-jumandic - JUMAN dictorionary for MeCab
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229929
------- Additional Comments From j.w.r.degoede@hhs.nl 2007-02-26 14:12 EST ------- <bummer>
I just tried to build this to review it and it fails with: make: /usr/lib64exec/mecab/mecab-dict-index: Command not found make: /usr/lib64exec/mecab/mecab-dict-index: Command not found
Whereas mecab installs: [hans@shalem ~]$ rpm -ql mecab mecab-0.94-0.3.pre2.x86_64 /etc/mecabrc /usr/bin/mecab /usr/lib64/libmecab.so.1 /usr/lib64/libmecab.so.1.0.0 /usr/libexec/mecab /usr/libexec/mecab/mecab-cost-train /usr/libexec/mecab/mecab-dict-gen /usr/libexec/mecab/mecab-dict-index /usr/libexec/mecab/mecab-system-eval /usr/libexec/mecab/mecab-test-gen
So this needs fixing as /usr/lib64exec does not even exist on my system (and /usr/libexec is part of the filesystem package). So mecab-jumandic should always be using /usr/libexec or %{_libexecdir} even when on 64 bit.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mecab-jumandic - JUMAN dictorionary for MeCab
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229929
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-02-26 22:52 EST ------- (In reply to comment #1)
<bummer>
I just tried to build this to review it and it fails with: make: /usr/lib64exec/mecab/mecab-dict-index: Command not found make: /usr/lib64exec/mecab/mecab-dict-index: Command not found
This was due to mecab-config in mecab-devel. I rebuilt 0.94-0.4.pre2 so would you try it? (this version is now in buildsys and mockbuild should catch this version).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mecab-jumandic - JUMAN dictorionary for MeCab
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229929
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-02-27 01:17 EST ------- Note: this version of mecab can be downloaded directly from under http://buildsys.fedoraproject.org/plague-results/
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mecab-jumandic - JUMAN dictorionary for MeCab
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229929
j.w.r.degoede@hhs.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |j.w.r.degoede@hhs.nl Flag| |fedora-review?
------- Additional Comments From j.w.r.degoede@hhs.nl 2007-03-02 10:09 EST ------- Sorry I hadn't assigned this to myself yet so I didn't see any of your replies (oops). I'll get around to reviewing this as time permits.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mecab-jumandic - JUMAN dictorionary for MeCab
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229929
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-03-03 11:22 EST ------- Well, I changed the default encoding of the dictionary data to UTF-8.
http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SPECS/mecab-... http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SRPMS/mecab-... http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/LOGS/MOCK-me...
-------------------------------------------------- * Sat Mar 3 2007 Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp - 5.1.20051121-3 - Change default to UTF-8 and make EUC-JP charset package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mecab-jumandic - JUMAN dictorionary for MeCab
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229929
------- Additional Comments From j.w.r.degoede@hhs.nl 2007-03-04 06:13 EST ------- MUST: ===== * rpmlint output is: E: mecab-jumandic no-binary E: mecab-jumandic only-non-binary-in-usr-lib E: mecab-jumandic-EUCJP only-non-binary-in-usr-lib These are "normal" for this package and can be ignored * Package and spec file named appropriately * Packaged according to packaging guidelines * License ok * spec file is legible and in Am. English. * Source matches upstream * Compiles and builds on devel x86_64 * BR: ok * No locales * No shared libraries * Not relocatable * Package owns / or requires all dirs 0 No duplicate files & Permissions * %clean & macro usage OK * Contains code only * %doc does not affect runtime, and isn't large enough to warrent a sub package * no -devel package needed * no .desktop file required
Must Fix: =========
* add %defattr(-,root,root,-) to %files EUCJP * add || : at the end of the %post sed lines, so that if sed fails for some reason this doesn't cause the entire rpm transaction to fail
Questions: ==========
* If one installs multiple dictionaries, the config file will only contain the last one installed, can mecab handle multiple dicts in the config file? * What happens if all dicts get uninstalled?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mecab-jumandic - JUMAN dictorionary for MeCab
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229929
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-03-04 07:01 EST ------- Thank you for first reviewing!!
Well, before fixing spec/srpm:
Questions:
- If one installs multiple dictionaries, the config file will only contain the last one installed, can mecab handle multiple dicts in the config file?
Only one. So always the last one is used unless mecab user overwrites what dictionary to use from command line option.
However allowing to install multiple dictionaries even if only the last one is used by default is not bad IMO because sysadmin can manually edit mecabrc if he/she wants.
- What happens if all dicts get uninstalled?
The core "mecab" binary becomes useless, because "mecab" is a utility to analyze the "structure" of Japanese sentence and it surely requires one dictionary.
Still some other binaries (under /usr/libexec/mecab) can be used (mainly for compiling dictionaries) and rebuilding mecab dictionary (currently mecab-jumandic) uses the binaries under /usr/libexec/mecab, which don't require /etc/mecabrc .
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mecab-jumandic - JUMAN dictorionary for MeCab
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229929
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-03-04 10:05 EST ------- Just updated according to MUSTFIX.
http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SPECS/mecab-... http://www.ioa.s.u-tokyo.ac.jp/~mtasaka/dist/extras/development/SRPMS/mecab-... -------------------------------------- * Sun Mar 4 2007 Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp - 5.1.20051121-4 - Add missing defattr and make sed script safer.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mecab-jumandic - JUMAN dictorionary for MeCab
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229929
j.w.r.degoede@hhs.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From j.w.r.degoede@hhs.nl 2007-03-04 12:42 EST ------- all must fix items fixed:
Approved by Hans de Goede
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mecab-jumandic - JUMAN dictorionary for MeCab
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229929
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs-
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-03-04 12:52 EST ------- Thank you!!
Request to CVS admin for new package: New Package CVS Request ======================= Package Name: mecab-jumandic Short Description: JUMAN dictorionary for MeCab Owners: mtasaka@ioa.s.u-tokyo.ac.jp Branches: devel FC-6 FC-5 InitialCC: (nobody) =======================
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mecab-jumandic - JUMAN dictorionary for MeCab
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229929
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs- |fedora-cvs?
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-03-04 12:53 EST ------- Oops... changing to fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mecab-jumandic - JUMAN dictorionary for MeCab
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229929
petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mecab-jumandic - JUMAN dictorionary for MeCab
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229929
Bug 229929 depends on bug 229927, which changed state.
Bug 229927 Summary: Review Request: mecab - Yet Another Part-of-Speech and Morphological Analyzer https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229927
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |NEXTRELEASE Status|ASSIGNED |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: mecab-jumandic - JUMAN dictorionary for MeCab
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=229929
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-03-04 20:11 EST ------- Importing done on all branches.
Thank you for reviewing and approving this package!! Closing.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla