https://bugzilla.redhat.com/show_bug.cgi?id=1809263
Bug ID: 1809263 Summary: Review Request: wmbusmeters - Read the wireless mbus protocol to acquire utility meter readings Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: dwrobel@ertelnet.rybnik.pl QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://dwrobel.fedorapeople.org/projects/rpmbuild/SPECS/wmbusmeters.spec SRPM URL: https://dwrobel.fedorapeople.org/projects/rpmbuild/SRPMS/wmbusmeters-0.9.27-... Description: The program receives and decodes C1,T1 or S1 telegrams (using the wireless mbus protocol) to acquire utility meter readings. The readings can then be published using MQTT, curled to a REST api, inserted into a database or stored in a log file.
Fedora Account System Username: dwrobel
COPR build: https://copr.fedorainfracloud.org/coprs/dwrobel/wmbusmeters/
https://bugzilla.redhat.com/show_bug.cgi?id=1809263
Damian Wrobel dwrobel@ertelnet.rybnik.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1809262 Doc Type|--- |If docs needed, set a value
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1809262 [Bug 1809262] Review Request: rtl-wmbus - Software defined receiver for wireless M-Bus with RTL-SDR
https://bugzilla.redhat.com/show_bug.cgi?id=1809263
--- Comment #2 from Damian Wrobel dwrobel@ertelnet.rybnik.pl --- Updated spec & SRPM: Spec URL: https://dwrobel.fedorapeople.org/projects/rpmbuild/SPECS/wmbusmeters.spec SRPM URL: https://dwrobel.fedorapeople.org/projects/rpmbuild/SRPMS/wmbusmeters-0.9.27-...
https://bugzilla.redhat.com/show_bug.cgi?id=1809263
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com
--- Comment #3 from Robert-André Mauchin zebob.m@gmail.com --- - mv %{buildroot}/lib %{buildroot}/usr/ → mv %{buildroot}/lib %{buildroot}%{_prefix}
- rm %{_sysconfdir}/logrotate.d/wmbusmeters if you don't need to use it, %exclude is reserved for use with multiple packages
- You need to add the systemd scriptlets:
%post %systemd_post %{name}@.service
%preun %systemd_preun %{name}@.service
%postun %systemd_postun_with_restart %{name}@.service
- Remove the -v before import as it causes issues with fedpkg
%forgemeta -v
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in wmbusmeters See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Scriptlets/#_scriptlets
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GPL (v3 or later)". 89 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/wmbusmeters/review- wmbusmeters/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [ ]: Files in /run, var/run and /var/lock uses tmpfiles.d when appropriate [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: wmbusmeters-0.9.27-5.fc33.x86_64.rpm wmbusmeters-debuginfo-0.9.27-5.fc33.x86_64.rpm wmbusmeters-debugsource-0.9.27-5.fc33.x86_64.rpm wmbusmeters-0.9.27-5.fc33.src.rpm wmbusmeters.x86_64: W: spelling-error Summary(en_US) mbus -> mus, bus, bums wmbusmeters.x86_64: W: spelling-error %description -l en_US mbus -> mus, bus, bums wmbusmeters.x86_64: W: spelling-error %description -l en_US api -> API, pi, ape wmbusmeters.x86_64: W: no-manual-page-for-binary wmbusmetersd wmbusmeters.src: W: spelling-error Summary(en_US) mbus -> mus, bus, bums wmbusmeters.src: W: spelling-error %description -l en_US mbus -> mus, bus, bums wmbusmeters.src: W: spelling-error %description -l en_US api -> API, pi, ape wmbusmeters.src:66: E: hardcoded-library-path in %{buildroot}/lib wmbusmeters.src: W: patch-not-applied Patch0: %{name}-Make-easier-to-packaging-wmbumeters-for-linux.patch wmbusmeters.src: W: patch-not-applied Patch1: %{name}-Fix-compilation-error-on-gcc-10.x.patch wmbusmeters.src: W: patch-not-applied Patch2: %{name}-Fix-accessing-empty-string.patch wmbusmeters.src: W: patch-not-applied Patch3: %{name}-Make-wmbusmeters.d-directory-accessible-for-the-owne.patch wmbusmeters.src: E: specfile-error Setting %{forgeurl0} = https://github.com/weetmuts/wmbusmeters wmbusmeters.src: E: specfile-error Setting %{tag0} = 0.9.27 wmbusmeters.src: E: specfile-error Setting %{version0} = 0.9.27 wmbusmeters.src: E: specfile-error Setting %{forgeurl} = https://github.com/weetmuts/wmbusmeters wmbusmeters.src: E: specfile-error Setting %{fileref} = 0.9.27 wmbusmeters.src: E: specfile-error Setting %{ref} = 0.9.27 wmbusmeters.src: E: specfile-error Setting %{archiveext} = tar.gz wmbusmeters.src: E: specfile-error Setting %{archivename} = %{repo}-0.9.27 wmbusmeters.src: E: specfile-error Setting %{archiveurl} = https://github.com/weetmuts/wmbusmeters/archive/0.9.27/%%7Brepo%7D-0.9.27.ta... wmbusmeters.src: E: specfile-error Setting %{scm} = git wmbusmeters.src: E: specfile-error Setting %{topdir} = %{repo}-0.9.27 wmbusmeters.src: E: specfile-error Setting %{repo} = wmbusmeters wmbusmeters.src: E: specfile-error Setting %{forgesource} = https://github.com/weetmuts/wmbusmeters/archive/0.9.27/wmbusmeters-0.9.27.ta... wmbusmeters.src: E: specfile-error Setting %{forgesetupargs} = -n %{extractdir} wmbusmeters.src: E: specfile-error Setting %{extractdir} = wmbusmeters-0.9.27 wmbusmeters.src: E: specfile-error Setting %{forgesource0} = https://github.com/weetmuts/wmbusmeters/archive/0.9.27/wmbusmeters-0.9.27.ta... wmbusmeters.src: E: specfile-error Setting %{forgesetupargs0} = -n wmbusmeters-0.9.27 wmbusmeters.src: E: specfile-error Setting %{archivename0} = wmbusmeters-0.9.27 wmbusmeters.src: E: specfile-error Setting %{archiveext0} = tar.gz wmbusmeters.src: E: specfile-error Setting %{archiveurl0} = https://github.com/weetmuts/wmbusmeters/archive/0.9.27/wmbusmeters-0.9.27.ta... wmbusmeters.src: E: specfile-error Setting %{topdir0} = wmbusmeters-0.9.27 wmbusmeters.src: E: specfile-error Setting %{extractdir0} = wmbusmeters-0.9.27 wmbusmeters.src: E: specfile-error Setting %{repo0} = wmbusmeters wmbusmeters.src: E: specfile-error Setting %{scm0} = git 4 packages and 0 specfiles checked; 25 errors, 11 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1809263
--- Comment #4 from Damian Wrobel dwrobel@ertelnet.rybnik.pl --- (In reply to Robert-André Mauchin from comment #3)
- mv %{buildroot}/lib %{buildroot}/usr/ → mv %{buildroot}/lib
%{buildroot}%{_prefix}
Fixed
- rm %{_sysconfdir}/logrotate.d/wmbusmeters if you don't need to use it,
%exclude is reserved for use with multiple packages
Fixed
- You need to add the systemd scriptlets:
%post %systemd_post %{name}@.service
%preun %systemd_preun %{name}@.service
%postun %systemd_postun_with_restart %{name}@.service
Fixed however, I'm using wmbusmeters@*.service instead of %{name}@.service as the %{name}@.service is just the template not the real service name.
%forgemeta -v
Fixed
Updated spec & SRPM: Spec URL: https://dwrobel.fedorapeople.org/projects/rpmbuild/SPECS/wmbusmeters.spec SRPM URL: https://dwrobel.fedorapeople.org/projects/rpmbuild/SRPMS/wmbusmeters-0.9.27-...
https://bugzilla.redhat.com/show_bug.cgi?id=1809263
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #5 from Robert-André Mauchin zebob.m@gmail.com --- Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1809263
--- Comment #6 from Damian Wrobel dwrobel@ertelnet.rybnik.pl --- (In reply to Robert-André Mauchin from comment #5)
Package approved.
Thank you very much for the review.
https://bugzilla.redhat.com/show_bug.cgi?id=1809263
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-d3a031fbcf has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-d3a031fbcf
https://bugzilla.redhat.com/show_bug.cgi?id=1809263
--- Comment #8 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/wmbusmeters
https://bugzilla.redhat.com/show_bug.cgi?id=1809263
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-7761540107 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-7761540107
https://bugzilla.redhat.com/show_bug.cgi?id=1809263
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-d3a031fbcf has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-d3a031fbcf *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-d3a031fbcf
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=1809263
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-462a2b0eba has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-462a2b0eba *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-462a2b0eba
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=1809263
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-7761540107 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-7761540107 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-7761540107
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=1809263 Bug 1809263 depends on bug 1809262, which changed state.
Bug 1809262 Summary: Review Request: rtl-wmbus - Software defined receiver for wireless M-Bus with RTL-SDR https://bugzilla.redhat.com/show_bug.cgi?id=1809262
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1809263
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2020-04-02 00:31:23
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-7761540107 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1809263
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-d3a031fbcf has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1809263
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-462a2b0eba has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org