Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=251068
Summary: Review Request: ocaml-libvirt - OCaml binding for libvirt Product: Fedora Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: rjones@redhat.com QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://www.annexia.org/tmp/ocaml/ocaml-libvirt.spec SRPM URL: http://www.annexia.org/tmp/ocaml/ocaml-libvirt-0.3.1.2-1.fc8.src.rpm Description: OCaml binding for libvirt (http://libvirt.org) and also the virtualization utility 'virt-top'.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ocaml-libvirt - OCaml binding for libvirt
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=251068
rjones@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn| |250969
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ocaml-libvirt - OCaml binding for libvirt
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=251068
rjones@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn| |253566
------- Additional Comments From rjones@redhat.com 2007-08-22 08:12 EST ------- Spec URL: http://www.annexia.org/tmp/ocaml/ocaml-libvirt.spec SRPM URL: http://www.annexia.org/tmp/ocaml/ocaml-libvirt-0.3.2.1-1.fc8.src.rpm Description: OCaml binding for libvirt (http://libvirt.org) and also the virtualization utility 'virt-top'.
* Wed Aug 22 2007 Richard W.M. Jones rjones@redhat.com - 0.3.2.1-1 - Upstream version 0.3.2.1. - Put HTML documentation in -devel package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ocaml-libvirt - OCaml binding for libvirt
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=251068
------- Additional Comments From rjones@redhat.com 2007-08-22 08:48 EST ------- Spec URL: http://www.annexia.org/tmp/ocaml/ocaml-libvirt.spec SRPM URL: http://www.annexia.org/tmp/ocaml/ocaml-libvirt-0.3.2.1-2.fc8.src.rpm Description: OCaml binding for libvirt (http://libvirt.org) and also the virtualization utility 'virt-top'.
There was an unclosed %if section in the previous spec file - fixed.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ocaml-libvirt - OCaml binding for libvirt
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=251068
rjones@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn| |241656
------- Additional Comments From rjones@redhat.com 2007-08-23 14:12 EST ------- Spec URL: http://www.annexia.org/tmp/ocaml/ocaml-libvirt.spec SRPM URL: http://www.annexia.org/tmp/ocaml/ocaml-libvirt-0.3.2.3-2.fc8.src.rpm Description: OCaml binding for libvirt (http://libvirt.org) and also the virtualization utility 'virt-top'.
* Thu Aug 23 2007 Richard W.M. Jones rjones@redhat.com - 0.3.2.3-2 - build_* macros so we can choose what subpackages to build.
* Thu Aug 23 2007 Richard W.M. Jones rjones@redhat.com - 0.3.2.3-1 - Upstream version 0.3.2.3. - Add missing BR libvirt-devel.
* Wed Aug 22 2007 Richard W.M. Jones rjones@redhat.com - 0.3.2.2-1 - Upstream version 0.3.2.2.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ocaml-libvirt - OCaml binding for libvirt
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=251068
berrange@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |berrange@redhat.com Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ocaml-libvirt - OCaml binding for libvirt
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=251068
------- Additional Comments From berrange@redhat.com 2007-08-23 21:29 EST ------- - MUST: rpmlint must be run on every package. [OK]
$ rpmlint /home/berrange/rpm/RPMS/x86_64/ocaml-libvirt-0.3.2.3-2.fc8.x86_64.rpm $ rpmlint /home/berrange/rpm/SRPMS/ocaml-libvirt-0.3.2.3-2.fc8.src.rpm $ rpmlint /home/berrange/rpm/RPMS/x86_64/ocaml-libvirt-devel-0.3.2.3-2.fc8.x86_64.rpm $ rpmlint /home/berrange/rpm/RPMS/x86_64/mlvirsh-0.3.2.3-2.fc8.x86_64.rpm $ rpmlint /home/berrange/rpm/RPMS/x86_64/virt-top-0.3.2.3-2.fc8.x86_64.rpm
- MUST: The package must be named according to the Package Naming Guidelines. [OK] NB: the subpackags mlvirsh & virt-top do not have ocaml-libvirt prefix. This makes sense in context, since they are top level apps which happen to be part of main tar.gz => OK - MUST: The spec file name must match the base package %{name} [OK] - MUST: The package must meet the Packaging Guidelines. [OK] - MUST: The package must be licensed with a Fedora approved license [OK] - MUST: The License field in the package spec file must match the actual license. [OK] - MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. [OK] - MUST: The spec file must be written in American English. [OK] - MUST: The spec file for the package MUST be legible. [OK] - MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. [OK] - MUST: The package must successfully compile and build into binary rpms on at least one supported architecture. [OK x86_64 rawhide] - MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. [OK] - MUST: All build dependencies must be listed in BuildRequires [OK] - MUST: The spec file MUST handle locales properly. [N/A] - MUST: Every binary RPM package which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. [N/A] - MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review. [N/A] - MUST: A package must own all directories that it creates. [OK] - MUST: A package must not contain any duplicate files in the %files listing. [OK] - MUST: Permissions on files must be set properly. [OK] - MUST: Each package must have a %clean section [OK] - MUST: Each package must consistently use macros [OK] - MUST: The package must contain code, or permissable content. [OK] - MUST: Large documentation files should go in a -doc subpackage. [N/A] - MUST: If a package includes something as %doc, it must not affect the runtime of the application. [N/A] - MUST: Header files must be in a -devel package. [OK] - MUST: Static libraries must be in a -static package. [N/A] - MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for directory ownership and usability). [N/A] - MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. [N/A] - MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} [OK] - MUST: Packages must NOT contain any .la libtool archives [N/A] - MUST: Packages containing GUI applications must include a %{name}.desktop file [N/A] - MUST: Packages must not own files or directories already owned by other packages. [OK] - MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). See Prepping BuildRoot For %install for details. [OK] - MUST: All filenames in rpm packages must be valid UTF-8. [OK]
OK, all supplementary guidelines for OCaml at:
http://fedoraproject.org/wiki/Packaging/OCaml
Will approve once block bug 241656, bug 250969, and bug 253566 are approved.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ocaml-libvirt - OCaml binding for libvirt
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=251068
berrange@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From berrange@redhat.com 2007-08-24 09:38 EST ------- All dependant packages are approved, so this is now APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ocaml-libvirt - OCaml binding for libvirt
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=251068
rjones@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From rjones@redhat.com 2007-08-24 09:49 EST ------- New Package CVS Request ======================= Package Name: ocaml-libvirt Short Description: OCaml binding for libvirt Owners: rjones@redhat.com Branches: F-7 InitialCC: rjones@redhat.com Cvsextras Commits: yes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ocaml-libvirt - OCaml binding for libvirt
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=251068
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2007-08-24 11:44 EST ------- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ocaml-libvirt - OCaml binding for libvirt
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=251068
Bug 251068 depends on bug 241656, which changed state.
Bug 241656 Summary: Review Request: ocaml-csv - OCaml library for reading and writing CSV files https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=241656
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |NEXTRELEASE Status|ASSIGNED |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ocaml-libvirt - OCaml binding for libvirt
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=251068
Bug 251068 depends on bug 250969, which changed state.
Bug 250969 Summary: Review Request: ocaml-curses - OCaml bindings for ncurses https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=250969
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |NEXTRELEASE Status|ASSIGNED |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ocaml-libvirt - OCaml binding for libvirt
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=251068
Bug 251068 depends on bug 253566, which changed state.
Bug 253566 Summary: Review Request: ocaml-xml-light - Minimal XML parser and printer for OCaml https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=253566
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |NEXTRELEASE Status|ASSIGNED |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ocaml-libvirt - OCaml binding for libvirt
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=251068
rjones@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ocaml-libvirt - OCaml binding for libvirt
https://bugzilla.redhat.com/show_bug.cgi?id=251068
rjones@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
------- Additional Comments From rjones@redhat.com 2007-11-07 10:42 EST ------- Package Change Request ====================== Package Name: ocaml-libvirt New Branches: EL-5
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: ocaml-libvirt - OCaml binding for libvirt
https://bugzilla.redhat.com/show_bug.cgi?id=251068
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2007-11-07 14:55 EST ------- cvs done.
package-review@lists.fedoraproject.org