[Bug 1715841] New: Review Request: python-colour - Python module to convert and manipulate color representations
https://bugzilla.redhat.com/show_bug.cgi?id=1715841
Bug ID: 1715841 Summary: Review Request: python-colour - Python module to convert and manipulate color representations Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mail@fabian-affolter.ch QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-colour.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-colour-0.1.5-1.fc30.src.r...
Project URL: https://github.com/vaab/colour
Description: Converts and manipulates common color representation (RGB, HSL, web, etc.)
- Damn simple and pythonic way to manipulate color representation - Full conversion between RGB, HSL, 6-digit hex, 3-digit hex, human color - One object (Color) or bunch of single purpose function (rgb2hex, hsl2rgb, etc.) web format that use the smallest representation between 6-digit (e.g. #fa3b2c), 3-digit (e.g. #fbb), fully spelled color (e.g. white), following W3C color naming for compatible CSS or HTML color specifications. - smooth intuitive color scale generation choosing N color gradients. - can pick colors for you to identify objects of your application.
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=35168823
rpmlint output: $ rpmlint python-colour-0.1.5-1.fc30.src.rpm python-colour.src: W: spelling-error %description -l en_US pythonic -> python python-colour.src: W: spelling-error %description -l en_US fbb -> ebb, fib, fab 1 packages and 0 specfiles checked; 0 errors, 2 warnings.
$ rpmlint python3-colour-0.1.5-1.fc30.noarch.rpm python3-colour.noarch: W: spelling-error %description -l en_US pythonic -> python python3-colour.noarch: W: spelling-error %description -l en_US fbb -> ebb, fib, fab 1 packages and 0 specfiles checked; 0 errors, 2 warnings.
Fedora Account System Username: fab
https://bugzilla.redhat.com/show_bug.cgi?id=1715841
Fabian Affolter mail@fabian-affolter.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1574642 Alias| |python-colour
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1574642 [Bug 1574642] Missing dependency python-kaa-metadata
https://bugzilla.redhat.com/show_bug.cgi?id=1715841
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |lemenkov@gmail.com Assignee|nobody@fedoraproject.org |lemenkov@gmail.com Flags| |fedora-review?
--- Comment #1 from Peter Lemenkov lemenkov@gmail.com --- I'll review it
https://bugzilla.redhat.com/show_bug.cgi?id=1715841
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #2 from Peter Lemenkov lemenkov@gmail.com --- [+] rpmlint is silent (or produces messages which can be safely ignored):
Auriga ~: rpmlint python-colour-0.1.5-1.fc31.src.rpm python3-colour-0.1.5-1.fc31.noarch.rpm python-colour.src: W: spelling-error %description -l en_US pythonic -> python python-colour.src: W: spelling-error %description -l en_US fbb -> ebb, fib, fab python3-colour.noarch: W: spelling-error %description -l en_US pythonic -> python python3-colour.noarch: W: spelling-error %description -l en_US fbb -> ebb, fib, fab 2 packages and 0 specfiles checked; 0 errors, 4 warnings. Auriga ~:
[+] The package is named according to the Package Naming Guidelines. [+] The spec file name matches the base package %{name}, in the format %{name}.spec. [+] The package meets the Packaging Guidelines. [+] The package is licensed with a Fedora approved license and meets the Licensing Guidelines. [+] The License field in the package spec file matches the actual license (3-clause BSD). [+] The file, containing the text of the license(s) for the package, is included in %doc and marked as %license. [+] The spec file is written in American English. [+] The spec file for the package is legible. [+] The sources used to build the package matches the upstream source, as provided in the spec URL.
Auriga ~: sha512sum colour-0.1.5.tar.gz* 09a5160862bf10cd5f4a94e43c63d6f2a5db43bcaae0e9d8f66900113ec04471e22d0bec7412f0289c6f1e6871c1a544f5be36266aa8d6fd5ec274bd461d9df8 colour-0.1.5.tar.gz 09a5160862bf10cd5f4a94e43c63d6f2a5db43bcaae0e9d8f66900113ec04471e22d0bec7412f0289c6f1e6871c1a544f5be36266aa8d6fd5ec274bd461d9df8 colour-0.1.5.tar.gz.1 Auriga ~:
[+] The package successfully compiles and builds into binary rpms. [+] All build dependencies are listed in BuildRequires. [0] No need to handle locales. [0] The package does not contain any shared library files. [+] The package does not bundle copies of system libraries. [+] The package isn't designed to be relocatable. [+] The package owns all directories that it creates. [+] The package does not list a file more than once in the spec file's %files listings. [+] Permissions on files are set properly. [+] The package consistently uses macros. [+] The package contains code, or permissible content. [0] No large documentation files. [+] Anything, the package includes as %doc, does not affect the runtime of the application. [0] No static libraries. [0] No -devel sub-package. [+] The package does not contain any .la libtool archives. [0] Not a GUI application. [+] The package does not own files or directories already owned by other packages. [+] All filenames in rpm packages are valid UTF-8.
APPROVED
https://bugzilla.redhat.com/show_bug.cgi?id=1715841
--- Comment #3 from Fabian Affolter mail@fabian-affolter.ch --- Thanks for the review.
https://bugzilla.redhat.com/show_bug.cgi?id=1715841
--- Comment #4 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-colour
https://bugzilla.redhat.com/show_bug.cgi?id=1715841
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- FEDORA-2019-f3b9599c52 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-f3b9599c52
https://bugzilla.redhat.com/show_bug.cgi?id=1715841
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- python-colour-0.1.5-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-f3b9599c52
https://bugzilla.redhat.com/show_bug.cgi?id=1715841
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2019-06-18 03:46:13
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- python-colour-0.1.5-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com