Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189717
Summary: Review Request: gcompris - Educational suite for kids 2- 10 years old Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: bugzilla-sink@leemhuis.info ReportedBy: j.w.r.degoede@hhs.nl QAContact: fedora-package-review@redhat.com
Spec URL: http://home.zonnet.nl/jwrdegoede/gcompris.spec Files URL: http://home.zonnet.nl/jwrdegoede/gcompris-files.tar.gz Description: GCompris / I Got IT is an educationnal game for children starting at 2. More than 100 different activities are proposed: * Click on the animals => learn the mouse/click usage * Type the falling letters => learn the keyboard usage * Falling Dices * Falling words * Basic algebra * Time learning with an analog clock * Puzzle game with famous paintings * Drive Plane to catch clouds in increasing number * Balance the scales * And much more ...
Some activities make use of sounds. For those you'll have to install the gcompris-sound package for the languages you intend to use.
---
First of all sorry, no SRPM the upstream sources are way too large for my sucky ISP provided homepage. You can get the upstream tarball from: http://sf.net/projects/gcompris And then the files section.
All other needed SOURCES files are in gcompris-files.tar.gz, just untar this in your SOURCES dir and drop the main tarball in your SOURCES dir and you're good to go.
Notice that part of gcompris (1 activity) needs gnucap, which I've packaged too: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189699
Last some small know issues, which I've also reported upstream:
1) If you switch the language to dutch and then start gcompris from a cmdline the following messages appear: parser error : EntityRef: expecting ';' parser error : EntityRef: expecting ';'
These are libxml messages, things work fine though.
2) If you don't have any (valid) alphabet sounds and try to run the letter-click (click the letter you hear) board a message is shown saying that you need to install some alphabet sounds, it is however possible to still start and play the game behind the message box by clicking the letters. Also it is possible to exit to the main menu by pressing the home icon, the message box stays in place then , but its drawn over the home menu instead of over the letter click board.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gcompris - Educational suite for kids 2-10 years old
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189717
j.w.r.degoede@hhs.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn| |189699
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gcompris - Educational suite for kids 2-10 years old
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189717
------- Additional Comments From j.w.r.degoede@hhs.nl 2006-04-24 01:02 EST ------- I've had contact with upstream and the 2 small known issues have been fixed upstream, I'll see if its easy to backport the fixes.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gcompris - Educational suite for kids 2-10 years old
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189717
------- Additional Comments From j.w.r.degoede@hhs.nl 2006-04-25 04:10 EST ------- I've updated both the spec file ant he -files.tar.gz with a -2 version, this fixes issue 1) unfortunatly upstreams fix for issue 2) was not correct / did not fix the issue.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gcompris - Educational suite for kids 2-10 years old
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189717
wart@kobold.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@leemhuis.info |wart@kobold.org OtherBugsDependingO|163776 |163778 nThis| |
------- Additional Comments From wart@kobold.org 2006-04-26 18:16 EST ------- * rpmlint warnings: W: gcompris incoherent-version-in-changelog 7.4-2 7.4-1 W: gcompris-devel no-dependency-on gcompris ...plus some 'no documentation' warnings that you might be able to ignore.
* gcompris-desktop.patch has the following line that should probably be removed: Only in gcompris-7.4: gcompris.desktop.in~
* Only builds on the devel branch due to missing libassetml for FC-5.
* The icon in the .desktop files are missing the .png extension, but the icons in the icon directory end in .png.
I'm looking at gnucap now, so I'll probably have more comments once I can actually install this.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gcompris - Educational suite for kids 2-10 years old
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189717
------- Additional Comments From j.w.r.degoede@hhs.nl 2006-04-27 03:04 EST ------- (In reply to comment #3)
- rpmlint warnings:
W: gcompris incoherent-version-in-changelog 7.4-2 7.4-1
My bad I added a changelog entry for my changes but forgot to bump Release: I will fix this (easy).
W: gcompris-devel no-dependency-on gcompris
Thats because it depends on gcompris-libs, where the actual libs are thats what you get with program and libs (and data) in one _big_ upstream tarbal.
...plus some 'no documentation' warnings that you might be able to ignore.
gcompris comes with plenty of documentation in the main package in a lot of languages, so yes I intend to ignore these :)
- gcompris-desktop.patch has the following line that should probably be removed:
Only in gcompris-7.4: gcompris.desktop.in~
Thats because I used diff not gendiff to generate the diff, this is totaly harmless, but I can remove it if it makes you happy.
- Only builds on the devel branch due to missing libassetml for FC-5.
My grand master plan was / is to ask for a FC-5 cvs branch for libassetml, gnucap and gcompris all at the same time.
- The icon in the .desktop files are missing the .png extension, but the icons
in the icon directory end in .png.
Other .desktop files have this too (gsview for example) it works fine either way,but my desktop patch did screw up the .desktop translations, so I have to fix that anyways, I can also add the .png at the same time if you want, but that would be unnescesarry deviation from upstream.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gcompris - Educational suite for kids 2-10 years old
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189717
------- Additional Comments From j.w.r.degoede@hhs.nl 2006-04-27 06:37 EST ------- Created an attachment (id=128297) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=128297&action=vie...) improved specfile
Here is an improved specfile, this fixes the changelog <-> version warning. I've dropped the desktop.in patch as that breaks .desktop file translations and replaced this with 2 sed commands, which are run at the end of %build, thus after the translations have been merged into the desktop files. It turns out that the upstream .desktop files do have .png at the end for the icons, and I no longer remove this :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gcompris - Educational suite for kids 2-10 years old
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189717
Bug 189717 depends on bug 189699, which changed state.
Bug 189699 Summary: Review Request: gnucap - The Gnu Circuit Analysis Package https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189699
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |NEXTRELEASE Status|ASSIGNED |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gcompris - Educational suite for kids 2-10 years old
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189717
------- Additional Comments From j.w.r.degoede@hhs.nl 2006-04-29 07:41 EST ------- I've just finished uploading a new version, locations are still the same: Spec URL: http://home.zonnet.nl/jwrdegoede/gcompris.spec Files URL: http://home.zonnet.nl/jwrdegoede/gcompris-files.tar.gz
Notting was changed except for the addition of Patch4 which fixes issue 2) as listed in the initial opening comment.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gcompris - Educational suite for kids 2-10 years old
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189717
wart@kobold.org changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From wart@kobold.org 2006-04-30 03:12 EST ------- rpmlint output: E: gcompris hardcoded-library-path in $RPM_BUILD_ROOT/usr/lib/menu
- This is a bogus warning. rpmlint is complaining about the src rpm without realizing that this file is being removed, not included.
W: gcompris-devel no-dependency-on gcompris
- This is ok by design. -devel requires -libs so that it doesn't need to pull in rather large (and unnecessary) base package.
W: gcompris-devel no-documentation W: gcompris-libs no-documentation
- This can be ignored. The developers documentation is integrated with the base package's documentation.
W: gcompris-flags no-documentation W: gcompris-sound-da no-documentation W: gcompris-sound-de no-documentation W: gcompris-sound-en no-documentation W: gcompris-sound-es no-documentation W: gcompris-sound-eu no-documentation W: gcompris-sound-fi no-documentation W: gcompris-sound-fr no-documentation W: gcompris-sound-hu no-documentation W: gcompris-sound-it no-documentation W: gcompris-sound-nl no-documentation W: gcompris-sound-pt no-documentation W: gcompris-sound-ru no-documentation W: gcompris-sound-sv no-documentation
- These can be ignored. There's no need for documentation for localized sound/flag files.
MUST ==== * GPL license ok, license file included * Package and spec file named appropriately * Spec file legible and in Am. English (except for the localized parts) * Sources for the review came from upstream: d80e55da21170a98d671c98b3e582cc3 SOURCES/gcompris-7.4.tar.gz * Builds in mock on devel-i386, devel-x86_64 * Locales handled appropriately * ldconfig called for shared libs in -libs subpackage * Not relocatable * Owns directories that it creates * No duplicate %files * Contains code and permissible content * $RPM_BUILD_ROOT cleaned correctly in %install and %clean * File permissions appear to be ok * headers, .so, and pkgconfig files in -devel * -devel requires -libs, not base (this is acceptable, see above) * .la files not included * .desktop files installed correctly * No need for -doc subpackage
SHOULD ========= * Consider adding Requires: tuxpaint for the tuxpaint launcher
I did a quick check of the english/german sounds on a handful of the games and it worked with no obvious problems.
No blockers found.
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: gcompris - Educational suite for kids 2-10 years old
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189717
j.w.r.degoede@hhs.nl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From j.w.r.degoede@hhs.nl 2006-04-30 07:10 EST ------- (In reply to comment #7)
SHOULD
- Consider adding Requires: tuxpaint for the tuxpaint launcher
Ah, I thought they had build their own clone / copy I didn'y know it was just a launcher, I've added the requirement.
I did a quick check of the english/german sounds on a handful of the games and it worked with no obvious problems.
I may hope so this one has taken me a lot of time :)
No blockers found.
APPROVED
Thanks!
Imported & Build.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla