Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=485154

Parag AN(पराग) panemade@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+

--- Comment #1 from Parag AN(पराग) panemade@gmail.com 2009-02-12 03:37:34 EDT --- Review: + package builds in mock (rawhide i386). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1120997 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 9bcd44e502c16e0cab226d26510bba6d MooseX-Role-Cmd-0.04.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=4, Tests=21, 2 wallclock secs ( 0.03 usr 0.01 sys + 2.07 cusr 0.14 csys = 2.25 CPU) + Package perl-MooseX-Role-Cmd-0.04-1.fc11 => Provides: perl(MooseX::Role::Cmd) = 0.04 perl(MooseX::Role::Cmd::Meta::Attribute::Trait) Requires: perl(IPC::Cmd) perl(Moose::Role) perl(Moose::Util::TypeConstraints) perl(strict) perl(warnings)

APPROVED.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=485154

Kevin Fenzi kevin@tummy.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

--- Comment #3 from Kevin Fenzi kevin@tummy.com 2009-02-13 01:48:54 EDT --- cvs done.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=485154

Iain Arnell iarnell@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |iarnell@gmail.com Flag|fedora-cvs+ |fedora-cvs?

--- Comment #4 from Iain Arnell iarnell@gmail.com 2012-01-15 04:24:06 EST --- Package Change Request ====================== Package Name: perl-MooseX-Role-Cmd InitialCC: perl-sig

Please add perl-sig to this package with watchbugzilla and watchcommits bits on all fedora branches.