Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=370741
Summary: Review Request: libggz - Library for client-server games Product: Fedora Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: rdieter@math.unl.edu QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://kdeforge.unl.edu/apt/kde-redhat/SOURCES/ggz/libggz.spec SRPM URL: http://kdeforge.unl.edu/apt/kde-redhat/SOURCES/ggz/libggz-0.0.14-1.src.rpm Description: GGZ (which is a recursive acronym for GGZ Gaming Zone) develops libraries, games and game-related applications for client-server online gaming. Player rankings, game spectators, AI players and a chat bot are part of this effort.
$rpmlint libggz-0.14-1.src.rpm is clean
scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=230265
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libggz - Library for client-server games
https://bugzilla.redhat.com/show_bug.cgi?id=370741
rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |370751 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libggz - Library for client-server games
https://bugzilla.redhat.com/show_bug.cgi?id=370741
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |tibbs@math.uh.edu Status|NEW |ASSIGNED Flag| |fedora-review+
------- Additional Comments From tibbs@math.uh.edu 2007-11-07 22:45 EST ------- Hmm, rpmlint for me says:
libggz.x86_64: W: incoherent-version-in-changelog 0.0.14-2 0.0.14-1.fc8
Seems like the release is still -1 but the changelog has -2. Not a huge deal; you can fix it up when you check in.
Given the current NSS porting effort, I wonder if it could be used here. I haven't much clue about that, though.
* source files match upstream: d66834894dbc6b55c1da18b10fe8f9a6248bb5d3410b9dc1af955c6befdd0a43 libggz-0.0.14.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly * debuginfo package looks complete. X rpmlint complains about the changelog. * final provides and requires are sane: libggz-0.0.14-1.fc8.x86_64.rpm libggz.so.2()(64bit) libggz = 0.0.14-1.fc8 = /sbin/ldconfig libgcrypt.so.11()(64bit) libgcrypt.so.11(GCRYPT_1.2)(64bit) libggz.so.2()(64bit) libgnutls.so.13()(64bit) libgnutls.so.13(GNUTLS_1_3)(64bit)
libggz-devel-0.0.14-1.fc8.x86_64.rpm libggz-devel = 0.0.14-1.fc8 = libggz = 0.0.14-1.fc8 libggz.so.2()(64bit)
* %check is not present; no test suite upstream. Obviously this can't really be tested without some client apps. * shared libraries present; ldconfig called properly. * unversioned .so files are in the -devel pacakge. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets are OK (ldconfig) * code, not content. * documentation is small, so no -docs subpackage is necessary. (Well, the changelog is twice as large as the library itself, but it's still under 300K.) * %docs are not necessary for the proper functioning of the package. * headers are in the -devel package. * no pkgconfig files. * no static libraries. * no libtool .la files.
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libggz - Library for client-server games
https://bugzilla.redhat.com/show_bug.cgi?id=370741
rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From rdieter@math.unl.edu 2007-11-07 23:09 EST ------- New Package CVS Request ======================= Package Name: libggz Short Description: Library for client-server games Owners: rdieter Branches: F-7 F-8 EL-5 Cvsextras Commits: yes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libggz - Library for client-server games
https://bugzilla.redhat.com/show_bug.cgi?id=370741
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2007-11-08 14:16 EST ------- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libggz - Library for client-server games
https://bugzilla.redhat.com/show_bug.cgi?id=370741
rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From rdieter@math.unl.edu 2007-11-08 15:59 EST ------- imported, building. thanks.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libggz - Library for client-server games
https://bugzilla.redhat.com/show_bug.cgi?id=370741
------- Additional Comments From updates@fedoraproject.org 2007-11-09 18:31 EST ------- libggz-0.0.14-1.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libggz - Library for client-server games
https://bugzilla.redhat.com/show_bug.cgi?id=370741
updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |CLOSED Resolution|NEXTRELEASE |ERRATA Fixed In Version| |0.0.14-1.fc8
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libggz - Library for client-server games
https://bugzilla.redhat.com/show_bug.cgi?id=370741
------- Additional Comments From updates@fedoraproject.org 2007-11-09 18:48 EST ------- libggz-0.0.14-1.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org