https://bugzilla.redhat.com/show_bug.cgi?id=1438090
Bug ID: 1438090 Summary: Review Request: GetIt - Application to send HTTP requests Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: bartkessels@outlook.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://raw.githubusercontent.com/bartkessels/getit/master/getit.spec SRPM URL: https://github.com/bartkessels/getit/blob/master/GetIt-1.1-1.fc25.src.rpm?ra... SRPM URL: https://github.com/bartkessels/getit/blob/master/GetIt-1.1-1.fc26.src.rpm?ra... Description: Application to send HTTP requests to API's. Has the ability to send form-data, files, headers and authentication (basic auth and digest auth) Fedora Account System Username: bartkessels
This the first package I've ever created, so if anyone wants to help improve please feel free to do so! Since I'm also the developer of the application the bugs reported will be fixed as fast as possible.
The source of the application: https://github.com/bartkessels/getit
The application has been tested on the koji build system (for both Fedora 25 and Fedora 26) and the results can be found here: Fedora 25: https://koji.fedoraproject.org/koji/taskinfo?taskID=18703853 Fedora 26: https://koji.fedoraproject.org/koji/taskinfo?taskID=18703954
https://bugzilla.redhat.com/show_bug.cgi?id=1438090
Bart Kessels bartkessels@outlook.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1438090
iwicki.artur@svgames.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |iwicki.artur@svgames.pl
--- Comment #1 from iwicki.artur@svgames.pl --- I am not a packager, so this is not an official review.
Your %files section does not include the %license. https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text
https://bugzilla.redhat.com/show_bug.cgi?id=1438090
--- Comment #2 from Bart Kessels bartkessels@outlook.com --- (In reply to iwicki.artur from comment #1)
I am not a packager, so this is not an official review.
Your %files section does not include the %license. https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text
Thank you, just added the %license to the %files section.
https://bugzilla.redhat.com/show_bug.cgi?id=1438090
Jan Kalina jkalina@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jkalina@redhat.com
--- Comment #3 from Jan Kalina jkalina@redhat.com --- (not official review)
Source0 is invalid - it resolves to "getit-1.2.tar.gz", but Github sends "GetIt-1.1-1.fc26.src.rpm", so fedora-review and similar tools fails to build, as they are not able to find downloaded file.
You should also attach ONLY ONE SRPM in one review request - as any review should be against rawhide, it does not make sense to attach SRPMs for more fedora releases.
https://bugzilla.redhat.com/show_bug.cgi?id=1438090
Bart Kessels bartkessels@outlook.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2017-06-01 09:50:30
https://bugzilla.redhat.com/show_bug.cgi?id=1438090
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek@in.waw.pl
--- Comment #4 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Hm, what happened here?
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com