Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194012
Summary: Review Request: xaos - A fast, portable real-time interactive fractal zoomer Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: bugzilla-sink@leemhuis.info ReportedBy: gemi@bluewin.ch QAContact: fedora-package-review@redhat.com
Spec URL: http://math.ifi.unizh.ch/fedora/spec/xaos.spec SRPM URL: http://math.ifi.unizh.ch/fedora/5/i386/SRPMS.gemi/xaos-3.2.1-1.src.rpm Description: XaoS is a fast, portable real-time interactive fractal zoomer. It displays the Mandelbrot set (among other escape time fractals) and allows you zoom smoothly into the fractal. Various coloring modes are provided for both the points inside and outside the selected set. XaoS supports switching between Julia and Mandelbrot fractal types and on-the-fly plane switching.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xaos - A fast, portable real-time interactive fractal zoomer
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194012
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@leemhuis.info |tibbs@math.uh.edu OtherBugsDependingO|163776 |163778 nThis| |
------- Additional Comments From tibbs@math.uh.edu 2006-06-06 01:08 EST ------- This is a problem which prevents things from installing: E: xaos info-dir-file /usr/share/info/dir
Since this is a GUI app, it would be good to have a desktop file.
Most of the files aren't writable by root.
I've not seen %doc --parents before, and can't find a reference. Do you have one handy?
However, one huge problem with this software is that I can't seem to make it run in anything but text mode. It seems to need DGA for any graphics, and that seems to require root. Unfortunately it won't run for me even as root. Is there any way to get this software to run graphically? I seem to recall running it some years ago.
Review: * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text included in package. * source files match upstream: 8df634737b276f9f172060f3ffc489be XaoS-3.2.1.tar.gz 8df634737b276f9f172060f3ffc489be XaoS-3.2.1.tar.gz-srpm * latest version is being packaged. * BuildRequires are proper. * package builds in mock (development, x86_64). X rpmlint is silent. * final provides and requires are sane: xaos = 3.2.1-1.fc5 = /bin/sh /sbin/install-info libX11.so.6 libXxf86dga.so.1 libXxf86vm.so.1 libaa.so.1 libgpm.so.1 libncurses.so.5 libpng12.so.0 libslang.so.2 libz.so.1 * no shared libraries are present. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. X file permissions are appropriate. * %clean is present. * %check is not present; no test suite upstream. * scriptlets present and sane. (info file installation) * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. X a GUI app, but no desktop file.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xaos - A fast, portable real-time interactive fractal zoomer
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194012
------- Additional Comments From tibbs@math.uh.edu 2006-06-06 01:28 EST ------- I found that if you add BR: libXt-devel, the X11 driver is built and works fine.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xaos - A fast, portable real-time interactive fractal zoomer
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194012
------- Additional Comments From gemi@bluewin.ch 2006-06-06 05:08 EST ------- Re: --parents I can't find a reference either, stupid google doesn't let me search for --parents. I found it in an another spec file, but I don't remember which.
(In reply to comment #2)
I found that if you add BR: libXt-devel, the X11 driver is built and works fine.
Ok
I added an icon and a desktop file.
I made all files root-writable using: find $RPM_BUILD_ROOT%{_prefix} -print0 -exec chmod u+rw '{}' ';'
http://math.ifi.unizh.ch/fedora/5/i386/SRPMS.gemi/xaos-3.2.1-2.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xaos - A fast, portable real-time interactive fractal zoomer
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194012
------- Additional Comments From fedora@iagorubio.com 2006-06-06 06:26 EST ------- (In reply to comment #3)
I made all files root-writable using: find $RPM_BUILD_ROOT%{_prefix} -print0 -exec chmod u+rw '{}' ';'
Won't be easier to change defattr(-,root,root,-) with defattr(644,root,root,-) ?
%defattr(644,root,root,-) [snip] %attr(755,root,root) {_bindir}/* [snip]
For consistency it may be good to change the $RPM_BUILD_ROOT variable - as it's the only variable - with the %{buildroot} macro.
http://fedoraproject.org/wiki/Packaging/Guidelines#head-f3d77b27a5d29dfc1f56...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xaos - A fast, portable real-time interactive fractal zoomer
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194012
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From tibbs@math.uh.edu 2006-06-06 11:16 EST ------- It's personal choice with the %defattr thing; I personally don't like to clutter the %files list.
The choice of $RPM_BUILD_ROOT (and $RPM_OPT_FLAGS) is completely up to the packager; the only requirement is that you must be consistent. As there is no use of %{buildroot} or %{optflags}, it is perfectly fine to use $RPM_BUILD_ROOT.
The updated package builds fine; the X11 driver is there and it shows up in the menu.
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xaos - A fast, portable real-time interactive fractal zoomer
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=194012
gemi@bluewin.ch changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From gemi@bluewin.ch 2006-06-07 11:45 EST ------- Built on FC4, FC5 and FC6. Added to owners.list.
Thanks for the review!
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xaos - A fast, portable real-time interactive fractal zoomer
https://bugzilla.redhat.com/show_bug.cgi?id=194012
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide
package-review@lists.fedoraproject.org