https://bugzilla.redhat.com/show_bug.cgi?id=1462412
Bug ID: 1462412 Summary: Review Request: tworld - a puzzle game Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: fedora@svgames.pl QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://svgames.pl/fedora/tworld-1.3.2-2.spec SRPM URL: https://svgames.pl/fedora/tworld-1.3.2-2.src.rpm
koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=20053999
Description: Tile World is an emulation of the game "Chip's Challenge" for the Atari Lynx. The game has its own graphics set and can be played using community-created level sets, without the need for the original game's resources.
Fedora Account System Username: suve
The packaging is a bit unorthodox, as the licences for the level packs are rather restrictive (basically - free redistribution, no modification). Thus, I decided to split the package into three: apart from the usual main package and -data, the level packs go into their own subpackage, -cclp.
https://bugzilla.redhat.com/show_bug.cgi?id=1462412
Iwicki Artur fedora@svgames.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1364745 (FE-GAMESIG)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1364745 [Bug 1364745] Games SIG tracker bug
https://bugzilla.redhat.com/show_bug.cgi?id=1462412
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zbyszek@in.waw.pl Assignee|nobody@fedoraproject.org |zbyszek@in.waw.pl Flags| |fedora-review+
--- Comment #1 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- rpmlint:
tworld-data.noarch: E: incorrect-fsf-address /usr/share/licenses/tworld-data/COPYING Who cares? ;)
tworld.x86_64: W: manual-page-warning /usr/share/man/man6/tworld.6.gz 2: warning: macro `LO' not defined The page seems to display OK, so this can be ignored.
4 packages and 0 specfiles checked; 2 errors, 8 warnings.
make %{?_smp_mflags} → %make_build, optionally.
$ appstream-util validate /usr/share/appdata/tworld.appdata.xml /usr/share/appdata/tworld.appdata.xml: FAILED: • tag-invalid : <metadata_license> is not valid [CC-BY-SA-3.04.0] • tag-invalid : <project_license> is not valid [GPLv2+]SPDX ID 'GPLv2+' unknown • tag-missing : <translation> not specified • tag-missing : <update_contact> is not present • attribute-invalid : <screenshot> width too small [http://www.muppetlabs.com/~breadbox/software/tworld/ss/full1.jpg] • attribute-invalid : <screenshot> height too small [http://www.muppetlabs.com/~breadbox/software/tworld/ss/full1.jpg]
metadata_license should be " CC-BY-SA-3.0", project_license "GPL-2.0+", according to https://spdx.org/licenses/. Displays OK in gnome-software apart from the license.
The game data satisfies the requirements for "firmware" [https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/Li...], and can be packaged. The license text is in CCLP?.html.
+ license is acceptable for Fedora (GPLv2+, "no mods" for the game data) + license is specified correctly + package name is OK + builds, install, runs OK + scriptlets are correct according to guidelines + P/R/BR look correct
Just some nitpicks. Your packaging foo is very strong ;) Package is APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1462412
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |182235 (FE-Legal)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1462412
Tom "spot" Callaway tcallawa@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tcallawa@redhat.com Blocks|182235 (FE-Legal) |
--- Comment #2 from Tom "spot" Callaway tcallawa@redhat.com --- Not sure why this was blocking FE-Legal. Lifting.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1462412
--- Comment #3 from Iwicki Artur fedora@svgames.pl --- We wanted to make sure the "redistribution only, no modification" licence for the level packs was okay - it seems to match Packaging:Licensing:Shareware, but we wanted to double-check with Legal. https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Shareware
I'll go ahead and file a package request, then.
https://bugzilla.redhat.com/show_bug.cgi?id=1462412
--- Comment #4 from Tom "spot" Callaway tcallawa@redhat.com --- Yeah. Not ideal, but permitted.
https://bugzilla.redhat.com/show_bug.cgi?id=1462412
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- tworld-1.3.2-3.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-b66f4ca0b3
https://bugzilla.redhat.com/show_bug.cgi?id=1462412
--- Comment #5 from Gwyn Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/tworld
https://bugzilla.redhat.com/show_bug.cgi?id=1462412
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1462412
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- tworld-1.3.2-3.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-10cc766f66
https://bugzilla.redhat.com/show_bug.cgi?id=1462412
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- tworld-1.3.2-3.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-4056ef5f5b
https://bugzilla.redhat.com/show_bug.cgi?id=1462412
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- tworld-1.3.2-3.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-b66f4ca0b3
https://bugzilla.redhat.com/show_bug.cgi?id=1462412
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- tworld-1.3.2-3.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-5cc41b463f
https://bugzilla.redhat.com/show_bug.cgi?id=1462412
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- tworld-1.3.2-3.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-79cd34e5e0
https://bugzilla.redhat.com/show_bug.cgi?id=1462412
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1462412
--- Comment #12 from Iwicki Artur fedora@svgames.pl --- The build initially failed for EPEL6 due to libappstream-glib not being available. Since that is used only for validating the appdata.xml file, I edited the EPEL6 spec file to omit that step.
https://bugzilla.redhat.com/show_bug.cgi?id=1462412
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- tworld-1.3.2-3.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-79cd34e5e0
https://bugzilla.redhat.com/show_bug.cgi?id=1462412
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2017-07-05 22:22:36
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- tworld-1.3.2-3.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1462412
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- tworld-1.3.2-3.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1462412
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- tworld-1.3.2-3.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1462412
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- tworld-1.3.2-3.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1462412
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- tworld-1.3.2-3.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org