https://bugzilla.redhat.com/show_bug.cgi?id=1166697

--- Comment #1 from Victor Toso de Carvalho vtosodec@redhat.com --- I forgot to include the Patch1 URL. Patch1 URL: http://www.thatsallfolks.org/~toso/mingw-gst1-good/0001-rtspsrc-fix-for-mike...

https://bugzilla.redhat.com/show_bug.cgi?id=1166697

--- Comment #2 from Marc-Andre Lureau marcandre.lureau@redhat.com --- - why did you package 1.3.2 and not 1.4.4 ? - global gstreamer gstreamer1 doesn't seem to be used - bogus changelog date

Package Review ==============

Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed

===== MUST items =====

Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v2)", "*No copyright* LGPL (v2 or later)", "LGPL (v2 or later)", "GPL (v2 or later)", "Unknown or generated", "MIT/X11 (BSD like) LGPL (v2 or later)", "LGPL (v2 or later) (with incorrect FSF address)", "LGPL", "BSD (2 clause) GPL (v2 or later)", "BSD (3 clause)", "LGPL (v2.1 or later)", "GPL (v2)", "*No copyright* LGPL (v2.1 or later)". 78 files have unknown license. Detailed output of licensecheck in /home/elmarco/pkg/1166697-mingw-gstreamer1-plugins-good/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [?]: Package requires other packages for directories it uses. Note: No known owner of /usr/x86_64-w64-mingw32/sys- root/mingw/share/gstreamer-1.0, /usr/i686-w64-mingw32/sys- root/mingw/share/gstreamer-1.0 [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/i686-w64-mingw32/sys- root/mingw/share/gstreamer-1.0, /usr/x86_64-w64-mingw32/sys- root/mingw/share/gstreamer-1.0

Probably should be fixed in gstreamer1

I would own: (like non-mingw package) {mingw32_datadir}/gstreamer-%{api_version}/presets/

[x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic: [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [?]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified.

Unnecessary with 1.4.4 I guess

[x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.

Rpmlint ------- Checking: mingw32-gstreamer1-plugins-good-1.3.2-1.fc21.noarch.rpm mingw64-gstreamer1-plugins-good-1.3.2-1.fc21.noarch.rpm mingw-gstreamer1-plugins-good-1.3.2-1.fc21.src.rpm mingw32-gstreamer1-plugins-good.noarch: W: spelling-error %description -l en_US GStreamer -> G Streamer, Streamer, Steamer mingw64-gstreamer1-plugins-good.noarch: W: spelling-error %description -l en_US GStreamer -> G Streamer, Streamer, Steamer mingw-gstreamer1-plugins-good.src: W: spelling-error %description -l en_US GStreamer -> G Streamer, Streamer, Steamer mingw-gstreamer1-plugins-good.src:198: W: macro-in-comment %{mingw32_libdir} mingw-gstreamer1-plugins-good.src:198: W: macro-in-comment %{api_version} mingw-gstreamer1-plugins-good.src:266: W: macro-in-comment %{mingw64_libdir} mingw-gstreamer1-plugins-good.src:266: W: macro-in-comment %{api_version} mingw-gstreamer1-plugins-good.src: E: specfile-error warning: bogus date in %changelog: Thu Nov 21 2014 - Victor Toso victortoso@redhat.com - 1.3.2 3 packages and 0 specfiles checked; 1 errors, 7 warnings.

https://bugzilla.redhat.com/show_bug.cgi?id=1166697

--- Comment #3 from Victor Toso de Carvalho vtosodec@redhat.com --- (In reply to Marc-Andre Lureau from comment #2)

• why did you package 1.3.2 and not 1.4.4 ?
• global gstreamer gstreamer1 doesn't seem to be used
• bogus changelog date

Fixed.

Spec URL: http://www.thatsallfolks.org/~toso/mingw-gst1-good/1/mingw-gstreamer1-plugin...

SRPM URL: http://www.thatsallfolks.org/~toso/mingw-gst1-good/1/mingw-gstreamer1-plugin...

https://bugzilla.redhat.com/show_bug.cgi?id=1166697

--- Comment #5 from Victor Toso de Carvalho vtosodec@redhat.com --- (In reply to Marc-Andre Lureau from comment #4)

looks good to me, with a slightly better changelog comment, with mention to this bug would be nice

Included link to this bug

Spec URL: http://www.thatsallfolks.org/~toso/mingw-gst1-good/2/mingw-gstreamer1-plugin...

SRPM URL: http://www.thatsallfolks.org/~toso/mingw-gst1-good/2/mingw-gstreamer1-plugin...

https://bugzilla.redhat.com/show_bug.cgi?id=1166697

Marc-Andre Lureau marcandre.lureau@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?

--- Comment #7 from Marc-Andre Lureau marcandre.lureau@redhat.com --- New Package SCM Request ======================= Package Name: mingw-gstreamer1-plugins-good Short Description: Cross compiled GStreamer1 plug-ins good Upstream URL: http://gstreamer.freedesktop.org/ Owners: victortoso elmarco Branches: f21 InitialCC:

https://bugzilla.redhat.com/show_bug.cgi?id=1166697

Jon Ciesla limburgher@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |

https://bugzilla.redhat.com/show_bug.cgi?id=1166697

Victor Toso victortoso@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841 (FE-NEEDSPONSOR) |

--- Comment #9 from Victor Toso victortoso@redhat.com --- removing the FE-NEEDSPONSOR

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor

https://bugzilla.redhat.com/show_bug.cgi?id=1166697

Jon Ciesla limburgher@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+

https://bugzilla.redhat.com/show_bug.cgi?id=1166697

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED

https://bugzilla.redhat.com/show_bug.cgi?id=1166697

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA

--- Comment #13 from Fedora Update System updates@fedoraproject.org --- mingw-gstreamer1-plugins-good-1.4.4-1.fc21 has been pushed to the Fedora 21 testing repository.