Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189151
Summary: Review Request: xsp Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: bugzilla-sink@leemhuis.info ReportedBy: paul@all-the-johnsons.co.uk QAContact: fedora-package-review@redhat.com
Spec URL: http://www.smmp.salford.ac.uk/packages/xsp.spec SRPM URL: http://www.smmp.salford.ac.uk/packages/xsp-1.1.13-1.src.rpm Description:
xsp is the mono ASP.NET page server
------- Additional Comments From paul@all-the-johnsons.co.uk 2006-04-18 18:20 EST ------- Spec URL: http://www.smmp.salford.ac.uk/packages/xsp.spec SRPM URL: http://www.smmp.salford.ac.uk/packages/xsp-1.1.13-2.src.rpm
libdir now /usr/lib no matter what you build it on spec file alterations
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xsp
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189151
------- Additional Comments From michael@knox.net.nz 2006-04-23 23:04 EST ------- builds on FC5, but rpmlint is not overly happy..
W: xsp incoherent-version-in-changelog 1.1.13-1 1.1.13-2 E: xsp no-binary E: xsp only-non-binary-in-usr-lib E: xsp script-without-shellbang /usr/lib/xsp/2.0/asp-state2.exe.config W: xsp devel-file-in-non-devel-package /usr/lib/pkgconfig/xsp-2.pc E: xsp standard-dir-owned-by-package /usr/share/man/man1 E: xsp script-without-shellbang /usr/lib/xsp/2.0/dbsessmgr2.exe.config E: xsp script-without-shellbang /usr/lib/xsp/1.0/asp-state.exe.config W: xsp devel-file-in-non-devel-package /usr/lib/pkgconfig/xsp.pc E: xsp script-without-shellbang /usr/lib/xsp/1.0/dbsessmgr.exe.config W: xsp one-line-command-in-%post /sbin/ldconfig W: xsp one-line-command-in-%postun /sbin/ldconfig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xsp
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189151
------- Additional Comments From paul@all-the-johnsons.co.uk 2006-04-24 02:26 EST ------- Those are all fine - it's how mono does things (everything goes into _libdir with symlinks to _bindir)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xsp
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189151
------- Additional Comments From michael@knox.net.nz 2006-04-24 03:05 EST ------- Should the config files not be executable?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xsp
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189151
------- Additional Comments From bdpepple@ameritech.net 2006-05-08 17:35 EST ------- MD5Sums: 58facfdb9d13d48f9e8ad5069500081d xsp-1.1.13.tar.gz
Good: * Source URL is canonical * Upstream source tarball verified * Package name conforms to the Fedora Naming Guidelines * Buildroot has all required elements * All paths begin with macros * All necessary BuildRequires listed * Builds fine in Mock.
Bad: * The Group tag should probably reflect the same group as Apache (System Environment/Daemons), since it is a web server. * You have ownership problems with some of your directories that must be fixed. * The %clean section is missing. * Produces the following rpmlint errors: W: xsp incoherent-version-in-changelog 1.1.13-1 1.1.13-2 E: xsp no-binary E: xsp only-non-binary-in-usr-lib E: xsp script-without-shellbang /usr/lib/xsp/2.0/asp-state2.exe.config W: xsp devel-file-in-non-devel-package /usr/lib/pkgconfig/xsp-2.pc E: xsp standard-dir-owned-by-package /usr/share/man/man1 E: xsp script-without-shellbang /usr/lib/xsp/2.0/dbsessmgr2.exe.config E: xsp script-without-shellbang /usr/lib/xsp/1.0/asp-state.exe.config W: xsp devel-file-in-non-devel-package /usr/lib/pkgconfig/xsp.pc E: xsp script-without-shellbang /usr/lib/xsp/1.0/dbsessmgr.exe.config W: xsp one-line-command-in-%post /sbin/ldconfig W: xsp one-line-command-in-%postun /sbin/ldconfig
In particular, the 'standard-dir-owned-by-package' must be fixed. Also, the ChangeLog error must be corrected. The scriptlets for the shared libraries are unnecessary, since as far as I can tell this package doesn't contain any. Most of the others can be ignored, since it is a mono package.
Minor: * The 'rm -rf ${RPM_BUILD_ROOT}' in the %prep section is unnecessary.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xsp
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189151
------- Additional Comments From paul@all-the-johnsons.co.uk 2006-05-08 19:18 EST ------- Spec URL: http://www.smmp.salford.ac.uk/packages/xsp.spec SRPM URL: http://www.smmp.salford.ac.uk/packages/xsp-1.1.13-3.src.rpm
Just about all of the points raised in #5 are fixed with this release
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xsp
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189151
bdpepple@ameritech.net changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bugzilla-sink@leemhuis.info |bdpepple@ameritech.net OtherBugsDependingO|163776 |163778 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xsp
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189151
bdpepple@ameritech.net changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |189150 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xsp
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189151
bdpepple@ameritech.net changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From bdpepple@ameritech.net 2006-05-09 12:27 EST ------- Rest of review in comment #5. Looks pretty good, except for the following issues:
1. The URL should be 'http://www.mono-project.com/ASP.NET#XSP', and the Source URL should be 'http://www.go-mono.com/sources/xsp/%%7Bname%7D-%%7Bversion%7D.tar.gz'. 2. Use '%{_libdir}/%{name}/' instead of '%{_libdir}/xsp/1.0/*'. In general, you want to refrain from using a wildcard to pull in children directories, since this can cause directory ownership issues. 3. The License appears to be BSD, not GPL. 4. The COPYING file should be added to the documentation.
Once these items are corrected, go ahead and import it into FE CVS.
+1 APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xsp
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189151
paul@all-the-johnsons.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xsp
https://bugzilla.redhat.com/show_bug.cgi?id=189151
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide
package-review@lists.fedoraproject.org