https://bugzilla.redhat.com/show_bug.cgi?id=1795068
Bug ID: 1795068 Summary: Review Request: python-diskcache - Disk and file backed persistent cache Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mail@fabian-affolter.ch QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-diskcache.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-diskcache-4.1.0-1.fc31.sr...
Project URL: http://www.grantjenks.com/docs/diskcache/
Description: DiskCache is an Apache 2 licensed disk and file backed cache library, written in pure-Python, and compatible with Django. The cloud-based computing of 2019 puts a premium on memory. Gigabytes of empty space is left on disks asprocesses vie for memory. Among these processes is Memcached (and sometimes Redis) which is used as a cache. Wouldn't it be nice to leverage.
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=41052840
rpmlint output: $ rpmlint python-diskcache-4.1.0-1.fc31.src.rpm python-diskcache.src: W: spelling-error %description -l en_US asprocesses -> as processes, as-processes, processes 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
$ rpmlint python3-diskcache-4.1.0-1.fc31.noarch.rpm python3-diskcache.noarch: W: spelling-error %description -l en_US asprocesses -> as processes, as-processes, processes 1 packages and 0 specfiles checked; 0 errors, 1 warnings.
Fedora Account System Username: fab
https://bugzilla.redhat.com/show_bug.cgi?id=1795068
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |decathorpe@gmail.com Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Doc Type|--- |If docs needed, set a value Flags| |fedora-review?
--- Comment #1 from Fabio Valentini decathorpe@gmail.com --- I can review this package.
Initial comments / suggestions / recommendations:
1) It looks like you're using pypi source tarball. You should be able to just use "%{pypi_source}" for that.
2) You could deduplicate the %descriptions (like I commented on python-shodan).
3) Please use trailing slashes for directories in %files:
%{python3_sitelib}/%{pypi_name}/ %{python3_sitelib}/%{pypi_name}-%{version}-py%{python3_version}.egg-info/
Other than that, looks good.
Let me know when the package is ready for the formal review.
https://bugzilla.redhat.com/show_bug.cgi?id=1795068
--- Comment #2 from Fabian Affolter mail@fabian-affolter.ch --- Thanks for your help.
(In reply to Fabio Valentini from comment #1)
- It looks like you're using pypi source tarball. You should be able to
just use "%{pypi_source}" for that.
Fixed
- You could deduplicate the %descriptions (like I commented on
python-shodan).
I would like to keep it simple.
- Please use trailing slashes for directories in %files:
%{python3_sitelib}/%{pypi_name}/ %{python3_sitelib}/%{pypi_name}-%{version}-py%{python3_version}.egg-info/
Fixed
Updated files: Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-diskcache.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-diskcache-4.1.0-2.fc31.sr...
https://bugzilla.redhat.com/show_bug.cgi?id=1795068
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #3 from Fabio Valentini decathorpe@gmail.com --- Looks good now. Thanks! Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1795068
--- Comment #4 from Fabian Affolter mail@fabian-affolter.ch --- Thanks for your support.
https://bugzilla.redhat.com/show_bug.cgi?id=1795068
--- Comment #5 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-diskcache
https://bugzilla.redhat.com/show_bug.cgi?id=1795068
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-ac573bf385 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-ac573bf385
https://bugzilla.redhat.com/show_bug.cgi?id=1795068
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- python-diskcache-4.1.0-2.fc32 has been pushed to the Fedora 32 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-ac573bf385
https://bugzilla.redhat.com/show_bug.cgi?id=1795068
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- python-diskcache-4.1.0-2.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-d79460fdf7
https://bugzilla.redhat.com/show_bug.cgi?id=1795068
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- python-diskcache-4.1.0-2.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-a1370763de
https://bugzilla.redhat.com/show_bug.cgi?id=1795068
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2020-03-27 08:00:41
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-ac573bf385 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1795068
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-d79460fdf7 has been pushed to the Fedora 30 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1795068
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2020-a1370763de has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org