Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: at-spi2-core - Protocol definitions and daemon for D-Bus at-spi
https://bugzilla.redhat.com/show_bug.cgi?id=544628
Summary: at-spi2-core - Protocol definitions and daemon for D-Bus at-spi Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: mclasen@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: ---
The accessibility framework is being rewritten on top of D-Bus to get rid of ORBit/CORBA. This package is an early release of the core of the new framework.
I'm packaging it now to allow people to start testing and reporting problems. For now, the at-spi2 packages will have Conflicts with the at-spi packages. This will be replaced by Provides/Obsoletes, once at-spi2 is feature-complete and ready for prime time.
SRPM: http://mclasen.fedorapeople.org/at-spi2/at-spi2-core-0.1.3-1.fc12.src.rpm Spec: http://mclasen.fedorapeople.org/at-spi2/at-spi2-core.spec
Mock complains about three empty interface definitions, which is probably a problem with the xslt script that converts them from the docs. I'll report that upstream.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544628
Thomas Spura tomspur@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tomspur@fedoraproject.org
--- Comment #1 from Thomas Spura tomspur@fedoraproject.org 2009-12-05 16:35:59 EDT --- Just a few comments:
- There is no conflicts with the at-spi packages as described above, yet. - source url is wrong: should be download*DOT*gnome*DOT*org
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544628
--- Comment #2 from Matthias Clasen mclasen@redhat.com 2009-12-06 11:03:56 EDT --- This one is not conflicting. The at-spi2-atk and pyatspi packages are, though.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544628
Thomas Spura tomspur@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Blocks| |544629, 544630 AssignedTo|nobody@fedoraproject.org |tomspur@fedoraproject.org Flag| |fedora-review+
--- Comment #3 from Thomas Spura tomspur@fedoraproject.org 2009-12-21 07:37:37 EDT --- Review:
Good: - license ok - name ok - buildroot ok (unneeded in fedora) - parallel make - %clean section there - %files section ok * owns all directories it creates * requires d-bus for one folder - buildrequires/requires ok - builds in koji http://koji.fedoraproject.org/koji/taskinfo?taskID=1882908 - noarch not possible - no *.la files - no shared libs - %doc ok
Needswork: - URL still wrong, see comment #1 - from https://fedoraproject.org/wiki/Packaging/Guidelines#Libexecdir 'Packagers are highly encouraged to store libexecdir files in a package-specific subdirectory of %{_libexecdir}, such as %{_libexecdir}/%{name}' - What's the status of the xslt script?
############################
Please fix the url; subdirectory of %{_libexecdir} and 'Is programm working as expected?' are just 'should' items.
############################
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544628
--- Comment #4 from Matthias Clasen mclasen@redhat.com 2009-12-22 19:49:04 EDT --- Thanks for the review. I've fixed the url in the package that I am going to import..
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544628
Matthias Clasen mclasen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #5 from Matthias Clasen mclasen@redhat.com 2009-12-22 19:50:31 EDT --- New Package CVS Request ======================= Package Name: at-spi2-core Short Description: Protocol definitions and daemon for D-Bus at-spi Owners: mclasen Branches: InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544628
Dennis Gilmore dennis@ausil.us changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #6 from Dennis Gilmore dennis@ausil.us 2009-12-23 14:51:22 EDT --- CVS Done
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=544628
Matthias Clasen mclasen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
--- Comment #7 from Matthias Clasen mclasen@redhat.com 2010-01-04 21:27:17 EDT --- Build done.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla