https://bugzilla.redhat.com/show_bug.cgi?id=2072972
Bug ID: 2072972 Summary: Review Request: perl-IP-Geolocation-MMDB - Read MaxMind DB files Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: andreas@andreasvoegele.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://copr-dist-git.fedorainfracloud.org/cgit/voegelas/fedora/perl-IP-Geol... SRPM URL: https://download.copr.fedorainfracloud.org/results/voegelas/fedora/fedora-ra... Description: A Perl module that reads MaxMind DB files and maps IP addresses to location information such as country and city names Fedora Account System Username: voegelas
perl-Alien-libmaxminddb and this module are my first packages. I am the upstream author of both modules. I am looking for a sponsor.
IP::Geolocation::MMDB is an alternative to the depracted Perl module MaxMind::DB::Reader.
https://bugzilla.redhat.com/show_bug.cgi?id=2072972
Michal Josef Spacek mspacek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |mspacek@redhat.com Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |mspacek@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=2072972
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=2072972
--- Comment #1 from Michal Josef Spacek mspacek@redhat.com --- Sorry, I forgot about this review.
https://bugzilla.redhat.com/show_bug.cgi?id=2072972
--- Comment #2 from Michal Josef Spacek mspacek@redhat.com --- @andreas@andreasvoegele.com Hi Andreas, could we update to last version of module from CPAN?
I was looking at https://bugzilla.redhat.com/show_bug.cgi?id=2072968 and the issues in this are similar. 1) License 2) MODULE_COMPAT
https://bugzilla.redhat.com/show_bug.cgi?id=2072972
--- Comment #3 from Andreas Vögele andreas@andreasvoegele.com --- Hello Michal,
thanks a lot for the review. I've removed the MODULE_COMPAT requirement. I had already updated the version and the license in Copr. Today's build with review output in the "fedora-review" subfolder is here:
https://download.copr.fedorainfracloud.org/results/voegelas/fedora/fedora-ra...
Kind regards, Andreas
Spec URL: https://download.copr.fedorainfracloud.org/results/voegelas/fedora/fedora-ra... SRPM URL: https://download.copr.fedorainfracloud.org/results/voegelas/fedora/fedora-ra... Description: A Perl module that reads MaxMind DB files and maps IP addresses to location information such as country and city names Fedora Account System Username: voegelas
https://bugzilla.redhat.com/show_bug.cgi?id=2072972 Bug 2072972 depends on bug 2072968, which changed state.
Bug 2072968 Summary: Review Request: perl-Alien-libmaxminddb - Find libmaxminddb https://bugzilla.redhat.com/show_bug.cgi?id=2072968
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=2072972
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ppisar@redhat.com Blocks|177841 (FE-NEEDSPONSOR) |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=2072972
--- Comment #4 from Michal Josef Spacek mspacek@redhat.com --- Hi Andreas,
There is one missing thing with not explicitly named files in spec file. Need to name files in %{perl_vendorlib}/ and %{_mandir}/man3/ See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists
https://bugzilla.redhat.com/show_bug.cgi?id=2072972
Michal Josef Spacek mspacek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #6 from Michal Josef Spacek mspacek@redhat.com --- Source file is ok Summary is ok License is ok Description is ok URL and Source are ok All tests passed BuildRequires are ok
$ rpm -qp --requires perl-IP-Geolocation-MMDB-1.010-1.fc39.x86_64.rpm | sort | uniq -c | grep -v rpmlib 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libc.so.6()(64bit) 1 libmaxminddb.so.0()(64bit) 1 libperl.so.5.36()(64bit) 1 perl(IP::Geolocation::MMDB::Metadata) 1 perl-libs 1 perl(Math::BigInt) >= 1.999806 1 perl(:MODULE_COMPAT_5.36.1) 1 perl(utf8) 1 perl(:VERSION) >= 5.16.0 1 perl(warnings) 1 perl(XSLoader) 1 rtld(GNU_HASH) Binary requires are Ok.
$ rpm -qp --provides perl-IP-Geolocation-MMDB-1.010-1.fc39.x86_64.rpm | sort | uniq -c 1 perl(IP::Geolocation::MMDB::Metadata) = 1.010 1 perl-IP-Geolocation-MMDB(x86-64) = 1.010-1.fc39 1 perl(IP::Geolocation::MMDB) = 1.010 1 perl-IP-Geolocation-MMDB = 1.010-1.fc39 Binary provides are Ok.
$ rpmlint perl-IP-Geolocation-MMDB-* 4 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.3 s
Rpmlint is ok
The package is in line with Fedora and Perl packaging guide lines.
Resolution: approved
https://bugzilla.redhat.com/show_bug.cgi?id=2072972
--- Comment #7 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-IP-Geolocation-MMDB
https://bugzilla.redhat.com/show_bug.cgi?id=2072972
Andreas Vögele andreas@andreasvoegele.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |RAWHIDE Fixed In Version| |perl-IP-Geolocation-MMDB-1. | |010-1.fc39 Status|ASSIGNED |CLOSED Last Closed| |2023-07-05 13:33:42
package-review@lists.fedoraproject.org