https://bugzilla.redhat.com/show_bug.cgi?id=1434482

Petr Pisar ppisar@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1434503

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1434503 [Bug 1434503] Review Request: perl-Dist-Zilla-Plugin-PodWeaver - Weave your POD together from configuration and Dist::Zilla

https://bugzilla.redhat.com/show_bug.cgi?id=1434482

Jitka Plesnikova jplesnik@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+

--- Comment #1 from Jitka Plesnikova jplesnik@redhat.com --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed

BuildRequires are almost ok FIX: Please remove duplicity perl(utf8) from BRs.

$ rpm -qp --requires perl-Pod-Weaver-4.015-1.fc27.noarch.rpm | sort | uniq -c 1 perl(:MODULE_COMPAT_5.24.1) 1 perl(Config::MVP) >= 2 1 perl(Config::MVP::Assembler) 1 perl(Config::MVP::Assembler::WithBundles) 1 perl(Config::MVP::Reader::Finder) 1 perl(DateTime) 1 perl(File::Spec) 1 perl(List::MoreUtils) 1 perl(List::Util) >= 1.33 1 perl(Log::Dispatchouli) >= 1.100710 1 perl(Module::Runtime) 1 perl(Moose) 1 perl(Moose::Role) 1 perl(Moose::Util::TypeConstraints) 1 perl(Params::Util) 1 perl(Pod::Elemental) >= 0.100220 1 perl(Pod::Elemental::Document) 1 perl(Pod::Elemental::Element::Nested) 1 perl(Pod::Elemental::Element::Pod5::Command) 1 perl(Pod::Elemental::Element::Pod5::Ordinary) 1 perl(Pod::Elemental::Element::Pod5::Region) 1 perl(Pod::Elemental::Element::Pod5::Verbatim) 1 perl(Pod::Elemental::Selectors) 1 perl(Pod::Elemental::Transformer::Gatherer) 1 perl(Pod::Elemental::Transformer::Nester) 1 perl(Pod::Elemental::Transformer::Pod5) 1 perl(Pod::Elemental::Types) 1 perl(Pod::Weaver::Config::Assembler) 1 perl(Pod::Weaver::Config::Finder) 1 perl(Pod::Weaver::Plugin::H1Nester) 1 perl(Pod::Weaver::Role::Plugin) 1 perl(String::Flogger) >= 1 1 perl(String::Formatter) >= 0.100680 1 perl(String::RewritePrefix) 1 perl(Text::Wrap) 1 perl(namespace::autoclean) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok.

$ rpm -qp --provides perl-Pod-Weaver-4.015-1.fc27.noarch.rpm | sort | uniq -c 1 perl(Pod::Weaver) = 4.015 1 perl(Pod::Weaver::Config) = 4.015 1 perl(Pod::Weaver::Config::Assembler) = 4.015 1 perl(Pod::Weaver::Config::Finder) = 4.015 1 perl(Pod::Weaver::Plugin::EnsurePod5) = 4.015 1 perl(Pod::Weaver::Plugin::H1Nester) = 4.015 1 perl(Pod::Weaver::Plugin::SingleEncoding) = 4.015 1 perl(Pod::Weaver::Plugin::Transformer) = 4.015 1 perl(Pod::Weaver::PluginBundle::CorePrep) = 4.015 1 perl(Pod::Weaver::PluginBundle::Default) = 4.015 1 perl(Pod::Weaver::Role::Dialect) = 4.015 1 perl(Pod::Weaver::Role::Finalizer) = 4.015 1 perl(Pod::Weaver::Role::Plugin) = 4.015 1 perl(Pod::Weaver::Role::Preparer) = 4.015 1 perl(Pod::Weaver::Role::Section) = 4.015 1 perl(Pod::Weaver::Role::StringFromComment) = 4.015 1 perl(Pod::Weaver::Role::Transformer) = 4.015 1 perl(Pod::Weaver::Section::Authors) = 4.015 1 perl(Pod::Weaver::Section::Bugs) = 4.015 1 perl(Pod::Weaver::Section::Collect) = 4.015 1 perl(Pod::Weaver::Section::Generic) = 4.015 1 perl(Pod::Weaver::Section::Leftovers) = 4.015 1 perl(Pod::Weaver::Section::Legal) = 4.015 1 perl(Pod::Weaver::Section::Name) = 4.015 1 perl(Pod::Weaver::Section::Region) = 4.015 1 perl(Pod::Weaver::Section::Version) = 4.015 1 perl-Pod-Weaver = 4.015-1.fc27 Binary provides are Ok.

$ rpmlint ./perl-Pod-Weaver* 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Rpmlint is ok

Please correct 'FIX' issue.

The package looks good. Approved

https://bugzilla.redhat.com/show_bug.cgi?id=1434482

Petr Pisar ppisar@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Fixed In Version| |perl-Pod-Weaver-4.015-1.fc2 | |7 Resolution|--- |RAWHIDE Last Closed| |2017-03-22 11:15:09

--- Comment #3 from Petr Pisar ppisar@redhat.com --- Thank you for the review and the repository. I removed the duplicated dependency.