Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: perl-MooseX-SimpleConfig - Moose role for setting attributes from a simple configfile
https://bugzilla.redhat.com/show_bug.cgi?id=483557
Summary: Review Request: perl-MooseX-SimpleConfig - Moose role for setting attributes from a simple configfile Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: allisson@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://allisson.fedorapeople.org/packages/perl-MooseX-SimpleConfig/perl-Moos...
SRPM URL: http://allisson.fedorapeople.org/packages/perl-MooseX-SimpleConfig/perl-Moos...
Description: This role loads simple configfiles to set object attributes. It is based on the abstract role MooseX::ConfigFromFile, and uses Config::Any to load your configfile. Config::Any will in turn support any of a variety of different config formats, detected by the file extension. See Config::Any for more details about supported formats.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483557
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@gmail.com AssignedTo|nobody@fedoraproject.org |panemade@gmail.com Flag| |fedora-review+
--- Comment #1 from Parag AN(पराग) panemade@gmail.com 2009-02-02 11:24:56 EDT --- Review: + package builds in mock (rawhide i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1099483 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 6aacecf18afbf17f97e666c0197a5e18 MooseX-SimpleConfig-0.03.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs Files=3, Tests=12, 1 wallclock secs ( 0.02 usr 0.01 sys + 1.62 cusr 0.10 csys = 1.75 CPU) + Package perl-MooseX-SimpleConfig-0.03-1.fc11 -> Provides: perl(MooseX::SimpleConfig) = 0.03 Requires: perl(Config::Any) perl(Moose::Role)
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483557
Allisson Azevedo allisson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #2 from Allisson Azevedo allisson@gmail.com 2009-02-02 11:30:50 EDT --- New Package CVS Request ======================= Package Name: perl-MooseX-SimpleConfig Short Description: Moose role for setting attributes from a simple configfile Owners: allisson Branches: F-9 F-10
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483557
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #3 from Kevin Fenzi kevin@tummy.com 2009-02-02 23:18:46 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483557
Allisson Azevedo allisson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483557
Iain Arnell iarnell@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |iarnell@gmail.com Flag|fedora-cvs+ |fedora-cvs?
--- Comment #4 from Iain Arnell iarnell@gmail.com 2012-01-15 04:24:49 EST --- Package Change Request ====================== Package Name: perl-MooseX-SimpleConfig InitialCC: perl-sig
Please add perl-sig to this package with watchbugzilla and watchcommits bits on all fedora branches.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483557
--- Comment #5 from Jon Ciesla limburgher@gmail.com 2012-01-15 17:17:27 EST --- Done.
package-review@lists.fedoraproject.org