https://bugzilla.redhat.com/show_bug.cgi?id=1563160
Bug ID: 1563160 Summary: Review Request: perl-Test-Log-Log4perl - Test log4perl Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jplesnik@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://jplesnik.fedorapeople.org/perl-Test-Log-Log4perl/perl-Test-Log-Log4p... SRPM URL: https://jplesnik.fedorapeople.org/perl-Test-Log-Log4perl/perl-Test-Log-Log4p...
Description: This module can be used to test that you're logging the right thing with Log::Log4perl. It checks that we get what, and only what, we expect logged by your code.
Fedora Account System Username: jplesnik@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1563160
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1563021
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1563021 [Bug 1563021] perl-Config-Model-Tester-3.005 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1563160
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |ppisar@redhat.com Assignee|nobody@fedoraproject.org |ppisar@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1563160
--- Comment #1 from Petr Pisar ppisar@redhat.com --- URL and Source0 addresses are Ok. Source archive (SHA-256: 23ebbb05893a05ebfe397fbce55152df8f9d6500125a8042f1aa6cfa93fc23c4) is original. Ok. Summary is Ok. Description is Ok. License verified from lib/Test/Log/Log4perl.pm. Ok. No XS code, noarch BuildArch is Ok.
FIX: Tests do not pass if perl-Test-Synopsis is installed:
+ make test PERL_DL_NONLAZY=1 "/usr/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'inc', 'blib/lib', 'blib/arch')" t/*.t xt/*.t t/01basic.t ...... ok t/02ignore.t ..... ok t/03match.t ...... ok t/04re.t ......... ok xt/perlcritic.t .. skipped: Test::Perl::Critic is not installed. xt/pod.t ......... ok xt/podspell.t .... ok xt/synopsis.t .... 1/? # Failed test 'lib/Test/Log/Log4perl.pm' # at /usr/share/perl5/vendor_perl/Test/Synopsis.pm line 24. # Can't locate Log/Log4Perl.pm in @INC (you may need to install the Log::Log4Perl module) (@INC contains: /home/test/rpmbuild/BUILD/Test-Log-Log4perl-0.32/inc /home/test/rpmbuild/BUILD/Test-Log-Log4perl-0.32/blib/lib /home/test/rpmbuild/BUILD/Test-Log-Log4perl-0.32/blib/arch /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5 .) at lib/Test/Log/Log4perl.pm line 24. # BEGIN failed--compilation aborted at lib/Test/Log/Log4perl.pm line 24. # Looks like you failed 1 test of 1. xt/synopsis.t .... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests
Obviously defining empty author_tests() in Makefile.PL does not help. Either patch out calls to author_tests() and similar unwanted features whose dependencies are not specified or keep empty ./inc directory.
https://bugzilla.redhat.com/show_bug.cgi?id=1563160
--- Comment #2 from Jitka Plesnikova jplesnik@redhat.com --- Updated files on the same links.
https://bugzilla.redhat.com/show_bug.cgi?id=1563160
--- Comment #4 from Jason Tibbitts tibbs@math.uh.edu --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Test-Log-Log4perl
https://bugzilla.redhat.com/show_bug.cgi?id=1563160
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Petr Pisar ppisar@redhat.com --- All tests pass. Ok.
$ rpmlint perl-Test-Log-Log4perl.spec ../SRPMS/perl-Test-Log-Log4perl-0.32-1.fc29.src.rpm ../RPMS/noarch/perl-Test-Log-Log4perl-0.32-1.fc29.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/noarch/perl-Test-Log-Log4perl-0.32-1.fc29.noarch.rpm drwxr-xr-x 2 root root 0 Apr 3 16:34 /usr/share/doc/perl-Test-Log-Log4perl -rw-r--r-- 1 root root 419 Feb 16 2013 /usr/share/doc/perl-Test-Log-Log4perl/Changes -rw-r--r-- 1 root root 7521 Feb 16 2013 /usr/share/doc/perl-Test-Log-Log4perl/README -rw-r--r-- 1 root root 3854 Apr 3 16:34 /usr/share/man/man3/Test::Log::Log4perl.3pm.gz drwxr-xr-x 2 root root 0 Apr 3 16:34 /usr/share/perl5/vendor_perl/Test drwxr-xr-x 2 root root 0 Apr 3 16:34 /usr/share/perl5/vendor_perl/Test/Log -rw-r--r-- 1 root root 15160 Feb 16 2013 /usr/share/perl5/vendor_perl/Test/Log/Log4perl.pm File layout and permissions are Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-Test-Log-Log4perl-0.32-1.fc29.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.26.2) 1 perl(:VERSION) >= 5.8.8 1 perl(base) 1 perl(Carp) 1 perl(Log::Log4perl) 1 perl(Log::Log4perl::Logger) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(Test::Builder) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok.
$ rpm -q --provides -p ../RPMS/noarch/perl-Test-Log-Log4perl-0.32-1.fc29.noarch.rpm | sort -f | uniq -c 1 perl(Log::Log4perl::Logger::IgnoreAll) 1 perl(Log::Log4perl::Logger::Interception) 1 perl(Test::Log::Log4perl) = 0.32 1 perl-Test-Log-Log4perl = 0.32-1.fc29 Binary provides are Ok.
$ resolvedeps rawhide ../RPMS/noarch/perl-Test-Log-Log4perl-0.32-1.fc29.noarch.rpm Binary dependencies resolvable. Ok.
The package builds in F29 (https://koji.fedoraproject.org/koji/taskinfo?taskID=26143021). Ok.
The package is in line with Fedora and Perl packaging guidelines. Resolution: Package APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1563160
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Fixed In Version| |perl-Test-Log-Log4perl-0.32 | |-1.fc29 Resolution|--- |RAWHIDE Last Closed| |2018-04-04 02:27:47
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com