[Bug 413321] New: Review Request: inotify - An inotify-enabled tail replacement - package-review

List overview All Threads
Download

newer

[Bug 413321] New: Review Request: inotify - An inotify-enabled tail replacement

older

[Bug 405161] New: Review Request:...

[Bug 426738] New: Review Request:...

Red Hat Bugzilla

5 Dec 2007 5 Dec '07

6:19 p.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=413321

Summary: Review Request: inotify - An inotify-enabled tail replacement Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: jkeating@redhat.com QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com

Spec URL: http://jkeating.fedorapeople.org/review/inotail.spec SRPM URL: http://jkeating.fedorapeople.org/review/inotail-0.5-2.src.rpm Description: inotail is a replacement for the 'tail' program found in the base installation of every Linux/UNIX system. It makes use of the inotify infrastructure in recent versions of the Linux kernel to speed up tailing files in the follow mode (the '-f' option). Standard tail polls the file every second by default while inotail listens to special events sent by the kernel through the inotify API to determine whether a file needs to be reread.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Show replies by date

Red Hat Bugzilla

5 Dec 5 Dec

6:38 p.m.

New subject: [Bug 413321] Review Request: inotail - An inotify-enabled tail replacement

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: inotail - An inotify-enabled tail replacement Alias: inotail

https://bugzilla.redhat.com/show_bug.cgi?id=413321

peter@thecodergeek.com changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

7:01 p.m.

New subject: [Bug 413321] Review Request: inotail - An inotify-enabled tail replacement

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: inotail - An inotify-enabled tail replacement Alias: inotail

https://bugzilla.redhat.com/show_bug.cgi?id=413321

panemade@gmail.com changed:

------- Additional Comments From panemade@gmail.com 2007-12-05 22:01 EST ------- do we need to care about CFLAGS here? man page is not following upstream timestamp.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

6 Dec 6 Dec

3:58 a.m.

New subject: [Bug 413321] Review Request: inotail - An inotify-enabled tail replacement

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: inotail - An inotify-enabled tail replacement Alias: inotail

https://bugzilla.redhat.com/show_bug.cgi?id=413321

------- Additional Comments From jkeating@redhat.com 2007-12-06 06:58 EST ------- (In reply to comment #1)

...

do we need to care about CFLAGS here?

Oops, forgot that.

...

man page is not following upstream timestamp.

Not sure what you mean by this. The man page is part of the archive, rpmbuild gzips it during install.

http://jkeating.fedorapeople.org/review/inotail.spec http://jkeating.fedorapeople.org/review/inotail-0.5-3.src.rpm

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

4:52 a.m.

New subject: [Bug 413321] Review Request: inotail - An inotify-enabled tail replacement

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: inotail - An inotify-enabled tail replacement Alias: inotail

https://bugzilla.redhat.com/show_bug.cgi?id=413321

panemade@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+

------- Additional Comments From panemade@gmail.com 2007-12-06 07:52 EST -------

(In reply to comment #2)

...

(In reply to comment #1)

...
do we need to care about CFLAGS here?

Oops, forgot that.

...
man page is not following upstream timestamp.

Not sure what you mean by this. The man page is part of the archive, rpmbuild gzips it during install.

I guess its not needed( only for copying commands in SPEC) as per said in http://fedoraproject.org/wiki/Packaging/Guidelines#head-0239576e441f9ef53d17...

I see no issues with new SPEC. rpmlint is clean source matched upstream 82d4d05f86d6069e95c4b73e4004f15f inotail-0.5.tar.bz2 Packaging look good. APPORVED.

Also, You may like to add disttag.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

5:03 a.m.

New subject: [Bug 413321] Review Request: inotail - An inotify-enabled tail replacement

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: inotail - An inotify-enabled tail replacement Alias: inotail

https://bugzilla.redhat.com/show_bug.cgi?id=413321

jkeating@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?

------- Additional Comments From jkeating@redhat.com 2007-12-06 08:03 EST ------- oh yeah, the dist tag wasn't on the source of the spec, I added it.

New Package CVS Request ======================= Package Name: inotail Short Description: An inotify-enabled tail replacement Owners: jkeating Branches: InitialCC: Cvsextras Commits: yes

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

1:04 p.m.

New subject: [Bug 413321] Review Request: inotail - An inotify-enabled tail replacement

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: inotail - An inotify-enabled tail replacement Alias: inotail

https://bugzilla.redhat.com/show_bug.cgi?id=413321

kevin@tummy.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

------- Additional Comments From kevin@tummy.com 2007-12-06 16:04 EST ------- cvs done.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

15 Dec 15 Dec

1:11 a.m.

New subject: [Bug 413321] Review Request: inotail - An inotify-enabled tail replacement

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: inotail - An inotify-enabled tail replacement Alias: inotail

https://bugzilla.redhat.com/show_bug.cgi?id=413321

panemade@gmail.com changed:

------- Additional Comments From panemade@gmail.com 2007-12-15 04:11 EST ------- Package already built for requested branch. Therefore, closing this review now.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

14 Jan 14 Jan

1:01 a.m.

New subject: [Bug 413321] Review Request: inotail - An inotify-enabled tail replacement

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: inotail - An inotify-enabled tail replacement Alias: inotail

https://bugzilla.redhat.com/show_bug.cgi?id=413321

moritz@barsnick.net changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |moritz@barsnick.net

------- Additional Comments From moritz@barsnick.net 2008-01-14 04:01 EST ------- Can I re-open or append for improval? (If not, I'll file a new ticket.)

The SPEC file has such a line in the %install section: chmod 0755 %{buildroot}/usr/bin/inotail

a) Permissions can (or should?) be forced in the %files section using %attr. b) %{buildroot}/usr/bin must comply with the %files's %{_bindir}. One of the two is wrong. Assuming this tool has a very hand-crafted Makefile, and it is built using "prefix=%{buildroot}/usr", "/usr/bin" may (or may not) be the correct choice.

Thanks for the tool, by the way. :)

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

6010

Age (days ago)

6049

Last active (days ago)

package-review@lists.fedoraproject.org

8 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla