https://bugzilla.redhat.com/show_bug.cgi?id=824057
Bug ID: 824057 QA Contact: extras-qa@fedoraproject.org Severity: unspecified Version: rawhide Priority: unspecified CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: fcitx-hangul - Hangul Engine for Fcitx Regression: --- Story Points: --- Classification: Fedora OS: Unspecified Reporter: liangsuilong@gmail.com Type: Bug Documentation: --- Hardware: Unspecified Mount Type: --- Status: NEW Component: Package Review Product: Fedora
SPEC: http://liangsuilong.fedorapeople.org/fcitx/fcitx-hangul.spec SRPM: http://liangsuilong.fedorapeople.org/fcitx/fcitx-hangul-0.1.1-1.fc16.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4094896
Description: Fcitx-hangul is a Hangul engine wrapper for Fcitx. It Provides Korean input method from libhangul.
https://bugzilla.redhat.com/show_bug.cgi?id=824057
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |panemade@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=824057
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #1 from Parag AN(पराग) panemade@gmail.com --- Review:-
+ Koji build used ->http://koji.fedoraproject.org/koji/taskinfo?taskID=4094896
+ rpmlint on rpms gave fcitx-hangul.src: W: spelling-error %description -l en_US libhangul -> Hangul fcitx-hangul.src: W: invalid-url Source0: http://fcitx.googlecode.com/files/fcitx-hangul-0.1.1.tar.xz HTTP Error 404: Not Found fcitx-hangul.x86_64: W: spelling-error %description -l en_US libhangul -> Hangul fcitx-hangul.x86_64: E: incorrect-fsf-address /usr/share/doc/fcitx-hangul-0.1.1/COPYING 2 packages and 0 specfiles checked; 1 errors, 3 warnings.
+ Source verified with upstream as (sha1sum) 45ce2f8ee5b9c1f7940bee5e0e424391602aa0e3 fcitx-hangul-0.1.1.tar.xz 45ce2f8ee5b9c1f7940bee5e0e424391602aa0e3 ../SOURCES/fcitx-hangul-0.1.1.tar.xz
Suggestions: 1) each pushd command should have corresponding popd. please add it in %build
2) License should be GPLv2+ and BSD. Add comment above license tag like # The entire source code is GPLv2+ except symbol.txt which is BSD
APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=824057
--- Comment #2 from Parag AN(पराग) panemade@gmail.com --- I seem to be overlooked for locale handling in fcitx packages. The correct way to handle locale files is remove manually generation of %{name}.lang in spec file and use %find_lang %{name} at the end of %install section.
https://bugzilla.redhat.com/show_bug.cgi?id=824057
--- Comment #3 from Liang Suilong liangsuilong@gmail.com --- New Package SCM Request ======================= Package Name: fcitx-hangul Short Description: Hangul Engine for Fcitx Owners: liangsuilong Branches: f15 f16 f17 el6 InitialCC: i18n-team
https://bugzilla.redhat.com/show_bug.cgi?id=824057
Liang Suilong liangsuilong@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
https://bugzilla.redhat.com/show_bug.cgi?id=824057
--- Comment #4 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=824057
--- Comment #5 from Parag AN(पराग) panemade@gmail.com --- any update here?
https://bugzilla.redhat.com/show_bug.cgi?id=824057
--- Comment #6 from Parag AN(पराग) panemade@gmail.com --- any update here?
https://bugzilla.redhat.com/show_bug.cgi?id=824057
--- Comment #7 from Parag AN(पराग) panemade@gmail.com --- Can you please build the package in fedora so that it will be available for testing?
https://bugzilla.redhat.com/show_bug.cgi?id=824057
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(liangsuilong@gmai | |l.com)
--- Comment #8 from Parag AN(पराग) panemade@gmail.com --- liangsuilong, If you are busy with your work then please allow me to request SCM for this package and build it in Fedora so that people can use this.
https://bugzilla.redhat.com/show_bug.cgi?id=824057
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=824057
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- fcitx-hangul-0.1.1-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/fcitx-hangul-0.1.1-1.fc16
https://bugzilla.redhat.com/show_bug.cgi?id=824057
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- fcitx-hangul-0.1.1-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/fcitx-hangul-0.1.1-1.fc17
https://bugzilla.redhat.com/show_bug.cgi?id=824057
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- fcitx-hangul-0.1.1-1.fc17 has been pushed to the Fedora 17 testing repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=824057
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |NEXTRELEASE Flags|needinfo?(liangsuilong@gmai | |l.com) | Last Closed| |2012-12-10 23:27:13
--- Comment #12 from Parag AN(पराग) panemade@gmail.com --- I suppose this can be closed as packages are already in repositories.
package-review@lists.fedoraproject.org