Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: python-minihallib - Library to handle HAL devices and events

https://bugzilla.redhat.com/show_bug.cgi?id=333871

panemade@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |panemade@gmail.com Status|NEW |ASSIGNED Flag| |fedora-review?

------- Additional Comments From panemade@gmail.com 2007-10-16 07:38 EST ------- mock build went fine for i386

rpmlint complained python-minihallib.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/minihallib/HALEventerThread.py 0644 This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere.

python-minihallib.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/minihallib/HALManager.py 0644 This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: python-minihallib - Library to handle HAL devices and events

https://bugzilla.redhat.com/show_bug.cgi?id=333871

------- Additional Comments From andy@smile.org.ua 2007-10-16 09:50 EST ------- Please, review temporary package: ftp://toaster.asplinux.com.ua/pub/people/andy/extras/python-minihallib-0.1.7- 2.0.120asp.src.rpm

Note: it is contained modified tarball. I'll put these changed into upstream under version 0.1.8 after you reference.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: python-minihallib - Library to handle HAL devices and events

https://bugzilla.redhat.com/show_bug.cgi?id=333871

------- Additional Comments From panemade@gmail.com 2007-10-16 23:59 EST ------- Build log from new SRPM showed warning: File listed twice: /usr/lib/python2.5/site-packages/minihallib

Use only %{python_sitelib}/* in %files as suggested in sample SPEC given in eggs guidelines.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: python-minihallib - Library to handle HAL devices and events

https://bugzilla.redhat.com/show_bug.cgi?id=333871

panemade@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+

------- Additional Comments From panemade@gmail.com 2007-10-17 04:18 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream. 815cf1a0c7d289f6f9bafc504066a308 minihallib-0.1.8.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags are honoured correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Package python-minihallib-0.1.8-2.fc8 -> Requires: dbus-glib >= 0.62 dbus-python >= 0.62 hal >= 0.5.6 python(abi) = 2.5 + Not a GUI app.

APPROVED.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: python-minihallib - Library to handle HAL devices and events

https://bugzilla.redhat.com/show_bug.cgi?id=333871

kevin@tummy.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

------- Additional Comments From kevin@tummy.com 2007-10-17 12:32 EST ------- cvs done.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: python-minihallib - Library to handle HAL devices and events

https://bugzilla.redhat.com/show_bug.cgi?id=333871

------- Additional Comments From updates@fedoraproject.org 2007-10-24 03:01 EST ------- python-minihallib-0.1.8-2.fc7 has been pushed to the Fedora 7 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update python-minihallib'

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: python-minihallib - Library to handle HAL devices and events

https://bugzilla.redhat.com/show_bug.cgi?id=333871

updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |CLOSED Resolution|NEXTRELEASE |ERRATA Fixed In Version| |0.1.8-2.fc7