[Bug 181445] Review Request: php-shout
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: php-shout
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=181445
------- Additional Comments From dmitry(a)butskoy.name 2006-07-03 05:59 EST -------
"be_happy_mock" variant gives you a chance to not overlook that this is just the
"mock" issue.
Note, rpmbuild always detects these macros correctly. The "correct" fallback
variant (%{_libdir}/php/modules etc.) is not needed here anyway. (Moreover such
a fallback looks a little ugly, because to be clean you are caused to change it
each time the extdir/apiver was changed, which makes all the auto-detection
superfluous).
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
17 years, 9 months
[Bug 181445] Review Request: php-shout
by Red Hat Bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: php-shout
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=181445
------- Additional Comments From chris.stone(a)gmail.com 2006-07-03 00:47 EST -------
I would use these macros instead:
%define extdir %(php-config --extension-dir || echo %{_libdir}/php/modules)
%define apiver %((phpize --version 2>/dev/null || echo 'PHP Api Version:
20041225' ) | sed -n '/PHP Api Version/ s/.*: *//p')
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
17 years, 9 months